Revert "Move Dawn Ozone Image Representation over to Shared Texture Memory" [chromium/src : main]

0 views
Skip to first unread message

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,
Feb 24, 2026, 10:29:55 AMFeb 24
to Aaron Moss, Sasha Kunitskaya, AyeAye, Chromium LUCI CQ, Peter McNeeley, Vasiliy Telezhnikov, Michael Spang, David Worsham, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, cc-...@chromium.org, emi...@google.com, headless...@chromium.org, ozone-...@chromium.org, fuchsia...@chromium.org, nickdiego+wa...@igalia.com, spang...@chromium.org, penghu...@chromium.org, max+watc...@igalia.com
Attention needed from Michael Spang, Peter McNeeley and Vasiliy Telezhnikov

luci-bi...@appspot.gserviceaccount.com voted

LUCI Bisection is automatically submitting this revert.

Bot-Commit+1
Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Spang
  • Peter McNeeley
  • Vasiliy Telezhnikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0915c672efd69d0d3bcaf7f93eaf78b33ecdb39d
Gerrit-Change-Number: 7602964
Gerrit-PatchSet: 1
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Michael Spang <sp...@chromium.org>
Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-CC: Aaron Moss <aaro...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Sasha Kunitskaya <sask...@google.com>
Gerrit-Attention: Peter McNeeley <peterm...@google.com>
Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Attention: Michael Spang <sp...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Feb 2026 15:29:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Feb 24, 2026, 10:30:18 AMFeb 24
to luci-bi...@appspot.gserviceaccount.com, Aaron Moss, Sasha Kunitskaya, AyeAye, Peter McNeeley, Vasiliy Telezhnikov, Michael Spang, David Worsham, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, cc-...@chromium.org, emi...@google.com, headless...@chromium.org, ozone-...@chromium.org, fuchsia...@chromium.org, nickdiego+wa...@igalia.com, spang...@chromium.org, penghu...@chromium.org, max+watc...@igalia.com

Chromium LUCI CQ submitted the change

Change information

Commit message:
Revert "Move Dawn Ozone Image Representation over to Shared Texture Memory"

This reverts commit e36bb082f72c0049cc8a54af29e70e0f756434e1.

Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8688973723685130049

Sample failed build: https://ci.chromium.org/b/8688973723685130049

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6173060&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8688973723685130049&type=BUG

Original change's description:
> Move Dawn Ozone Image Representation over to Shared Texture Memory
>
> (Attempt #3)
>
> TESTED again on chromeos device using webgpu meets.
>
> This is done as far as ozone is concerned but the issue with opaque fences still remains. Basically ozone backing works with sync fences
> and the external_vk_image_backing doesnt not.
>
> We are able to make this change only because webGPU for LINUX is not
> enabled and will not be for the foreseeable future. WebGPU on linux
> will work with this change if it uses the external_vk_image_backing
> and associated representations.
>
> This is dependent on:
> https://dawn-review.googlesource.com/c/dawn/+/194440
>
> This means that we must use single copy for linux video import as we
> cannot use zero copy through ozone image backing (again due to
> the fence sync vs opaque issue)
>
> See: 'CanImportNativePixmapToWebGPU' function
>
> Bug: 330385376
> Change-Id: Ifaf2b8de9e9186a9f9e44ab0a74f2774de9035f6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6173060
> Reviewed-by: Michael Spang <sp...@chromium.org>
> Commit-Queue: Peter McNeeley <peterm...@google.com>
> Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1589395}
>
Bug: 330385376
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I0915c672efd69d0d3bcaf7f93eaf78b33ecdb39d
Cr-Commit-Position: refs/heads/main@{#1589399}
Files:
  • M components/viz/service/display/overlay_processor_ozone_unittest.cc
  • M gpu/command_buffer/service/BUILD.gn
  • M gpu/command_buffer/service/shared_image/dawn_ozone_image_representation.cc
  • M gpu/command_buffer/service/shared_image/dawn_ozone_image_representation.h
  • M gpu/command_buffer/service/webgpu_decoder_impl.cc
  • M ui/gfx/BUILD.gn
  • M ui/gfx/linux/native_pixmap_dmabuf.cc
  • M ui/gfx/linux/native_pixmap_dmabuf.h
  • M ui/gfx/native_pixmap.h
  • M ui/ozone/platform/drm/gpu/gbm_pixmap.cc
  • M ui/ozone/platform/drm/gpu/gbm_pixmap.h
  • M ui/ozone/platform/flatland/flatland_sysmem_native_pixmap.cc
  • M ui/ozone/platform/flatland/flatland_sysmem_native_pixmap.h
  • M ui/ozone/platform/headless/headless_surface_factory.cc
  • M ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.cc
  • M ui/ozone/platform/wayland/gpu/gbm_pixmap_wayland.h
Change size: L
Delta: 16 files changed, 63 insertions(+), 197 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0915c672efd69d0d3bcaf7f93eaf78b33ecdb39d
Gerrit-Change-Number: 7602964
Gerrit-PatchSet: 2
open
diffy
satisfied_requirement

Sasha Kunitskaya (Gerrit)

unread,
Feb 24, 2026, 10:31:14 AMFeb 24
to luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Aaron Moss, AyeAye, Peter McNeeley, Vasiliy Telezhnikov, Michael Spang, David Worsham, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, cc-...@chromium.org, emi...@google.com, headless...@chromium.org, ozone-...@chromium.org, fuchsia...@chromium.org, nickdiego+wa...@igalia.com, spang...@chromium.org, penghu...@chromium.org, max+watc...@igalia.com

Sasha Kunitskaya voted

Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0915c672efd69d0d3bcaf7f93eaf78b33ecdb39d
Gerrit-Change-Number: 7602964
Gerrit-PatchSet: 2
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Michael Spang <sp...@chromium.org>
Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
Gerrit-Reviewer: Sasha Kunitskaya <sask...@google.com>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-CC: Aaron Moss <aaro...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Feb 2026 15:30:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Peter McNeeley (Gerrit)

unread,
Feb 24, 2026, 10:45:35 AMFeb 24
to luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Sasha Kunitskaya, Aaron Moss, AyeAye, Vasiliy Telezhnikov, Michael Spang, David Worsham, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, cc-...@chromium.org, emi...@google.com, headless...@chromium.org, ozone-...@chromium.org, fuchsia...@chromium.org, nickdiego+wa...@igalia.com, spang...@chromium.org, penghu...@chromium.org, max+watc...@igalia.com

Peter McNeeley voted Code-Review+1

Code-Review+1
Gerrit-Comment-Date: Tue, 24 Feb 2026 15:45:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Sasha Kunitskaya (Gerrit)

unread,
Feb 24, 2026, 10:50:47 AMFeb 24
to luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Peter McNeeley, Aaron Moss, AyeAye, Vasiliy Telezhnikov, Michael Spang, David Worsham, Code Review Nudger, chromium...@chromium.org, Robert Kroeger, cc-...@chromium.org, emi...@google.com, headless...@chromium.org, ozone-...@chromium.org, fuchsia...@chromium.org, nickdiego+wa...@igalia.com, spang...@chromium.org, penghu...@chromium.org, max+watc...@igalia.com

Sasha Kunitskaya voted Code-Review+1

Gerrit-Comment-Date: Tue, 24 Feb 2026 15:50:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages