Sanitize cursor theme name and size in GTK and Wayland [chromium/src : main]
1 view
Skip to first unread message
Thomas Anderson (Gerrit)
Jul 29, 2026, 5:21:35 PMJul 29
to Yichen Zhou, chromium...@chromium.org, Henrique Ferreiro, Sadrul Chowdhury, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Yichen Zhou
Thomas Anderson voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Yichen Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yichen Zhou (Gerrit)
Jul 29, 2026, 5:33:36 PMJul 29
to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, Henrique Ferreiro, Sadrul Chowdhury, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson
Yichen Zhou added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Yichen Zhou . resolved
Hi can you cc me on https://g-issues.chromium.org/issues/540289900? I don't have access to the bug
Related details
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Jul 29, 2026, 5:42:00 PMJul 29
to Chromium LUCI CQ, Yichen Zhou, chromium...@chromium.org, Henrique Ferreiro, Sadrul Chowdhury, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Yichen Zhou
Thomas Anderson added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Yichen Zhou . resolved
Hi can you cc me on https://g-issues.chromium.org/issues/540289900? I don't have access to the bug
Attention is currently required from:
- Yichen Zhou
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yichen Zhou (Gerrit)
Jul 29, 2026, 5:50:25 PMJul 29
to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, Henrique Ferreiro, Sadrul Chowdhury, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson
Yichen Zhou voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yichen Zhou
| Code-Review | +1 |
1 comment
Patchset-level comments
Yichen Zhou . resolved
Thomas AndersonHi can you cc me on https://g-issues.chromium.org/issues/540289900? I don't have access to the bug
done
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yichen Zhou (Gerrit)
Jul 29, 2026, 5:50:53 PMJul 29
to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, Henrique Ferreiro, Sadrul Chowdhury, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson
Yichen Zhou added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Yichen Zhou . resolved
Thomas AndersonHi can you cc me on https://g-issues.chromium.org/issues/540289900? I don't have access to the bug
Yichen Zhoudone
Sorry, do you mind cc yic...@google.com too?
Yichen Zhou
Please ignore the above comment 😅
Thomas Anderson (Gerrit)
Jul 29, 2026, 9:23:44 PMJul 29
to Yichen Zhou, Chromium LUCI CQ, chromium...@chromium.org, Henrique Ferreiro, Sadrul Chowdhury, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Thomas Anderson voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 29, 2026, 9:50:18 PMJul 29
to Thomas Anderson, Yichen Zhou, chromium...@chromium.org, Henrique Ferreiro, Sadrul Chowdhury, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Sanitize cursor theme name and size in GTK and Wayland
This change extends GtkSettingsSetProperty interceptor and GtkUi to
sanitize gtk-cursor-theme-name and gtk-cursor-theme-size at write-time,
preventing unsanitized cursor theme names from being set in GTK
settings.
It also introduces unified ui::IsValidCursorThemeName and
ui::IsValidCursorThemeSize validation helpers in //ui/base/cursor, and
adds validation to WaylandCursorFactory to ensure invalid or
path-traversing cursor theme names are rejected before calling
wl_cursor_theme_load.
Change-Id: Ibe8a3ce208d76d2e724902424491a6116d4352f6
Fixed: 540289900
Reviewed-by: Yichen Zhou <yic...@chromium.org>
Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1670761}
Files:
- M ui/base/cursor/cursor_factory.cc
- M ui/base/cursor/cursor_factory.h
- M ui/base/cursor/cursor_unittest.cc
- M ui/base/x/x11_cursor_loader.cc
- M ui/gtk/gtk_ui.cc
- M ui/gtk/gtk_ui.h
- M ui/gtk/gtk_util.cc
- M ui/gtk/gtk_util.h
- M ui/gtk/gtk_util_unittest.cc
- M ui/ozone/platform/wayland/host/wayland_cursor_factory.cc
Change size: M
Delta: 10 files changed, 161 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yichen Zhou
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Antonio Alphonse (Gerrit)
Aug 3, 2026, 11:12:18 AM (10 days ago) Aug 3
to Chromium LUCI CQ, Thomas Anderson, Yichen Zhou, chromium...@chromium.org, Henrique Ferreiro, Sadrul Chowdhury, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Antonio Alphonse has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages