drm: Change LOG(ERROR) to VLOG(1) [chromium/src : main]

Mark Yacoub (Gerrit)

unread,

Oct 13, 2021, 10:45:50 AM10/13/21

to Daniel Nicoara, ozone-...@chromium.org

Attention is currently required from: Daniel Nicoara.

Mark Yacoub would like Daniel Nicoara to review this change.

drm: Change LOG(ERROR) to VLOG(1)

This isn't an error and VLOG(1) is enabled for Ozone code, so it'll show in the logs as well.

BUG=b:199333308
TEST=it compiles

Change-Id: Ib6295648c3eb3058aaed7497873923297ee74a50
---
M ui/ozone/platform/drm/gpu/drm_gpu_util.cc
1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/ui/ozone/platform/drm/gpu/drm_gpu_util.cc b/ui/ozone/platform/drm/gpu/drm_gpu_util.cc
index 0ecc85f..7ab2eb7 100644
--- a/ui/ozone/platform/drm/gpu/drm_gpu_util.cc
+++ b/ui/ozone/platform/drm/gpu/drm_gpu_util.cc
@@ -148,7 +148,7 @@
   // instead.
   for (uint32_t crtc : invalid_crtcs) {
     drmModeSetCrtc(fd, crtc, 0, 0, 0, nullptr, 0, nullptr);
-    LOG(ERROR) << "Disabled unpreferred CRTC " << crtc;
+    VLOG(1) << "Disabled unpreferred CRTC " << crtc;
   }
 
   return displays;

To view, visit change 3220863. To unsubscribe, or for help writing mail filters, visit settings.

Mark Yacoub (Gerrit)

unread,

Oct 13, 2021, 10:45:59 AM10/13/21

to ozone-...@chromium.org, Daniel Nicoara, chromium...@chromium.org

Attention is currently required from: Daniel Nicoara.

Patch set 2:Auto-Submit +1Commit-Queue +1

View Change

To view, visit change 3220863. To unsubscribe, or for help writing mail filters, visit settings.

Daniel Nicoara (Gerrit)

unread,

Oct 13, 2021, 10:46:43 AM10/13/21

to Mark Yacoub, ozone-...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Mark Yacoub.

Patch set 2:Code-Review +1Commit-Queue +2

View Change

To view, visit change 3220863. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Oct 13, 2021, 11:33:52 AM10/13/21

to Mark Yacoub, ozone-...@chromium.org, Daniel Nicoara, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Daniel Nicoara: Looks good to me; Commit
  Mark Yacoub: Dry run; Send CL to CQ automatically after approval

drm: Change LOG(ERROR) to VLOG(1)

This isn't an error and VLOG(1) is enabled for Ozone code, so it'll show in the logs as well.

BUG=b:199333308
TEST=it compiles

Change-Id: Ib6295648c3eb3058aaed7497873923297ee74a50

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220863
Commit-Queue: Mark Yacoub <marky...@google.com>
Commit-Queue: Daniel Nicoara <dnic...@chromium.org>
Auto-Submit: Mark Yacoub <marky...@google.com>
Reviewed-by: Daniel Nicoara <dnic...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#931067}
---
M ui/ozone/platform/drm/gpu/drm_gpu_util.cc
1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/ui/ozone/platform/drm/gpu/drm_gpu_util.cc b/ui/ozone/platform/drm/gpu/drm_gpu_util.cc
index 0ecc85f..7ab2eb7 100644
--- a/ui/ozone/platform/drm/gpu/drm_gpu_util.cc
+++ b/ui/ozone/platform/drm/gpu/drm_gpu_util.cc
@@ -148,7 +148,7 @@
   // instead.
   for (uint32_t crtc : invalid_crtcs) {
     drmModeSetCrtc(fd, crtc, 0, 0, 0, nullptr, 0, nullptr);
-    LOG(ERROR) << "Disabled unpreferred CRTC " << crtc;
+    VLOG(1) << "Disabled unpreferred CRTC " << crtc;
   }
 
   return displays;

To view, visit change 3220863. To unsubscribe, or for help writing mail filters, visit settings.

Mark Yacoub (Gerrit)

unread,

Oct 22, 2021, 10:20:12 AM10/22/21

to Chromium LUCI CQ, ozone-...@chromium.org, Daniel Nicoara, chromium...@chromium.org

Mark Yacoub has created a revert of this change.

View Change

To view, visit change 3220863. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward