[headless] Fix scaled headless screen origin and work area [chromium/src : main]
0 views
Skip to first unread message
Peter Kvitek (Gerrit)
Sep 5, 2025, 12:07:24 AM (3 days ago) Sep 5
to Andrey Kosyakov, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, droger+w...@chromium.org, headless...@chromium.org, mac-r...@chromium.org, ozone-...@chromium.org
Attention needed from Andrey Kosyakov
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Andrey Kosyakov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Sep 5, 2025, 1:48:41 PM (2 days ago) Sep 5
to Peter Kvitek, Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, droger+w...@chromium.org, headless...@chromium.org, mac-r...@chromium.org, ozone-...@chromium.org
Attention needed from Avi Drissman and Peter Kvitek
Andrey Kosyakov voted and added 4 comments![]( "Open in Gerrit")
Votes added by Andrey Kosyakov
| Code-Review | +1 |
4 comments
File chrome/browser/devtools/protocol/emulation_handler.cc
Line 189, Patchset 8 (Latest):
display, gfx::Rect(left, top, width, height), insets,Andrey Kosyakov . unresolved
Extract bounds into a variable for readability.
File headless/lib/browser/protocol/emulation_handler.cc
Line 155, Patchset 8 (Latest):
display, gfx::Rect(left, top, width, height), insets,Andrey Kosyakov . unresolved
Extract `bounds` into a variable for readability?
File ui/display/headless/headless_screen_manager.h
Line 46, Patchset 8 (Latest):
// work area insets and device pixel ratio.Andrey Kosyakov . unresolved
Mention that this is just a helper?
File ui/display/headless/headless_screen_manager.cc
Line 42, Patchset 8 (Latest):
if (!work_area_insets_pixels.IsEmpty()) {Andrey Kosyakov . unresolved
How about
```
gfx::Rect work_area = bounds;
if (!work_area_insets_pixels.IsEmpty()) {
work_area.Inset(gfx::ScaleToCeiledInsets(
work_area_insets_pixels, 1.0f / display.device_scale_factor()));
}
display.set_work_area(work_area);
```
So that the logic that varies upon condition is more evident.
Related details
Attention is currently required from:
- Avi Drissman
- Peter Kvitek
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter Kvitek (Gerrit)
Sep 5, 2025, 2:37:20 PM (2 days ago) Sep 5
to Andrey Kosyakov, Avi Drissman, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, droger+w...@chromium.org, headless...@chromium.org, mac-r...@chromium.org, ozone-...@chromium.org
Attention needed from Avi Drissman
Peter Kvitek added 4 comments![]( "Open in Gerrit")
File chrome/browser/devtools/protocol/emulation_handler.cc
Line 189, Patchset 8:
display, gfx::Rect(left, top, width, height), insets,Andrey Kosyakov . resolved
Extract bounds into a variable for readability.
Peter Kvitek
Done
File headless/lib/browser/protocol/emulation_handler.cc
Line 155, Patchset 8:
display, gfx::Rect(left, top, width, height), insets,Andrey Kosyakov . resolved
Extract `bounds` into a variable for readability?
Peter Kvitek
Done
File ui/display/headless/headless_screen_manager.h
Mention that this is just a helper?
Peter Kvitek
Done
File ui/display/headless/headless_screen_manager.cc
How about
```
gfx::Rect work_area = bounds;
if (!work_area_insets_pixels.IsEmpty()) {
work_area.Inset(gfx::ScaleToCeiledInsets(
work_area_insets_pixels, 1.0f / display.device_scale_factor()));
}
display.set_work_area(work_area);
```
So that the logic that varies upon condition is more evident.
Peter Kvitek
Done
Related details
Attention is currently required from:
- Avi Drissman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages