Saifuddin Hitawala (Gerrit)

unread,

Feb 11, 2026, 4:54:07 PM (9 days ago) Feb 11

to Kyle Charbonneau, Kramer Ge, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ozone-...@chromium.org

Attention needed from Dale Curtis, Kramer Ge and Kyle Charbonneau

Saifuddin Hitawala voted and added 1 comment

Votes added by Saifuddin Hitawala

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Saifuddin Hitawala . resolved

Please take a look.

Open in Gerrit

Related details

Attention is currently required from:

Dale Curtis
Kramer Ge
Kyle Charbonneau

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dale Curtis (Gerrit)

unread,

Feb 11, 2026, 5:59:56 PM (9 days ago) Feb 11

to Saifuddin Hitawala, Kyle Charbonneau, Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ozone-...@chromium.org

Attention needed from Kramer Ge, Kyle Charbonneau and Saifuddin Hitawala

Dale Curtis voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Kramer Ge
Kyle Charbonneau
Saifuddin Hitawala

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kyle Charbonneau (Gerrit)

unread,

Feb 12, 2026, 10:51:50 AM (8 days ago) Feb 12

to Saifuddin Hitawala, Dale Curtis, Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ozone-...@chromium.org

Attention needed from Kramer Ge and Saifuddin Hitawala

Kyle Charbonneau voted and added 2 comments

Votes added by Kyle Charbonneau

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Kyle Charbonneau . resolved

lgtm

File gpu/ipc/service/gpu_init.cc

Line 1184, Patchset 4 (Latest):

  if (gl_ozone) {
    gpu_feature_info_.supports_nv12_gl_native_pixmap =
        gl_ozone->CanImportNativePixmap(viz::MultiPlaneFormat::kNV12);
    gpu_feature_info_.supports_p010_gl_native_pixmap =
        gl_ozone->CanImportNativePixmap(viz::MultiPlaneFormat::kP010);
  }

Kyle Charbonneau . unresolved

This logic is different for the case where !gl_ozone but I just want to confirm that doesn't matter? Aka the values are only checked when we're using GrContextType::kGL.

Open in Gerrit

Related details

Attention is currently required from:

Kramer Ge
Saifuddin Hitawala

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kramer Ge (Gerrit)

unread,

Feb 12, 2026, 11:39:56 AM (8 days ago) Feb 12

to Saifuddin Hitawala, Kyle Charbonneau, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ozone-...@chromium.org

Attention needed from Saifuddin Hitawala

Kramer Ge voted and added 1 comment

Votes added by Kramer Ge

Code-Review

+1

1 comment

File gpu/ipc/service/gpu_init.cc

Line 1184, Patchset 4 (Latest):

  if (gl_ozone) {
    gpu_feature_info_.supports_nv12_gl_native_pixmap =
        gl_ozone->CanImportNativePixmap(viz::MultiPlaneFormat::kNV12);
    gpu_feature_info_.supports_p010_gl_native_pixmap =
        gl_ozone->CanImportNativePixmap(viz::MultiPlaneFormat::kP010);
  }

Kyle Charbonneau . unresolved

This logic is different for the case where !gl_ozone but I just want to confirm that doesn't matter? Aka the values are only checked when we're using GrContextType::kGL.

Kramer Ge

Yes, we only check it in [grcontext=gl, and assume support in vulkan](https://source.chromium.org/chromium/chromium/src/+/main:media/mojo/services/gpu_mojo_media_client_linux.cc;l=54;drc=b3eab4fd06ddbeee84b37224f4cc9d78094fc2f7;bpv=0;bpt=1)

Open in Gerrit

Related details

Attention is currently required from:

Saifuddin Hitawala

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Saifuddin Hitawala (Gerrit)

unread,

Feb 12, 2026, 11:43:04 AM (8 days ago) Feb 12

to Kyle Charbonneau, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ozone-...@chromium.org

Saifuddin Hitawala voted and added 2 comments

Votes added by Saifuddin Hitawala

Commit-Queue

+2

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Saifuddin Hitawala . resolved

Thanks for reviews!

File gpu/ipc/service/gpu_init.cc

Line 1184, Patchset 4 (Latest):

  if (gl_ozone) {
    gpu_feature_info_.supports_nv12_gl_native_pixmap =
        gl_ozone->CanImportNativePixmap(viz::MultiPlaneFormat::kNV12);
    gpu_feature_info_.supports_p010_gl_native_pixmap =
        gl_ozone->CanImportNativePixmap(viz::MultiPlaneFormat::kP010);
  }

Kyle Charbonneau . resolved

This logic is different for the case where !gl_ozone but I just want to confirm that doesn't matter? Aka the values are only checked when we're using GrContextType::kGL.

Kramer Ge

Yes, we only check it in [grcontext=gl, and assume support in vulkan](https://source.chromium.org/chromium/chromium/src/+/main:media/mojo/services/gpu_mojo_media_client_linux.cc;l=54;drc=b3eab4fd06ddbeee84b37224f4cc9d78094fc2f7;bpv=0;bpt=1)

Saifuddin Hitawala

Yes, the context type in media would have to GL before checking for these bools.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Feb 12, 2026, 11:46:35 AM (8 days ago) Feb 12

to Saifuddin Hitawala, Kramer Ge, Kyle Charbonneau, Dale Curtis, chromium...@chromium.org, feature-me...@chromium.org, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[ozone][gpu] Remove GetSupportedFormatsForGLNativePixmapImport

Instead of a vector of supported formats, add bools for checking if
Native Pixmap of NV12/P010 formats can be imported into GL for
media/mojo client. This can be done directly through
CanImportNativePixmap checks on GLOzone. This helps remove
GetSupportedFormatsForGLNativePixmapImport.

Eventually, we can look at moving supports_nv12_gl_native_pixmap
and supports_p010_gl_native_pixmap to SharedImageCapabilities
but also converging these with those for allocation and texturing.

Bug: 482216427

Change-Id: I1492ecafc91d840d03221e1115d2bc47e7ea6a32

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7562839

Commit-Queue: Saifuddin Hitawala <hita...@chromium.org>

Reviewed-by: Kyle Charbonneau <kyle...@chromium.org>

Reviewed-by: Kramer Ge <fang...@chromium.org>

Reviewed-by: Dale Curtis <dalec...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1584024}

Files:

M gpu/config/gpu_feature_info.h
M gpu/ipc/service/gpu_init.cc
M media/mojo/services/gpu_mojo_media_client_linux.cc
M ui/ozone/public/surface_factory_ozone.cc
M ui/ozone/public/surface_factory_ozone.h

Change size: M

Delta: 5 files changed, 31 insertions(+), 79 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Kyle Charbonneau, +1 by Dale Curtis, +1 by Kramer Ge

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[ozone][gpu] Remove GetSupportedFormatsForGLNativePixmapImport [chromium/src : main]

Saifuddin Hitawala (Gerrit)

Saifuddin Hitawala voted and added 1 comment

Votes added by Saifuddin Hitawala

1 comment

Related details

Dale Curtis (Gerrit)

Dale Curtis voted Code-Review+1

Related details

Kyle Charbonneau (Gerrit)

Kyle Charbonneau voted and added 2 comments

Votes added by Kyle Charbonneau

2 comments

Related details

Kramer Ge (Gerrit)

Kramer Ge voted and added 1 comment

Votes added by Kramer Ge

1 comment

Related details

Saifuddin Hitawala (Gerrit)

Saifuddin Hitawala voted and added 2 comments

Votes added by Saifuddin Hitawala

2 comments

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information