[M145] Fix crash when exiting fullscreen on Linux with Metacity WM [chromium/src : refs/branch-heads/7632]

0 views

Skip to first unread message

Rubber Stamper (Gerrit)

unread,

Jan 20, 2026, 3:46:16 PM (12 days ago) Jan 20

to Chrome Cherry Picker, Patryk Chodur, AyeAye, ozone-...@chromium.org

Rubber Stamper voted

Bot-Commit	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Lint
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 20, 2026, 4:54:10 PM (12 days ago) Jan 20

to Chrome Cherry Picker, Patryk Chodur, Rubber Stamper, AyeAye, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[M145] Fix crash when exiting fullscreen on Linux with Metacity WM

Original change's description:
> Fix crash when exiting fullscreen on Linux with Metacity WM
> 
> This commit fixes a problem with segmentation fault when exiting
> fullscreen on X11 Linux with Metacity window manager.
> 
> In the SetFullscreen(bool), function there's a workaround for a problem
> with Metacity window manager. Along with the changed introduced in
> https://crrev.com/c/7095963, exiting fullscreen causes an infinite call
> loop. The SetFullscreen(false) calls Restore(), which then calls
> SetFullscreen(false) if the window was in fullscreen mode.
> 
> This commit fixes the problem by changing the Restore() and Maximize()
> functions used in the workaround to a function doing just unmaximizing
> and maximizing with the SetWMSpecState. The Restore() and Maximize()
> functions work on a higher level and decide what to do based on the
> current state. Looking at the workaround code, the intention was to just
> trigger unmaximizing and maximizing again.
> 
> Bug: 476835800
> Change-Id: I77f355d30907e5343429527b9964508a4ab59be2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7493579
> Commit-Queue: Patryk Chodur <pch...@google.com>
> Reviewed-by: Kyle Charbonneau <kyle...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1571323}

(cherry picked from commit 3c577742667aa686cb0f15b31654118b6d4e158e)