Thomas Anderson (Gerrit)

unread,

Mar 12, 2026, 5:08:45 PMMar 12

to Lei Zhang, chromium...@chromium.org, Sadrul Chowdhury, dcheng+c...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Lei Zhang

Thomas Anderson voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Mar 12, 2026, 5:34:52 PMMar 12

to Thomas Anderson, Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, dcheng+c...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Thomas Anderson

Lei Zhang voted and added 4 comments

Votes added by Lei Zhang

Code-Review

+1

4 comments

Commit Message

Line 9, Patchset 2 (Latest):This change refactors the IsSelectionOwner method in the PlatformClipboard

Lei Zhang . unresolved

Wrap at 72 columns.

Line 15, Patchset 2 (Latest):Bug: None

Lei Zhang . unresolved

40398800

File ui/base/x/x11_clipboard_helper.h

Line 78, Patchset 2 (Latest): // Tells if we currently own the selection for a given clipboard `buffer`.

Lei Zhang . unresolved

Update comment.

File ui/ozone/public/platform_clipboard.h

Line 64, Patchset 2 (Latest): // Returns true if the current application writing data to the host clipboard

Lei Zhang . unresolved

Update comment.

Open in Gerrit

Related details

Attention is currently required from:

Thomas Anderson

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Thomas Anderson (Gerrit)

unread,

Mar 12, 2026, 6:46:41 PMMar 12

to Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, dcheng+c...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Thomas Anderson voted and added 4 comments

Votes added by Thomas Anderson

Commit-Queue

+1

4 comments

Commit Message

Line 9, Patchset 2:This change refactors the IsSelectionOwner method in the PlatformClipboard

Lei Zhang . resolved

Wrap at 72 columns.

Thomas Anderson

Done

Line 15, Patchset 2:Bug: None

Lei Zhang . resolved

40398800

Thomas Anderson

Done

File ui/base/x/x11_clipboard_helper.h

Line 78, Patchset 2: // Tells if we currently own the selection for a given clipboard `buffer`.

Lei Zhang . resolved

Update comment.

Thomas Anderson

Done

File ui/ozone/public/platform_clipboard.h

Line 64, Patchset 2: // Returns true if the current application writing data to the host clipboard

Lei Zhang . resolved

Update comment.

Thomas Anderson

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Thomas Anderson (Gerrit)

unread,

Mar 12, 2026, 9:17:25 PMMar 12

to Kramer Ge, Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, dcheng+c...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Kramer Ge

Thomas Anderson added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Thomas Anderson . resolved

+Kramer for ui/ozone/public/platform_clipboard.h

Open in Gerrit

Related details

Attention is currently required from:

Kramer Ge

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Thomas Anderson (Gerrit)

unread,

Mar 13, 2026, 10:57:16 AMMar 13

to Kramer Ge, Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, dcheng+c...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Kramer Ge

Thomas Anderson voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Kramer Ge

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kramer Ge (Gerrit)

unread,

Mar 13, 2026, 12:54:48 PMMar 13

to Thomas Anderson, Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, dcheng+c...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Attention needed from Thomas Anderson

Kramer Ge voted and added 1 comment

Votes added by Kramer Ge

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Kramer Ge . resolved

ozone +1

Open in Gerrit

Related details

Attention is currently required from:

Thomas Anderson

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Thomas Anderson (Gerrit)

unread,

Mar 13, 2026, 1:26:37 PMMar 13

to Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, dcheng+c...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Thomas Anderson voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Mar 13, 2026, 1:37:18 PMMar 13

to Thomas Anderson, Kramer Ge, Lei Zhang, chromium...@chromium.org, Sadrul Chowdhury, dcheng+c...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[X11] Make IsSelectionOwner asynchronous in PlatformClipboard



This change refactors the IsSelectionOwner method in the

PlatformClipboard interface and its implementations to be asynchronous.
This allows the X11 backend to eliminate a synchronous X11 Sync() call
in GetSelectionOwner, furthering the goal of an entirely asynchronous
clipboard architecture.

R=thestig

Change-Id: Ic616ebb106d3fcb36a83a47c70da6742887a70d3

Bug: 40398800

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7659748

Commit-Queue: Thomas Anderson <thomasa...@chromium.org>

Auto-Submit: Thomas Anderson <thomasa...@chromium.org>

Reviewed-by: Kramer Ge <fang...@chromium.org>

Reviewed-by: Lei Zhang <the...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1599158}

Files:

M ui/base/clipboard/clipboard_ozone.cc
M ui/base/x/x11_clipboard_helper.cc
M ui/base/x/x11_clipboard_helper.h
M ui/ozone/platform/wayland/host/wayland_clipboard.cc
M ui/ozone/platform/wayland/host/wayland_clipboard.h
M ui/ozone/platform/wayland/host/wayland_clipboard_unittest.cc
M ui/ozone/platform/x11/x11_clipboard_ozone.cc
M ui/ozone/platform/x11/x11_clipboard_ozone.h
M ui/ozone/public/platform_clipboard.h

Change size: M

Delta: 9 files changed, 143 insertions(+), 48 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Kramer Ge, +1 by Lei Zhang

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

David Baron (Gerrit)

unread,

Mar 13, 2026, 3:46:36 PMMar 13

to Chromium LUCI CQ, Thomas Anderson, David Baron, Lei Zhang, chromium...@chromium.org, Sadrul Chowdhury, dcheng+c...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

David Baron added 1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

David Baron . unresolved

I think it seems likely that this CL is causing the `OmniboxViewTest.Paste` browsertest to fail on linux-rel-ready:
https://ci.chromium.org/ui/b/8687423217582013825
though I'm not sure that this is the cause.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

David Baron (Gerrit)

unread,

Mar 13, 2026, 4:31:12 PMMar 13

to Chromium LUCI CQ, Thomas Anderson, David Baron, Lei Zhang, chromium...@chromium.org, Sadrul Chowdhury, dcheng+c...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

David Baron has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[X11] Make IsSelectionOwner asynchronous in PlatformClipboard [chromium/src : main]

Thomas Anderson (Gerrit)

Thomas Anderson voted Commit-Queue+1

Related details

Lei Zhang (Gerrit)

Lei Zhang voted and added 4 comments

Votes added by Lei Zhang

4 comments

Related details

Thomas Anderson (Gerrit)

Thomas Anderson voted and added 4 comments

Votes added by Thomas Anderson

4 comments

Related details

Thomas Anderson (Gerrit)

Thomas Anderson added 1 comment

Related details

Thomas Anderson (Gerrit)

Thomas Anderson voted

Related details

Kramer Ge (Gerrit)

Kramer Ge voted and added 1 comment

Votes added by Kramer Ge

1 comment

Related details

Thomas Anderson (Gerrit)

Thomas Anderson voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

David Baron (Gerrit)

David Baron added 1 comment

Related details

David Baron (Gerrit)

David Baron has created a revert of this change

Related details