[X11] Make IsSelectionOwner asynchronous in PlatformClipboard [chromium/src : main]

0 views
Skip to first unread message

Thomas Anderson (Gerrit)

unread,
Mar 12, 2026, 5:08:45 PM (15 hours ago) Mar 12
to Lei Zhang, chromium...@chromium.org, Sadrul Chowdhury, dcheng+c...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Lei Zhang

Thomas Anderson voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic616ebb106d3fcb36a83a47c70da6742887a70d3
Gerrit-Change-Number: 7659748
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Thu, 12 Mar 2026 21:08:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Mar 12, 2026, 5:34:52 PM (14 hours ago) Mar 12
to Thomas Anderson, Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, dcheng+c...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson

Lei Zhang voted and added 4 comments

Votes added by Lei Zhang

Code-Review+1

4 comments

Commit Message
Line 9, Patchset 2 (Latest):This change refactors the IsSelectionOwner method in the PlatformClipboard
Lei Zhang . unresolved

Wrap at 72 columns.

Line 15, Patchset 2 (Latest):Bug: None
Lei Zhang . unresolved

40398800

File ui/base/x/x11_clipboard_helper.h
Line 78, Patchset 2 (Latest): // Tells if we currently own the selection for a given clipboard `buffer`.
Lei Zhang . unresolved

Update comment.

File ui/ozone/public/platform_clipboard.h
Line 64, Patchset 2 (Latest): // Returns true if the current application writing data to the host clipboard
Lei Zhang . unresolved

Update comment.

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Anderson
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic616ebb106d3fcb36a83a47c70da6742887a70d3
    Gerrit-Change-Number: 7659748
    Gerrit-PatchSet: 2
    Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Comment-Date: Thu, 12 Mar 2026 21:34:42 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Thomas Anderson (Gerrit)

    unread,
    Mar 12, 2026, 6:46:41 PM (13 hours ago) Mar 12
    to Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, dcheng+c...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

    Thomas Anderson voted and added 4 comments

    Votes added by Thomas Anderson

    Commit-Queue+1

    4 comments

    Commit Message
    Line 9, Patchset 2:This change refactors the IsSelectionOwner method in the PlatformClipboard
    Lei Zhang . resolved

    Wrap at 72 columns.

    Thomas Anderson

    Done

    Line 15, Patchset 2:Bug: None
    Lei Zhang . resolved

    40398800

    Thomas Anderson

    Done

    File ui/base/x/x11_clipboard_helper.h
    Line 78, Patchset 2: // Tells if we currently own the selection for a given clipboard `buffer`.
    Lei Zhang . resolved

    Update comment.

    Thomas Anderson

    Done

    File ui/ozone/public/platform_clipboard.h
    Line 64, Patchset 2: // Returns true if the current application writing data to the host clipboard
    Lei Zhang . resolved

    Update comment.

    Thomas Anderson

    Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic616ebb106d3fcb36a83a47c70da6742887a70d3
      Gerrit-Change-Number: 7659748
      Gerrit-PatchSet: 5
      Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
      Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
      Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
      Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
      Gerrit-Comment-Date: Thu, 12 Mar 2026 22:46:32 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Thomas Anderson (Gerrit)

      unread,
      Mar 12, 2026, 9:17:25 PM (10 hours ago) Mar 12
      to Kramer Ge, Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, dcheng+c...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
      Attention needed from Kramer Ge

      Thomas Anderson added 1 comment

      Patchset-level comments
      File-level comment, Patchset 6 (Latest):
      Thomas Anderson . resolved

      +Kramer for ui/ozone/public/platform_clipboard.h

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Kramer Ge
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic616ebb106d3fcb36a83a47c70da6742887a70d3
      Gerrit-Change-Number: 7659748
      Gerrit-PatchSet: 6
      Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
      Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
      Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
      Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
      Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
      Gerrit-Attention: Kramer Ge <fang...@chromium.org>
      Gerrit-Comment-Date: Fri, 13 Mar 2026 01:17:15 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages