Lei Zhang (Gerrit)

unread,

Nov 19, 2025, 1:40:58 PM (12 days ago) Nov 19

to Lei Zhang, Fred Shih, AyeAye, chromium...@chromium.org, David Worsham, (Julie)Jeongeun Kim, Kevin McNee, Rijubrata Bhaumik, Robert Kroeger, Sophie Chang, Ian Vollick, James Maclean, Chromium LUCI CQ, abigailbk...@google.com, android-web...@chromium.org, asvitki...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, derinel+wat...@google.com, dewitt...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, emi...@google.com, erickun...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, halliwe...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, mac-r...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, spang...@chromium.org, storage...@chromium.org, webauthn...@chromium.org, yuzo+...@chromium.org

Attention needed from Fred Shih

Lei Zhang added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Lei Zhang . resolved

Please OO+1 as //mojo/OWNERS.

Open in Gerrit

Related details

Attention is currently required from:

Fred Shih

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Fred Shih (Gerrit)

unread,

Nov 19, 2025, 7:10:21 PM (11 days ago) Nov 19

to Lei Zhang, AyeAye, chromium...@chromium.org, David Worsham, (Julie)Jeongeun Kim, Kevin McNee, Rijubrata Bhaumik, Robert Kroeger, Sophie Chang, Ian Vollick, James Maclean, Chromium LUCI CQ, abigailbk...@google.com, android-web...@chromium.org, asvitki...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, derinel+wat...@google.com, dewitt...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, emi...@google.com, erickun...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, halliwe...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, mac-r...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, spang...@chromium.org, storage...@chromium.org, webauthn...@chromium.org, yuzo+...@chromium.org

Attention needed from Lei Zhang

Fred Shih voted and added 1 comment

Votes added by Fred Shih

Code-Review	+1
Owners-Override	+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Fred Shih . resolved

LGTM. OO+1 because these are just #include changes.

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 19, 2025, 7:13:29 PM (11 days ago) Nov 19

to Lei Zhang, Fred Shih, AyeAye, chromium...@chromium.org, David Worsham, (Julie)Jeongeun Kim, Kevin McNee, Rijubrata Bhaumik, Robert Kroeger, Sophie Chang, Ian Vollick, James Maclean, Chromium LUCI CQ, abigailbk...@google.com, android-web...@chromium.org, asvitki...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, derinel+wat...@google.com, dewitt...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, emi...@google.com, erickun...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, halliwe...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, mac-r...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, spang...@chromium.org, storage...@chromium.org, webauthn...@chromium.org, yuzo+...@chromium.org

Lei Zhang voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Nov 19, 2025, 7:16:51 PM (11 days ago) Nov 19

to Lei Zhang, Fred Shih, AyeAye, Akihiro Ota, chromium...@chromium.org, David Worsham, (Julie)Jeongeun Kim, Kevin McNee, Rijubrata Bhaumik, Robert Kroeger, Sophie Chang, Ian Vollick, James Maclean, abigailbk...@google.com, android-web...@chromium.org, asvitki...@chromium.org, chfreme...@chromium.org, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, derinel+wat...@google.com, dewitt...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, emi...@google.com, erickun...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, halliwe...@chromium.org, headless...@chromium.org, jbauma...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, lcwu+...@chromium.org, mac-r...@chromium.org, max+watc...@igalia.com, media-cro...@chromium.org, mfoltz+wa...@chromium.org, nektar...@chromium.org, nickdiego+wa...@igalia.com, oshima...@chromium.org, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, spang...@chromium.org, storage...@chromium.org, webauthn...@chromium.org, yuzo+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Remove superfluous includes for Mojo bindings in various headers

Remove includes for mojo/public/cpp/bindings/receiver.h in headers that
do not reference mojo::Receiver. Repeat the same search and delete for
remote.h, pending_remote.h, associated_pending_receiver.h, etc. Then do
IWYU to fix the build.

Bug: 40318405

Change-Id: I6ffc5d40022918d11de67ba5f567a8c6b4655740

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7159187

Reviewed-by: Fred Shih <ff...@chromium.org>

Commit-Queue: Lei Zhang <the...@chromium.org>

Owners-Override: Fred Shih <ff...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1547530}

Files:

M android_webview/browser/aw_content_browser_client.h
M android_webview/browser/safe_browsing/aw_safe_browsing_ui_manager.h
M chrome/browser/contextual_tasks/contextual_tasks_page_handler.h
M chrome/browser/contextual_tasks/contextual_tasks_ui.h
M chrome/browser/glic/public/glic_keyed_service.h
M chrome/browser/ui/webui/omnibox_popup/omnibox_popup_ui.h
M chromecast/browser/cast_web_contents_observer.h
M chromecast/browser/metrics/metrics_helper_impl.h
M chromecast/external_mojo/external_service_support/fake_external_connector.h
M chromecast/media/audio/cast_audio_device_factory.cc
M chromecast/media/audio/cast_audio_output_device.h
M device/fido/fido_discovery_factory.h
M device/vr/android/arcore/arcore_device.h
M device/vr/android/arcore/arcore_gl.h
M device/vr/openxr/openxr_render_loop.h
M device/vr/orientation/orientation_session.h
M device/vr/test/fake_vr_device_provider.h
M extensions/browser/api/automation_internal/automation_event_router.h
M extensions/browser/api/hid/hid_device_manager.h
M extensions/browser/api/socket/socket_api.h
M extensions/browser/api/socket/tcp_socket.h
M extensions/browser/api/sockets_udp/sockets_udp_api.h
M extensions/browser/api/webcam_private/visca_webcam.h
M extensions/browser/guest_view/web_view/controlled_frame_embedder_url_fetcher.h
M extensions/browser/image_sanitizer.h
M extensions/browser/json_file_sanitizer.h
M extensions/browser/sandboxed_unpacker.h
M extensions/browser/url_loader_factory_manager.h
M extensions/shell/browser/shell_content_browser_client.h
M gpu/ipc/service/gpu_channel.h
M headless/lib/browser/headless_browser_context_impl.h
M headless/lib/browser/headless_request_context_manager.h
M ipc/ipc_channel.h
M ipc/ipc_channel_proxy.h
M media/capture/video/chromeos/camera_hal_delegate.h
M media/capture/video/chromeos/camera_hal_dispatcher_impl.h
M media/capture/video/chromeos/mock_camera_module.h
M media/capture/video/video_capture_device_client.h
M media/mojo/clients/win/media_foundation_renderer_client.h
M media/mojo/services/interface_factory_impl.h
M media/mojo/services/media_foundation_preferences.h
M media/mojo/services/mojo_video_encode_accelerator_service.h
M media/mojo/services/playback_events_recorder.h
M media/remoting/stream_provider.h
M storage/browser/blob/blob_url_registry.h
M storage/browser/blob/blob_url_store_impl.h
M storage/browser/blob/write_blob_to_file.h
M storage/browser/test/mock_quota_manager_proxy.h
M ui/accessibility/platform/automation/automation_tree_manager_owner.h
M ui/compositor/test/in_process_context_factory.h
M ui/ozone/platform/flatland/flatland_gpu_host.h
M ui/ozone/platform/wayland/host/wayland_buffer_manager_connector.cc
M ui/ozone/platform/wayland/host/wayland_buffer_manager_connector.h
M ui/ozone/platform/wayland/host/wayland_buffer_manager_host.h
M ui/views/controls/menu/menu_runner_impl_mac.h
M ui/webui/examples/browser/ui/web/browser_page_handler.h

Change size: M

Delta: 56 files changed, 6 insertions(+), 67 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Fred Shih

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Remove superfluous includes for Mojo bindings in various headers [chromium/src : main]

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Related details

Fred Shih (Gerrit)

Fred Shih voted and added 1 comment

Votes added by Fred Shih

1 comment

Related details

Lei Zhang (Gerrit)

Lei Zhang voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information