Migrate last base::Contains to .contains() [chromium/src : main]

0 views
Skip to first unread message

Victor Vianna (Gerrit)

unread,
Jan 9, 2026, 5:22:15 PM (2 days ago) Jan 9
to Nico Weber, Victor Tan, Andrew Rayskiy, Simon Hangl, Mike Taylor, Zijie He, Robert Kroeger, David Worsham, Kevin Babbitt, Sadrul Chowdhury, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Rijubrata Bhaumik, James Su, dmurph+wat...@chromium.org, halliwe...@chromium.org, sky+...@chromium.org, dmurph+watchin...@chromium.org, rmcelra...@chromium.org, vaapi-...@chromium.org, media-cro...@chromium.org, chromeos-gfx-...@google.com, ios-revie...@chromium.org, marq+...@chromium.org, emi...@google.com, spang...@chromium.org, ozone-...@chromium.org, fuzzin...@chromium.org, fuchsia...@chromium.org, wfh+...@chromium.org, chromotin...@chromium.org, zelin+watch-we...@chromium.org, roblia...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, dibyapal+wa...@chromium.org, network-ser...@chromium.org, dmurph+watc...@chromium.org, lucasrada...@google.com, jessemcke...@google.com, kuragin+web-ap...@chromium.org, loyso...@chromium.org, grt+...@chromium.org, dfried...@chromium.org, performance-m...@chromium.org, nikhilcn+wat...@google.com, estali...@chromium.org, jiajunz+wat...@google.com, hansberry+wa...@chromium.org, chadduffin+wa...@chromium.org, mac-r...@chromium.org, khorimoto+wa...@chromium.org, jonmann+watc...@chromium.org, jackshira+wat...@google.com, jackshira+wa...@google.com, hsuregan+wat...@chromium.org, ios-r...@chromium.org, chromium-a...@chromium.org, joeantonetti+wa...@google.com, ajayramamurthy+w...@google.com, cbe-cep-eng...@google.com, extension...@chromium.org, tmartino+tran...@chromium.org, oshima...@chromium.org, hansberry+wat...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, cambickel...@google.com, cc-...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, cros-print...@google.com, dcheng+c...@chromium.org, derinel+wat...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, iclella...@chromium.org, jdonnel...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kyungjunle...@google.com, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelchec...@google.com, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, shuche...@chromium.org, storage...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webapks-...@chromium.org, webauthn...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Nico Weber

Victor Vianna voted and added 3 comments

Votes added by Victor Vianna

Auto-Submit+1
Commit-Queue+1

3 comments

Patchset-level comments
File-level comment, Patchset 16 (Latest):
Victor Vianna . resolved

ptal

File android_webview/browser/aw_content_browser_client.cc
File-level comment, Patchset 16 (Latest):
Victor Vianna . resolved

It's a big one, but hopefully it's trivial to review (other than scrolling for a while). This is the last one in a series of many splits

File media/gpu/v4l2/legacy/v4l2_video_decoder_backend_stateful.cc
Line 48, Patchset 16 (Latest): return driver_name == "qcom-venus";
Victor Vianna . resolved

Simplified the logic here

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Weber
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I313e9d70cfd283ea19c02cfca1dafec97318207e
Gerrit-Change-Number: 7414280
Gerrit-PatchSet: 16
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Mike Taylor <mike...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Victor Tan <vict...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Nico Weber <tha...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 22:22:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages