[CodeHealth] Remove stale base::Feature EnableOrdinalMotion [chromium/src : main]
Hidehiko Abe (Gerrit)
Hidehiko Abe voted and added 2 comments![]( "Open in Gerrit")
Votes added by Hidehiko Abe
| Code-Review | +1 |
2 comments
Code wise LG (so marking +1 to avoid additional iteration).
Feature-wise, David, do you know more context?
enabled by default. Also, the TODO bug (b/171249701) to always enablePlease fix this WARNING reported by No short links in OSS: Do not use b/<number> in OSS code. Prefer crbug.com/<number> instead. While bugs...
Do not use b/<number> in OSS code. Prefer crbug.com/<number> instead. While bugs should be public by default, bugs that must remain internal may use b/<number>, ignoring this warning; see https://www.chromium.org/issue-tracking/googler-guidelines/.
Related details
- Benjamin Keen
- David Riley
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benjamin Keen (Gerrit)
Benjamin Keen added 1 comment![]( "Open in Gerrit")
enabled by default. Also, the TODO bug (b/171249701) to always enablePlease fix this WARNING reported by No short links in OSS: Do not use b/<number> in OSS code. Prefer crbug.com/<number> instead. While bugs...
Do not use b/<number> in OSS code. Prefer crbug.com/<number> instead. While bugs should be public by default, bugs that must remain internal may use b/<number>, ignoring this warning; see https://www.chromium.org/issue-tracking/googler-guidelines/.
- David Riley
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Riley (Gerrit)
David Riley added 1 comment![]( "Open in Gerrit")
Code wise LG (so marking +1 to avoid additional iteration).
Feature-wise, David, do you know more context?
I'm not too familiar with the details, but I think it's safe to remove.
Related details
- Benjamin Keen
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benjamin Keen (Gerrit)
Benjamin Keen added 1 comment![]( "Open in Gerrit")
David RileyCode wise LG (so marking +1 to avoid additional iteration).
Feature-wise, David, do you know more context?
I'm not too familiar with the details, but I think it's safe to remove.
Thank you all, any ideas who may be more familiar with this feature? Also adding @til...@google.com who may have some additional context.
Related details
- David Riley
- Hidehiko Abe
- Tilanka Munasinghe
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Riley (Gerrit)
David Riley added 1 comment![]( "Open in Gerrit")
David RileyCode wise LG (so marking +1 to avoid additional iteration).
Feature-wise, David, do you know more context?
Benjamin KeenI'm not too familiar with the details, but I think it's safe to remove.
Thank you all, any ideas who may be more familiar with this feature? Also adding @til...@google.com who may have some additional context.
- Benjamin Keen
- Hidehiko Abe
- Tilanka Munasinghe
Mitsuru Oshima (Gerrit)
Mitsuru Oshima added 1 comment![]( "Open in Gerrit")
gfx::Vector2dF movement_;is this used in other platforms ?
Related details
- Benjamin Keen
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benjamin Keen (Gerrit)
Benjamin Keen added 1 comment![]( "Open in Gerrit")
gfx::Vector2dF movement_;is this used in other platforms ?
In addition to `CrOS` I am only seeing this used on `Windows`: https://source.chromium.org/search?q=MouseEvent::DispatcherApi.*set_movement%20-f:test&sq=
Related details
- Mitsuru Oshima
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mitsuru Oshima (Gerrit)
Mitsuru Oshima voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mitsuru Oshima
| Code-Review | +1 |
1 comment
gfx::Vector2dF movement_;Benjamin Keenis this used in other platforms ?
In addition to `CrOS` I am only seeing this used on `Windows`: https://source.chromium.org/search?q=MouseEvent::DispatcherApi.*set_movement%20-f:test&sq=
- Benjamin Keen
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benjamin Keen (Gerrit)
Benjamin Keen added 2 comments![]( "Open in Gerrit")
David RileyCode wise LG (so marking +1 to avoid additional iteration).
Feature-wise, David, do you know more context?
Benjamin KeenI'm not too familiar with the details, but I think it's safe to remove.
David RileyThank you all, any ideas who may be more familiar with this feature? Also adding @til...@google.com who may have some additional context.
Maybe oshima?
Thank you all for the help here.
gfx::Vector2dF movement_;Benjamin Keenis this used in other platforms ?
Mitsuru OshimaIn addition to `CrOS` I am only seeing this used on `Windows`: https://source.chromium.org/search?q=MouseEvent::DispatcherApi.*set_movement%20-f:test&sq=
My search somehow didn't show windows, Thank you.
Thanks for the review!
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benjamin Keen (Gerrit)
Benjamin Keen voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
[CodeHealth] Remove stale base::Feature EnableOrdinalMotion
Removing feature since it was introduced in M88 and has not been enabled
by default. Also, the TODO bug (linked below) to always enable on CrOS
has been closed as "Won't fix (Obsolete)".
- M ui/events/event.h
- M ui/events/ozone/evdev/event_factory_evdev.cc
- M ui/events/ozone/evdev/event_factory_evdev_unittest.cc
- M ui/events/ozone/features.cc
- M ui/events/ozone/features.h
Code-Review: +1 by Mitsuru Oshima, +1 by Hidehiko Abe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |