[agy][ozone/drm] Validate protected NativePixmap [chromium/src : main]
0 views
Skip to first unread message
Tzarial (Gerrit)
Jul 17, 2026, 6:08:21 PM (6 days ago) Jul 17
to Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Kramer Ge
Tzarial added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Jul 21, 2026, 3:45:28 PM (2 days ago) Jul 21
to Tzarial, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Tzarial
Kramer Ge voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kramer Ge
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Tzarial
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tzarial (Gerrit)
Jul 21, 2026, 4:47:52 PM (2 days ago) Jul 21
to Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Tzarial voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 21, 2026, 5:35:06 PM (2 days ago) Jul 21
to Tzarial, Kramer Ge, chromium...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[agy][ozone/drm] Validate protected NativePixmap
GbmSurfaceFactory::CreateNativePixmapFromHandle() may substitute a
previously registered protected NativePixmap for the supplied handle,
but did not check that the substituted pixmap's size and format match
what the caller requested. The caller (OzoneImageBackingFactory) builds
the resulting backing with the requested geometry, so a mismatch would
bind an inconsistent size/format to the underlying dmabuf when later
imported into Vulkan or EGL.
Reject the import when the substituted protected pixmap does not match
the requested size or format, and add unit coverage for the
protected-pixmap delegate path.
Fixed: 501762862
Test: ozone_unittests --gtest_filter=GbmSurfaceFactoryTest.*
Change-Id: I611686a36ed834eed3c7842dbafdafdb7bc8b75d
Reviewed-by: Kramer Ge <fang...@chromium.org>
Commit-Queue: Tzarial <zo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1665803}
Files:
- M ui/ozone/platform/drm/BUILD.gn
- M ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
- A ui/ozone/platform/drm/gpu/gbm_surface_factory_unittest.cc
Change size: M
Delta: 3 files changed, 100 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kramer Ge
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages