Subtract insets before setting constraints on xdg toplevel [chromium/src : main]
0 views
Skip to first unread message
Mitchell Cohen (Gerrit)
Jan 11, 2026, 3:33:23 PMJan 11
to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson
Mitchell Cohen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Mitchell Cohen . resolved
I ran into a consequence of this bug in Electron. It doesn't have much of an impact on Chrome at the moment, but it will likely matter more if/when Chrome starts using CSD insets for secondary windows, PWAs, etc where size constraints matter.
To clarify a bit more: min/max size constraints are inflated by insets on Wayland (and they're alredy treated as such in `AdjustBoundsToConstraintsPx`). So they need to be deflated before being applied on the toplevel, which expects geometry bounds.
Related details
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Jan 12, 2026, 10:36:31 AMJan 12
to Mitchell Cohen, Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge and Mitchell Cohen
Thomas Anderson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Anderson
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Kramer Ge
- Mitchell Cohen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Jan 12, 2026, 11:23:08 AMJan 12
to Mitchell Cohen, Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Mitchell Cohen
Kramer Ge voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kramer Ge
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Attention is currently required from:
- Mitchell Cohen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 12, 2026, 11:27:03 AMJan 12
to Mitchell Cohen, Kramer Ge, Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Subtract insets before setting constraints on xdg toplevel
Wayland expects min/max window sizes in geometric coordinates, but
Chromium size constraints are based on window bounds and include insets.
These need to be subtracted in SetSizeConstraints just as they are in
SetWindowGeometry.
Bug: 473444521
Change-Id: I3821300b943733c51fb2de72e9e560d3f4e95b05
Reviewed-by: Kramer Ge <fang...@chromium.org>
Commit-Queue: Kramer Ge <fang...@chromium.org>
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1567793}
Files:
- M ui/ozone/platform/wayland/host/wayland_toplevel_window.cc
Change size: S
Delta: 1 file changed, 23 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Anderson, +1 by Kramer Ge
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages