[Wayland] Fix crash when moving windows between monitors with color management [chromium/src : main]

0 views
Skip to first unread message

Helmut Januschka (Gerrit)

unread,
Oct 4, 2025, 3:34:33 PM (3 days ago) Oct 4
to Helmut Januschka, Tom Lukaszewicz, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Tom Lukaszewicz

Helmut Januschka added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Helmut Januschka . resolved

Hi @tl...@chromium.org,
thanks in advance for your time and guidance,this fixescrashing when you drag windows between monitors on Hyprland.

We were destroying the old color profile object after creating the new one,but the Wayland protocol says to destroy old ones first.


for example on hyperland it crashed with:
```
google-chrome-stable --ozone-platform=wayland
[25566:25566:1003/120242.562772:ERROR:ui/ozone/platform/wayland/host/wayland_wp_image_description.cc:219] Incomplete image description info from compositor.
[25566:25566:1003/120242.562831:ERROR:ui/ozone/platform/wayland/host/wayland_wp_image_description.cc:219] Incomplete image description info from compositor.
[25566:25566:1003/120243.276944:ERROR:ui/ozone/platform/wayland/host/wayland_wp_image_description.cc:219] Incomplete image description info from compositor.
[25566:25566:1003/120244.619696:ERROR:ui/events/platform/wayland/wayland_event_watcher.cc:47] libwayland: wl_display#1: error 0: invalid object 63

[1003/120244.631334:ERROR:third_party/crashpad/crashpad/snapshot/elf/elf_dynamic_array_reader.h:64] tag not found
[1003/120244.631782:ERROR:third_party/crashpad/crashpad/snapshot/elf/elf_dynamic_array_reader.h:64] tag not found
Trace/breakpoint trap (core dumped) google-chrome-stable --ozone-platform=wayland
```


they fixed it on their side: https://github.com/hyprwm/Hyprland/pull/11877
still think its worth, fixing it on our end in the first place!

let me know if you want me to address anything.

Open in Gerrit

Related details

Attention is currently required from:
  • Tom Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I89a914e5d99c63c3d15584cb0f3ffbbf5b0f981b
Gerrit-Change-Number: 7003036
Gerrit-PatchSet: 3
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Sat, 04 Oct 2025 19:34:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Anderson (Gerrit)

unread,
Oct 6, 2025, 11:28:31 AM (24 hours ago) Oct 6
to Helmut Januschka, Tom Lukaszewicz, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Helmut Januschka and Tom Lukaszewicz

Thomas Anderson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
  • Tom Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I89a914e5d99c63c3d15584cb0f3ffbbf5b0f981b
Gerrit-Change-Number: 7003036
Gerrit-PatchSet: 3
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-CC: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Mon, 06 Oct 2025 15:28:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Tom Lukaszewicz (Gerrit)

unread,
Oct 6, 2025, 1:16:00 PM (22 hours ago) Oct 6
to Helmut Januschka, Thomas Anderson, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Helmut Januschka

Tom Lukaszewicz voted and added 1 comment

Votes added by Tom Lukaszewicz

Code-Review+1

1 comment

Patchset-level comments
Tom Lukaszewicz . resolved

Thanks for the detailed context

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I89a914e5d99c63c3d15584cb0f3ffbbf5b0f981b
Gerrit-Change-Number: 7003036
Gerrit-PatchSet: 3
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-CC: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Comment-Date: Mon, 06 Oct 2025 17:14:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Helmut Januschka (Gerrit)

unread,
Oct 6, 2025, 1:39:06 PM (22 hours ago) Oct 6
to Helmut Januschka, Tom Lukaszewicz, Thomas Anderson, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Helmut Januschka voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I89a914e5d99c63c3d15584cb0f3ffbbf5b0f981b
Gerrit-Change-Number: 7003036
Gerrit-PatchSet: 3
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-CC: Max Ihlenfeldt <m...@igalia.com>
Gerrit-Comment-Date: Mon, 06 Oct 2025 17:38:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Oct 6, 2025, 2:49:16 PM (21 hours ago) Oct 6
to Helmut Januschka, Tom Lukaszewicz, Thomas Anderson, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[Wayland] Fix crash when moving windows between monitors with color management

Chrome crashes when moving windows between monitors on Wayland
compositors that support the wp_color_management_v1 protocol.
Bug: 449370049
Change-Id: I89a914e5d99c63c3d15584cb0f3ffbbf5b0f981b
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Reviewed-by: Tom Lukaszewicz <tl...@chromium.org>
Commit-Queue: Helmut Januschka <hel...@januschka.com>
Cr-Commit-Position: refs/heads/main@{#1525748}
Files:
  • M ui/ozone/platform/wayland/host/wayland_wp_color_management_surface.cc
Change size: XS
Delta: 1 file changed, 8 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Tom Lukaszewicz, +1 by Thomas Anderson
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I89a914e5d99c63c3d15584cb0f3ffbbf5b0f981b
Gerrit-Change-Number: 7003036
Gerrit-PatchSet: 4
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages