Migrate last base::Contains() to .contains() [chromium/src : main]

0 views
Skip to first unread message

Nico Weber (Gerrit)

unread,
Jan 12, 2026, 8:55:47 PMJan 12
to Victor Vianna, Nico Weber, Victor Tan, Andrew Rayskiy, Simon Hangl, Mike Taylor, Zijie He, Robert Kroeger, David Worsham, Kevin Babbitt, Sadrul Chowdhury, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Rijubrata Bhaumik, James Su, devtools...@chromium.org, dmurph+wat...@chromium.org, halliwe...@chromium.org, sky+...@chromium.org, dmurph+watchin...@chromium.org, rmcelra...@chromium.org, vaapi-...@chromium.org, media-cro...@chromium.org, chromeos-gfx-...@google.com, ios-revie...@chromium.org, marq+...@chromium.org, emi...@google.com, spang...@chromium.org, ozone-...@chromium.org, fuzzin...@chromium.org, fuchsia...@chromium.org, wfh+...@chromium.org, chromotin...@chromium.org, zelin+watch-we...@chromium.org, roblia...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, dibyapal+wa...@chromium.org, network-ser...@chromium.org, dmurph+watc...@chromium.org, lucasrada...@google.com, jessemcke...@google.com, kuragin+web-ap...@chromium.org, loyso...@chromium.org, grt+...@chromium.org, dfried...@chromium.org, performance-m...@chromium.org, nikhilcn+wat...@google.com, estali...@chromium.org, jiajunz+wat...@google.com, hansberry+wa...@chromium.org, chadduffin+wa...@chromium.org, mac-r...@chromium.org, khorimoto+wa...@chromium.org, jonmann+watc...@chromium.org, jackshira+wat...@google.com, jackshira+wa...@google.com, hsuregan+wat...@chromium.org, ios-r...@chromium.org, chromium-a...@chromium.org, joeantonetti+wa...@google.com, ajayramamurthy+w...@google.com, cbe-cep-eng...@google.com, extension...@chromium.org, tmartino+tran...@chromium.org, oshima...@chromium.org, hansberry+wat...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, cambickel...@google.com, cc-...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, cros-print...@google.com, dcheng+c...@chromium.org, derinel+wat...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, iclella...@chromium.org, jdonnel...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kyungjunle...@google.com, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelchec...@google.com, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, shuche...@chromium.org, storage...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webapks-...@chromium.org, webauthn...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, zackha...@chromium.org
Attention needed from Victor Vianna

Nico Weber voted and added 2 comments

Votes added by Nico Weber

Code-Review+1
Commit-Queue+2
Owners-Override+1

2 comments

Patchset-level comments
File-level comment, Patchset 19 (Latest):
Nico Weber . resolved

thanks!

File chrome/updater/test/integration_tests_win.cc
Line 2005, Patchset 19 (Latest): !base::win::GetWindowTextString(hwnd).contains(
Nico Weber . resolved

A negated contains with a garden path accessor for the first arg / lhs kinda reads better when calling a free-standing Contains() function 😅

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I313e9d70cfd283ea19c02cfca1dafec97318207e
Gerrit-Change-Number: 7414280
Gerrit-PatchSet: 19
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Mike Taylor <mike...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Victor Tan <vict...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Tue, 13 Jan 2026 01:55:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Victor Vianna (Gerrit)

unread,
Jan 12, 2026, 9:20:09 PMJan 12
to Nico Weber, Victor Tan, Andrew Rayskiy, Simon Hangl, Mike Taylor, Zijie He, Robert Kroeger, David Worsham, Kevin Babbitt, Sadrul Chowdhury, AyeAye, Chromium LUCI CQ, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Rijubrata Bhaumik, James Su, devtools...@chromium.org, dmurph+wat...@chromium.org, halliwe...@chromium.org, sky+...@chromium.org, dmurph+watchin...@chromium.org, rmcelra...@chromium.org, vaapi-...@chromium.org, media-cro...@chromium.org, chromeos-gfx-...@google.com, ios-revie...@chromium.org, marq+...@chromium.org, emi...@google.com, spang...@chromium.org, ozone-...@chromium.org, fuzzin...@chromium.org, fuchsia...@chromium.org, wfh+...@chromium.org, chromotin...@chromium.org, zelin+watch-we...@chromium.org, roblia...@chromium.org, mgiuca...@chromium.org, philli...@chromium.org, webap...@microsoft.com, dibyapal+wa...@chromium.org, network-ser...@chromium.org, dmurph+watc...@chromium.org, lucasrada...@google.com, jessemcke...@google.com, kuragin+web-ap...@chromium.org, loyso...@chromium.org, grt+...@chromium.org, dfried...@chromium.org, performance-m...@chromium.org, nikhilcn+wat...@google.com, estali...@chromium.org, jiajunz+wat...@google.com, hansberry+wa...@chromium.org, chadduffin+wa...@chromium.org, mac-r...@chromium.org, khorimoto+wa...@chromium.org, jonmann+watc...@chromium.org, jackshira+wat...@google.com, jackshira+wa...@google.com, hsuregan+wat...@chromium.org, ios-r...@chromium.org, chromium-a...@chromium.org, joeantonetti+wa...@google.com, ajayramamurthy+w...@google.com, cbe-cep-eng...@google.com, extension...@chromium.org, tmartino+tran...@chromium.org, oshima...@chromium.org, hansberry+wat...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, cambickel...@google.com, cc-...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, cros-print...@google.com, dcheng+c...@chromium.org, derinel+wat...@google.com, druber...@chromium.org, dtraino...@chromium.org, dtseng...@chromium.org, eme-r...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, iclella...@chromium.org, jdonnel...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kyungjunle...@google.com, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, michaelchec...@google.com, nator...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, nona+...@chromium.org, nwoked...@chromium.org, odejesu...@chromium.org, omnibox-...@chromium.org, print-rev...@chromium.org, rayanka...@chromium.org, shuche...@chromium.org, storage...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webapks-...@chromium.org, webauthn...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yongshun+...@google.com, yuzo+...@chromium.org, zackha...@chromium.org

Victor Vianna submitted the change

Change information

Commit message:
Migrate last base::Contains() to .contains()

This unblocks landing crrev.com/c/7415207.

Also does one logic simplification in
media/gpu/v4l2/legacy/v4l2_video_decoder_backend_stateful.cc.
Bug: 470391351
Change-Id: I313e9d70cfd283ea19c02cfca1dafec97318207e
Commit-Queue: Nico Weber <tha...@chromium.org>
Auto-Submit: Victor Vianna <victor...@google.com>
Owners-Override: Nico Weber <tha...@chromium.org>
Commit-Queue: Victor Vianna <victor...@google.com>
Reviewed-by: Nico Weber <tha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1568196}
Files:
  • M android_webview/browser/aw_content_browser_client.cc
  • M android_webview/browser/aw_permission_manager.cc
  • M android_webview/browser/aw_settings.cc
  • M android_webview/browser/icon_helper.cc
  • M android_webview/browser/lifecycle/aw_contents_lifecycle_notifier.cc
  • M android_webview/browser/metrics/visibility_metrics_logger.cc
  • M android_webview/nonembedded/component_updater/aw_component_update_service.cc
  • M android_webview/nonembedded/component_updater/aw_component_update_service_test.cc
  • M android_webview/renderer/aw_render_view_ext.cc
  • M android_webview/test/browser/embedded_component_loader_test_helper.cc
  • M base/observer_list_threadsafe.h
  • M base/test/test_file_util.cc
  • M base/win/map.h
  • M base/win/variant_conversions_unittest.cc
  • M cc/raster/task_graph_work_queue.h
  • M cc/tiles/checker_image_tracker.h
  • M chrome/browser/accessibility/live_caption/live_caption_unavailability_notifier.cc
  • M chrome/browser/android/metrics/ukm_utils_for_test.cc
  • M chrome/browser/android/persisted_tab_data/persisted_tab_data_config_android.cc
  • M chrome/browser/android/vr/arcore_device/fake_arcore.cc
  • M chrome/browser/android/webapk/webapk_sync_bridge_unittest.cc
  • M chrome/browser/apps/app_shim/app_shim_manager_mac.cc
  • M chrome/browser/ash/printing/automatic_usb_printer_configurer.h
  • M chrome/browser/ash/printing/cups_print_job_manager_utils.cc
  • M chrome/browser/autofill/android/autofill_ai_save_update_entity_prompt_controller.cc
  • M chrome/browser/autofill/form_structure_browsertest.cc
  • M chrome/browser/complex_tasks/task_tab_helper.h
  • M chrome/browser/download/android/download_manager_service.cc
  • M chrome/browser/enterprise/connectors/device_trust/key_management/core/mac/secure_enclave_signing_key.cc
  • M chrome/browser/enterprise/platform_auth/platform_auth_provider_manager.cc
  • M chrome/browser/extensions/api/printing/printing_api_handler.cc
  • M chrome/browser/extensions/extension_management.cc
  • M chrome/browser/media/webrtc/thumbnail_capturer_mac.mm
  • M chrome/browser/printing/web_api/in_progress_jobs_storage_chromeos.cc
  • M chrome/browser/profiles/profile_shortcut_manager_win.cc
  • M chrome/browser/spellchecker/spellcheck_service.cc
  • M chrome/browser/ssl/https_only_mode_tab_helper.h
  • M chrome/browser/supervised_user/supervised_user_navigation_observer.cc
  • M chrome/browser/thumbnail/cc/thumbnail_cache.cc
  • M chrome/browser/ui/extensions/controlled_home_dialog_controller_unittest.cc
  • M chrome/browser/ui/extensions/settings_overridden_params_providers_browsertest.cc
  • M chrome/browser/ui/views/tabs/vertical/tab_collection_animating_layout_manager.cc
  • M chrome/browser/web_applications/commands/fetch_manifest_and_install_command_unittest.cc
  • M chrome/browser/web_applications/test/os_integration_test_override_impl.cc
  • M chrome/browser/webauthn/authenticator_request_dialog_model_unittest.cc
  • M chrome/installer/util/delete_old_versions.cc
  • M chrome/test/base/chromeos/crosier/chromeos_integration_arc_mixin.cc
  • M chrome/updater/test/integration_tests_win.cc
  • M chromecast/base/device_capabilities_impl.cc
  • M chromecast/base/metrics/cast_metrics_helper.cc
  • M chromecast/browser/bluetooth/cast_bluetooth_chooser.cc
  • M chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc
  • M chromecast/crash/build_info.cc
  • M chromecast/device/bluetooth/le/gatt_client_manager_impl.cc
  • M chromecast/device/bluetooth/le/remote_characteristic_impl.cc
  • M chromecast/external_mojo/public/cpp/external_mojo_broker.cc
  • M chromecast/media/audio/cast_audio_mixer.cc
  • M chromecast/media/cma/backend/volume_control.cc
  • M chromecast/renderer/feature_manager.cc
  • M chromeos/ash/components/kcer/kcer_nss/kcer_nss_fuzzer.cc
  • M chromeos/ash/components/kcer/token_results_merger.h
  • M chromeos/ash/services/secure_channel/connection_attempt_base.h
  • M chromeos/ash/services/secure_channel/fake_connection_attempt.h
  • M chromeos/ash/services/secure_channel/public/cpp/client/fake_secure_channel_client.h
  • M components/autofill/ios/browser/autofill_across_iframes_unittest.mm
  • M components/background_sync/background_sync_controller_impl.cc
  • M components/blocked_content/android/popup_blocked_infobar_delegate_unittest.cc
  • M components/cdm/renderer/key_system_support_update.cc
  • M components/crash/content/browser/child_exit_observer_android.cc
  • M components/js_injection/renderer/js_binding.cc
  • M components/omnibox/browser/autocomplete_result_android.cc
  • M components/page_info/android/page_info_controller_android.cc
  • M components/password_manager/core/browser/password_manager.cc
  • M components/performance_manager/owned_objects.h
  • M components/performance_manager/test_support/voting.h
  • M components/remote_cocoa/app_shim/immersive_mode_controller_cocoa.mm
  • M components/rlz/rlz_tracker_unittest.cc
  • M components/safe_browsing/android/remote_database_manager_unittest.cc
  • M components/safe_browsing/android/safe_browsing_api_handler_bridge.cc
  • M components/services/app_service/public/cpp/app_registry_cache.h
  • M components/session_proto_db/session_proto_db.h
  • M components/storage_monitor/volume_mount_watcher_win.cc
  • M components/ukm/ios/ukm_url_recorder.mm
  • M components/user_education/common/feature_promo/feature_promo_registry.h
  • M components/viz/service/frame_sinks/external_begin_frame_source_mac.cc
  • M components/viz/service/frame_sinks/fling_scheduler_android_unittest.cc
  • M components/viz/service/frame_sinks/frame_sink_manager_impl.cc
  • M components/viz/test/test_gles2_interface.h
  • M components/webauthn/core/browser/remote_validation.cc
  • M content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm
  • M content/app_shim_remote_cocoa/web_contents_view_cocoa.mm
  • M content/browser/accessibility/browser_accessibility_android.cc
  • M content/browser/accessibility/browser_accessibility_manager_android.cc
  • M content/browser/android/java/gin_java_bound_object.cc
  • M content/browser/file_system_access/file_path_watcher/file_path_watcher_fsevents.cc
  • M content/browser/find_request_manager.cc
  • M content/browser/locks/lock_manager.h
  • M content/browser/renderer_host/media/media_devices_manager_unittest.cc
  • M content/browser/renderer_host/render_widget_host_view_android.cc
  • M content/renderer/java/gin_java_bridge_dispatcher.cc
  • M content/renderer/java/gin_java_bridge_object.cc
  • M content/shell/browser/shell_platform_delegate_android.cc
  • M content/shell/browser/shell_platform_delegate_aura.cc
  • M content/shell/browser/shell_platform_delegate_mac.mm
  • M content/web_test/browser/web_test_shell_platform_delegate_mac.mm
  • M device/bluetooth/bluetooth_adapter_win.cc
  • M device/bluetooth/bluetooth_device_android.cc
  • M device/bluetooth/bluetooth_device_win_unittest.cc
  • M device/bluetooth/bluetooth_gatt_discoverer_winrt.cc
  • M device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc
  • M device/bluetooth/bluetooth_remote_gatt_service_android.cc
  • M device/bluetooth/cast/bluetooth_adapter_cast.cc
  • M device/bluetooth/floss/exported_callback_manager.h
  • M device/bluetooth/floss/floss_dbus_client.h
  • M device/fido/mac/credential_store.mm
  • M device/fido/mac/icloud_keychain.mm
  • M device/fido/mac/icloud_keychain_unittest.mm
  • M device/fido/win/authenticator.cc
  • M device/gamepad/gamepad_platform_data_fetcher_android.cc
  • M device/gamepad/gamepad_platform_data_fetcher_mac.mm
  • M device/gamepad/raw_input_data_fetcher_win.cc
  • M device/vr/android/arcore/arcore_anchor_manager.cc
  • M device/vr/android/arcore/arcore_gl.cc
  • M device/vr/android/arcore/arcore_impl.cc
  • M device/vr/android/arcore/arcore_plane_manager.cc
  • M device/vr/openxr/openxr_api_wrapper.cc
  • M device/vr/openxr/openxr_extension_helper.cc
  • M device/vr/openxr/openxr_spatial_anchor_manager.cc
  • M device/vr/openxr/test/openxr_test_helper.cc
  • M extensions/browser/api/declarative/deduping_factory.h
  • M extensions/browser/scripting_utils.h
  • M extensions/common/command_unittest.cc
  • M fuchsia_web/common/test/test_debug_listener.cc
  • M fuchsia_web/runners/cast/test/fake_cast_agent.cc
  • M fuchsia_web/webengine/browser/client_hints_browsertest.cc
  • M fuchsia_web/webengine/common/cors_exempt_headers.cc
  • M fuchsia_web/webengine/context_provider_impl_unittest.cc
  • M fuchsia_web/webengine/web_engine_debug_integration_test.cc
  • M fuchsia_web/webengine/web_engine_integration_test.cc
  • M gpu/command_buffer/service/shared_image/iosurface_image_backing_factory.mm
  • M gpu/command_buffer/tests/gl_ext_multisample_compatibility_unittest.cc
  • M gpu/command_buffer/tests/lpm/gl_lpm_fuzzer.cc
  • M gpu/ipc/common/gpu_surface_tracker.cc
  • M ios/chrome/browser/autofill/model/form_structure_browsertest.mm
  • M ios/chrome/browser/location_bar/ui_bundled/location_bar_view_controller.mm
  • M ios/chrome/browser/popup_menu/overflow_menu/coordinator/overflow_menu_orderer.mm
  • M ios/chrome/tools/strings/grit_header_parsing.cc
  • M media/base/android/media_codec_util.cc
  • M media/capture/video/win/video_capture_device_factory_win.cc
  • M media/device_monitors/device_monitor_mac.mm
  • M media/gpu/chromeos/platform_video_frame_utils.cc
  • M media/gpu/v4l2/legacy/v4l2_video_decoder_backend_stateful.cc
  • M media/gpu/v4l2/test/h265_decoder.cc
  • M media/gpu/v4l2/test/v4l2_ioctl_shim.cc
  • M media/gpu/v4l2/v4l2_queue.cc
  • M media/gpu/v4l2/v4l2_stateful_video_decoder.cc
  • M media/gpu/v4l2/v4l2_utils.cc
  • M media/gpu/vaapi/vaapi_unittest.cc
  • M media/gpu/vaapi/vaapi_video_decoder_delegate.cc
  • M mojo/public/cpp/bindings/remote_set.h
  • M net/dns/https_record_rdata_fuzzer.cc
  • M net/http/http_stream_pool_attempt.cc
  • M printing/backend/cups_ipp_helper.cc
  • M remoting/host/audio_capturer_mac.cc
  • M remoting/host/touch_injector_win_unittest.cc
  • M sandbox/policy/win/sandbox_win.cc
  • M sandbox/win/src/signed_policy.cc
  • M services/device/hid/hid_connection_win.cc
  • M services/device/serial/serial_device_enumerator_win.cc
  • M services/device/usb/usb_device_handle_impl.cc
  • M services/device/usb/usb_device_handle_win.cc
  • M services/device/usb/usb_service_android.cc
  • M services/device/usb/usb_service_impl.cc
  • M services/device/usb/usb_service_win.cc
  • M services/network/shared_dictionary/shared_dictionary_storage.h
  • M sql/database.cc
  • M tools/mac/power/power_sampler/resource_coalition_sampler_unittest.cc
  • M tools/mac/power/power_sampler/sampling_controller.cc
  • M ui/accessibility/platform/ax_fragment_root_win.cc
  • M ui/accessibility/platform/browser_accessibility_manager_win.cc
  • M ui/aura/native_window_occlusion_tracker_win.cc
  • M ui/aura/window_tree_host_unittest.cc
  • M ui/base/clipboard/clipboard_android.cc
  • M ui/base/dragdrop/os_exchange_data_win_unittest.cc
  • M ui/base/interaction/element_tracker_mac.mm
  • M ui/base/interaction/interactive_test_internal.h
  • M ui/ozone/platform/flatland/flatland_surface_factory.cc
  • M ui/views/event_monitor_remote_cocoa.mm
  • M url/origin_abstract_tests.h
Change size: L
Delta: 189 files changed, 399 insertions(+), 531 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nico Weber
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I313e9d70cfd283ea19c02cfca1dafec97318207e
Gerrit-Change-Number: 7414280
Gerrit-PatchSet: 20
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages