Ozone/X11: Reuse the main GL display for native pixmap import [chromium/src : main]
0 views
Skip to first unread message
Dianda Lin (Gerrit)
Jul 19, 2026, 8:40:44 PM (3 days ago) Jul 19
to Thomas Anderson, Geoff Lang, Shahbaz Youssefi, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Geoff Lang and Thomas Anderson
Dianda Lin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Dianda Lin . resolved
This CL is the Chrome-side alternative to the ANGLE-side fix in crrev.com/c/8076822. Per geofflang@'s feedback there — prefer having Chrome use a single display rather than teaching the ANGLE GL backend to support multiple displays — it fixes the bug in ui/ozone by reusing the main GLDisplayEGL. If this lands, I will abandon 8076822.
I'm new to Chromium contribution and don't yet have CQ/try-job access, so I can't trigger trybots myself. Could a committer kick a CQ dry-run — in particular gpu-fyi-try-linux-amd-rel (the AMD RX 5500 XT config from the bug) — to confirm this fixes crbug.com/533452084? Separately, if possible I'd appreciate being granted try-job access so I can run bots myself going forward. Thanks!
Related details
Attention is currently required from:
- Geoff Lang
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Jul 20, 2026, 4:30:57 PM (3 days ago) Jul 20
to Dianda Lin, Geoff Lang, Shahbaz Youssefi, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Dianda Lin and Geoff Lang
Thomas Anderson voted and added 2 comments![]( "Open in Gerrit")
Votes added by Thomas Anderson
| Code-Review | +1 |
2 comments
Patchset-level comments
Thomas Anderson . resolved
lgtm
Commit Message
Line 8, Patchset 2 (Latest):
Thomas Anderson . unresolved
Please wrap description to 72 columns. You can click the edit button, then the format button to do this automatically
Related details
Attention is currently required from:
- Dianda Lin
- Geoff Lang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dianda Lin (Gerrit)
Jul 20, 2026, 4:52:46 PM (3 days ago) Jul 20
to Thomas Anderson, Geoff Lang, Shahbaz Youssefi, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Geoff Lang
Dianda Lin added 1 comment![]( "Open in Gerrit")
Commit Message
Please wrap description to 72 columns. You can click the edit button, then the format button to do this automatically
Attention is currently required from:
- Geoff Lang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dianda Lin (Gerrit)
Jul 22, 2026, 3:11:31 PM (15 hours ago) Jul 22
to Thomas Anderson, Geoff Lang, Shahbaz Youssefi, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Geoff Lang
Dianda Lin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Dianda Lin . resolved
@Geoff Lang, could you take a look when you have a moment?
Related details
Attention is currently required from:
- Geoff Lang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Geoff Lang (Gerrit)
Jul 22, 2026, 4:37:23 PM (14 hours ago) Jul 22
to Dianda Lin, Thomas Anderson, Shahbaz Youssefi, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Dianda Lin
Geoff Lang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Geoff Lang
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Dianda Lin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shahbaz Youssefi (Gerrit)
Jul 22, 2026, 4:40:38 PM (14 hours ago) Jul 22
to Dianda Lin, Geoff Lang, Thomas Anderson, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Dianda Lin
Shahbaz Youssefi voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Dianda Lin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 22, 2026, 7:02:35 PM (11 hours ago) Jul 22
to Dianda Lin, Shahbaz Youssefi, Geoff Lang, Thomas Anderson, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Ozone/X11: Reuse the main GL display for native pixmap import
On the ANGLE GLX backend, importing a hardware-decoded video frame
corrupted subsequent GL work, failing webcodecs_tests on Linux ANGLE GL
bots (e.g. AMD RX 5500 XT) with frame corruption and GPU-process
crashes.
NativePixmapEGLX11Binding created its own EGLDisplay via a visual-less
eglGetDisplay(). Once ANGLE's display cache started keying on
EGL_X11_VISUAL_ID_ANGLE, that no longer matched the compositor's
visual-specific display, so a second DisplayGLX was created whose init
left a probe context current on the thread and never restored the
compositor's; ANGLE then elided the rebind because it tracks the current
context per-display.
Reuse the process-wide GLDisplayEGL (like the dma-buf sibling
NativePixmapEGLBinding) so only one display exists. It is already
initialized and owned by GLDisplayManagerEGL, so the redundant
eglInitialize() is dropped(the binding must not init/terminate a display
it does not own).
Bug: 533452084
Change-Id: Ib18a114f2a9feea02ca7932f33fd6a20bc41798e
Commit-Queue: Shahbaz Youssefi <syou...@chromium.org>
Reviewed-by: Geoff Lang <geof...@chromium.org>
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1666680}
Files:
- M AUTHORS
- M ui/ozone/platform/x11/native_pixmap_egl_x11_binding.cc
Change size: S
Delta: 2 files changed, 4 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Geoff Lang, +1 by Thomas Anderson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages