Use base::Unretained instead of weak ptr in AfterSandboxEntry(). [chromium/src : master]
Joone Hur (Gerrit)
I'm trying to run mus_demo with this CL(https://chromium-review.googlesource.com/c/chromium/src/+/898409), but there is a crash. This CL could fix the problem.
Please take a look at the CL.
To view, visit change 902938. To unsubscribe, or for help writing mail filters, visit settings.
Robert Kroeger (Gerrit)
I don't think that this is necessary. Both InitializeGPU and AfterSandboxEntry should be invoked on the same thread. Under which circumstances are they invoked on different threads?
Joone Hur (Gerrit)
Joone Hur uploaded patch set #3 to this change.
Use base::Unretained instead of weak ptr in AfterSandboxEntry().
This CL fixes the following problem:
FATAL:weak_ptr.cc(26)] Check failed: sequence_checker_.CalledOnValidSequence().
WeakPtrs must be checked on the same sequenced thread.
BUG=733450
TEST=mash --service=mus_demo --mus-hosting-viz --mus
Change-Id: Icb77ffef5f16905dbb6789ccce972de1cea64875
---
M ui/ozone/platform/drm/ozone_platform_gbm.cc
1 file changed, 1 insertion(+), 1 deletion(-)
To view, visit change 902938. To unsubscribe, or for help writing mail filters, visit settings.
Joone Hur (Gerrit)
Patch Set 2:
I don't think that this is necessary. Both InitializeGPU and AfterSandboxEntry should be invoked on the same thread. Under which circumstances are they invoked on different threads?
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/898409.
First, build mus_demo and mash:all with "--args=use_ozone=true ozone_platform_gbm=true
use_intel_minigbm=true internal_window_mode=true"
$ export EGL_PLATFORM=surfaceless
$ out/Release/mash --service=mus_demo --mus-hosting-viz --mus
Without this CL, mus_demo crashes.
Robert Kroeger (Gerrit)
Patch Set 3:
Patch Set 2:
I don't think that this is necessary. Both InitializeGPU and AfterSandboxEntry should be invoked on the same thread. Under which circumstances are they invoked on different threads?
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/898409.
First, build mus_demo and mash:all with "--args=use_ozone=true ozone_platform_gbm=true
use_intel_minigbm=true internal_window_mode=true"
$ export EGL_PLATFORM=surfaceless
$ out/Release/mash --service=mus_demo --mus-hosting-viz --musWithout this CL, mus_demo crashes.
Sure. But that's a bug in how mus_demo is threaded right?