Add new flag to allow using SwANGLE as WebGL fallback [chromium/src : main]
Alexis Hétu (Gerrit)
Attention is currently required from: Jonah Ryan-Davis, Kenneth Russell, Alexis Hetu.
Alexis Hétu would like Jonah Ryan-Davis and Kenneth Russell to review this change authored by Alexis Hetu.
Add new flag to allow using SwANGLE as WebGL fallback
Currently, Chrome uses legacy SwiftShader GL as the WebGL fallback when
a hardware GPU isn't usable for the purpuse of rendering WebGL content.
As we're in the process of changing legacy SwiftShader GL to SwANGLE,
this CL adds a new flag which allows using SwANGLE for WebGL only.
To clarify, current switches with legacy SwiftShader GL:
Software GL: --use-gl=swiftshader
Software WebGL only: --use-gl=swiftshader-webgl
With SwANGLE, the new switches will be:
Software GL: --use-gl=angle --use-angle=swiftshader
Software WebGL only: --use-gl=angle --use-angle=swiftshader-webgl
Bug: chromium:1060139
Change-Id: I8d0382ac3a12c1578dfc0e62fc1949a0a9c66bd7
---
M gpu/command_buffer/service/feature_info.cc
M gpu/config/gpu_util.cc
M gpu/ipc/service/gpu_init.cc
M ui/gl/gl_surface_egl.cc
M ui/gl/gl_switches.cc
M ui/gl/gl_switches.h
6 files changed, 15 insertions(+), 3 deletions(-)
To view, visit change 2845229. To unsubscribe, or for help writing mail filters, visit settings.
Alexis Hétu (Gerrit)
Attention is currently required from: Jonah Ryan-Davis, Kenneth Russell, Alexis Hetu.
Kenneth Russell (Gerrit)
Attention is currently required from: Jonah Ryan-Davis, Alexis Hetu.
Patch set 1:Code-Review +1
1 comment:
Patchset:
lgtm, but:
Could you please add some documentation under docs/gpu (just a small Markdown file) describing the current situation of what the SwiftShader defaults are, and how to test various configurations?
It's basically impossible for folks like myself to keep track of the current state of things, and we could update such documentation in concert with CLs like this one.
Thanks.
To view, visit change 2845229. To unsubscribe, or for help writing mail filters, visit settings.
Alexis Hétu (Gerrit)
Attention is currently required from: Jonah Ryan-Davis, Alexis Hetu.
1 comment:
Patchset:
lgtm, but: […]
Ok, will do! I'll add a new .md file for SwiftShader / SwANGLE doc, unless you'd prefer that this be added as a subsection of an existing doc.
To view, visit change 2845229. To unsubscribe, or for help writing mail filters, visit settings.
Alexis Hétu (Gerrit)
Patchset:
Ok, will do! I'll add a new . […]
(I'll add it to this CL first thing tomorrow)
To view, visit change 2845229. To unsubscribe, or for help writing mail filters, visit settings.
Kenneth Russell (Gerrit)
Attention is currently required from: Alexis Hétu, Jonah Ryan-Davis, Alexis Hetu.
1 comment:
Patchset:
(I'll add it to this CL first thing tomorrow)
A new .md file about SwiftShader would be great - thanks.
To view, visit change 2845229. To unsubscribe, or for help writing mail filters, visit settings.
Jonah Ryan-Davis (Gerrit)
Attention is currently required from: Alexis Hetu.
File gpu/config/gpu_util.cc:
Patch Set #1, Line 501:
else if (use_angle == gl::kANGLEImplementationSwiftShaderForWebGLName)This is all pretty hacky. I guess it makes sense for this CL to make as little change as possible but we should definitely clean this up.
To view, visit change 2845229. To unsubscribe, or for help writing mail filters, visit settings.
Alexis Hétu (Gerrit)
Attention is currently required from: Alexis Hetu.
Patch set 2:Commit-Queue +1
2 comments:
Patchset:
A new .md file about SwiftShader would be great - thanks.
Ok, I added a new .md file. Sorry it took so long, I got sidetracked by other issues.
File gpu/config/gpu_util.cc:
Patch Set #1, Line 501:
else if (use_angle == gl::kANGLEImplementationSwiftShaderForWebGLName)
This is all pretty hacky. […]
Hopefully, this will naturally end up looking cleaner once the non SwANGLE flags are removed.
To view, visit change 2845229. To unsubscribe, or for help writing mail filters, visit settings.
Kenneth Russell (Gerrit)
Attention is currently required from: Alexis Hetu.
Patch set 2:Code-Review +1
2 comments:
Patchset:
Still lgtm with one doc suggestion
File docs/gpu/swiftshader.md:
Patch Set #2, Line 3:
SwiftShader is an open-source high-performance implementation of the Vulkan and OpenGL ES graphics APIs which runs purely on the CPU. Thus no graphics processor (GPU) is required for advanced (3D) graphics. (See http://go/swiftshader)Suggest not referencing go links in public documentation.
To view, visit change 2845229. To unsubscribe, or for help writing mail filters, visit settings.
Alexis Hétu (Gerrit)
Attention is currently required from: Alexis Hetu.
1 comment:
File docs/gpu/swiftshader.md:
Patch Set #2, Line 3:
SwiftShader is an open-source high-performance implementation of the Vulkan and OpenGL ES graphics APIs which runs purely on the CPU. Thus no graphics processor (GPU) is required for advanced (3D) graphics. (See http://go/swiftshader)Suggest not referencing go links in public documentation.
Ok, I'll remove it. Thanks.
To view, visit change 2845229. To unsubscribe, or for help writing mail filters, visit settings.
Alexis Hétu (Gerrit)
Attention is currently required from: Alexis Hetu.
Patch set 4:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
Add new flag to allow using SwANGLE as WebGL fallback
Currently, Chrome uses legacy SwiftShader GL as the WebGL fallback when
a hardware GPU isn't usable for the purpuse of rendering WebGL content.
As we're in the process of changing legacy SwiftShader GL to SwANGLE,
this CL adds a new flag which allows using SwANGLE for WebGL only.
To clarify, current switches with legacy SwiftShader GL:
Software GL: --use-gl=swiftshader
Software WebGL only: --use-gl=swiftshader-webgl
With SwANGLE, the new switches will be:
Software GL: --use-gl=angle --use-angle=swiftshader
Software WebGL only: --use-gl=angle --use-angle=swiftshader-webgl
Bug: chromium:1060139
Change-Id: I8d0382ac3a12c1578dfc0e62fc1949a0a9c66bd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2845229
Commit-Queue: Alexis Hétu <su...@chromium.org>
Reviewed-by: Kenneth Russell <k...@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jon...@google.com>
Cr-Commit-Position: refs/heads/master@{#876794}
---
A docs/gpu/swiftshader.md
M gpu/command_buffer/service/feature_info.cc
M gpu/config/gpu_util.cc
M gpu/ipc/service/gpu_init.cc
M ui/gl/gl_surface_egl.cc
M ui/gl/gl_switches.cc
M ui/gl/gl_switches.h
7 files changed, 54 insertions(+), 3 deletions(-)
To view, visit change 2845229. To unsubscribe, or for help writing mail filters, visit settings.