Ozone/Wayland: Use HDR format for surface feedback [chromium/src : main]

0 views
Skip to first unread message

Thomas Anderson (Gerrit)

unread,
Jul 13, 2026, 12:12:55 PM (10 days ago) Jul 13
to Sargun Vohra, android-bu...@system.gserviceaccount.com, Kramer Ge, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge and Sargun Vohra

Thomas Anderson voted and added 1 comment

Votes added by Thomas Anderson

Code-Review+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Thomas Anderson . resolved

lgtm. please wait for Kramer's secondary approval before submitting this change

Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
  • Sargun Vohra
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I82f0e90cc0ebe6849da45fd945592f7089dfc4f1
Gerrit-Change-Number: 8073658
Gerrit-PatchSet: 1
Gerrit-Owner: Sargun Vohra <sargun...@gmail.com>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Attention: Sargun Vohra <sargun...@gmail.com>
Gerrit-Comment-Date: Mon, 13 Jul 2026 16:12:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kramer Ge (Gerrit)

unread,
Jul 13, 2026, 1:05:59 PM (10 days ago) Jul 13
to Sargun Vohra, Chromium LUCI CQ, Thomas Anderson, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Sargun Vohra

Kramer Ge voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Sargun Vohra
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I82f0e90cc0ebe6849da45fd945592f7089dfc4f1
    Gerrit-Change-Number: 8073658
    Gerrit-PatchSet: 1
    Gerrit-Owner: Sargun Vohra <sargun...@gmail.com>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Attention: Sargun Vohra <sargun...@gmail.com>
    Gerrit-Comment-Date: Mon, 13 Jul 2026 17:05:47 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 13, 2026, 1:15:13 PM (10 days ago) Jul 13
    to Sargun Vohra, Kramer Ge, Thomas Anderson, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Ozone/Wayland: Use HDR format for surface feedback

    Compositors can override display color spaces per surface through
    preferred_changed. The resulting DisplayColorSpaces used the default
    RGBA_8888 format, bypassing the high-bit-depth format selected by
    WaylandScreen and causing banding in HDR output.

    Pass WaylandScreen's selected HDR format to the preferred surface
    image description. Apply it to all content usages when the target
    supports HDR because SDR content is also composed into that target.

    This extends https://crrev.com/c/7875994 to the per-surface color
    space path introduced by https://crrev.com/c/6868958.

    R=fang...@chromium.org, thomasa...@chromium.org
    Test: A/B tested EIZO gradients and HDR video on KDE Wayland HDR.
    Change-Id: I82f0e90cc0ebe6849da45fd945592f7089dfc4f1
    Fixed: 503402063
    Reviewed-by: Kramer Ge <fang...@chromium.org>
    Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
    Commit-Queue: Kramer Ge <fang...@chromium.org>
    Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1661192}
    Files:
    • M AUTHORS
    • M ui/ozone/platform/wayland/host/wayland_screen.cc
    • M ui/ozone/platform/wayland/host/wayland_screen.h
    • M ui/ozone/platform/wayland/host/wayland_wp_color_management_surface.cc
    • M ui/ozone/platform/wayland/host/wayland_wp_image_description.cc
    • M ui/ozone/platform/wayland/host/wayland_wp_image_description.h
    Change size: S
    Delta: 6 files changed, 27 insertions(+), 4 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kramer Ge, +1 by Thomas Anderson
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I82f0e90cc0ebe6849da45fd945592f7089dfc4f1
    Gerrit-Change-Number: 8073658
    Gerrit-PatchSet: 2
    Gerrit-Owner: Sargun Vohra <sargun...@gmail.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages