Disable suspected keyboard check for kiosk apps [chromium/src : refs/branch-heads/6533]

[Polina Bondarenko (Gerrit)]

Polina Bondarenko voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: refs/branch-heads/6533

Gerrit-Change-Id: I3df08fb9b7bc9772c8dd729bb85e1501ed9b82bf

Gerrit-Change-Number: 5729372

Gerrit-PatchSet: 2

Gerrit-Owner: Polina Bondarenko <pb...@chromium.org>

Gerrit-Reviewer: Polina Bondarenko <pb...@chromium.org>

Gerrit-CC: Ashutosh Singhal <macina...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-Comment-Date: Mon, 22 Jul 2024 12:57:47 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Polina Bondarenko (Gerrit)]

Attention needed from Ahmed Fakhry, Michael Spang and Peter McNeeley

Polina Bondarenko voted and added 1 comment

Votes added by Polina Bondarenko

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Polina Bondarenko . resolved

Hi all,

PTAL. The merge is approved to M127.

Thanks

Open in Gerrit

Related details

Attention is currently required from:

• Ahmed Fakhry
• Michael Spang
• Peter McNeeley

Submit Requirements:

• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: refs/branch-heads/6533

Gerrit-Change-Id: I3df08fb9b7bc9772c8dd729bb85e1501ed9b82bf

Gerrit-Change-Number: 5729372

Gerrit-PatchSet: 3

Gerrit-Owner: Polina Bondarenko <pb...@chromium.org>

Gerrit-Reviewer: Ahmed Fakhry <afa...@chromium.org>

Gerrit-Reviewer: Michael Spang <sp...@chromium.org>

Gerrit-Reviewer: Peter McNeeley <peterm...@chromium.org>

Gerrit-Reviewer: Polina Bondarenko <pb...@chromium.org>

Gerrit-CC: Ashutosh Singhal <macina...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Michael Spang <sp...@chromium.org>

Gerrit-Attention: Ahmed Fakhry <afa...@chromium.org>

Gerrit-Attention: Peter McNeeley <peterm...@chromium.org>

Gerrit-Comment-Date: Mon, 22 Jul 2024 13:09:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Peter McNeeley (Gerrit)]

Attention needed from Ahmed Fakhry, Michael Spang and Polina Bondarenko

Peter McNeeley voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Ahmed Fakhry
• Michael Spang
• Polina Bondarenko

Submit Requirements:

• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: refs/branch-heads/6533

Gerrit-Change-Id: I3df08fb9b7bc9772c8dd729bb85e1501ed9b82bf

Gerrit-Change-Number: 5729372

Gerrit-PatchSet: 3

Gerrit-Owner: Polina Bondarenko <pb...@chromium.org>

Gerrit-Reviewer: Ahmed Fakhry <afa...@chromium.org>

Gerrit-Reviewer: Michael Spang <sp...@chromium.org>

Gerrit-Reviewer: Peter McNeeley <peterm...@chromium.org>

Gerrit-Reviewer: Polina Bondarenko <pb...@chromium.org>

Gerrit-CC: Ashutosh Singhal <macina...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Michael Spang <sp...@chromium.org>

Gerrit-Attention: Ahmed Fakhry <afa...@chromium.org>

Gerrit-Attention: Polina Bondarenko <pb...@chromium.org>

Gerrit-Comment-Date: Mon, 22 Jul 2024 13:27:57 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Ahmed Fakhry (Gerrit)]

Attention needed from Michael Spang and Polina Bondarenko

Ahmed Fakhry voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Michael Spang
• Polina Bondarenko

Submit Requirements:

• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: refs/branch-heads/6533

Gerrit-Change-Id: I3df08fb9b7bc9772c8dd729bb85e1501ed9b82bf

Gerrit-Change-Number: 5729372

Gerrit-PatchSet: 3

Gerrit-Owner: Polina Bondarenko <pb...@chromium.org>

Gerrit-Reviewer: Ahmed Fakhry <afa...@chromium.org>

Gerrit-Reviewer: Michael Spang <sp...@chromium.org>

Gerrit-Reviewer: Peter McNeeley <peterm...@chromium.org>

Gerrit-Reviewer: Polina Bondarenko <pb...@chromium.org>

Gerrit-CC: Ashutosh Singhal <macina...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Michael Spang <sp...@chromium.org>

Gerrit-Attention: Polina Bondarenko <pb...@chromium.org>

Gerrit-Comment-Date: Mon, 22 Jul 2024 16:44:01 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Michael Spang (Gerrit)]

Attention needed from Polina Bondarenko and Rob Schonberger

Michael Spang voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Polina Bondarenko
• Rob Schonberger

Submit Requirements:

• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: refs/branch-heads/6533

Gerrit-Change-Id: I3df08fb9b7bc9772c8dd729bb85e1501ed9b82bf

Gerrit-Change-Number: 5729372

Gerrit-PatchSet: 3

Gerrit-Owner: Polina Bondarenko <pb...@chromium.org>

Gerrit-Reviewer: Ahmed Fakhry <afa...@chromium.org>

Gerrit-Reviewer: Michael Spang <sp...@chromium.org>

Gerrit-Reviewer: Peter McNeeley <peterm...@chromium.org>

Gerrit-Reviewer: Polina Bondarenko <pb...@chromium.org>

Gerrit-Reviewer: Rob Schonberger <ro...@chromium.org>

Gerrit-CC: Ashutosh Singhal <macina...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Polina Bondarenko <pb...@chromium.org>

Gerrit-Attention: Rob Schonberger <ro...@chromium.org>

Gerrit-Comment-Date: Wed, 24 Jul 2024 19:02:45 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Michael Spang (Gerrit)]

Attention needed from Polina Bondarenko and Rob Schonberger

Michael Spang voted Commit-Queue+2

Commit-Queue

+2

Gerrit-Comment-Date: Wed, 24 Jul 2024 19:02:51 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Disable suspected keyboard check for kiosk apps

Enterprise customers are getting effected in their stable prod
working setups. The actual keyboards are getting flagged as
imposters. This toggles virtual keyboard when a user is
trying to provide input even though an actual keyboard is
connected to the device..

(cherry picked from commit 276cb2c04c720997ac30111fb664e6f4b55b7d1d)

Bug: b/307433336

Bug: b/354123318

Change-Id: I3df08fb9b7bc9772c8dd729bb85e1501ed9b82bf

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5682362

Reviewed-by: Peter McNeeley <peterm...@chromium.org>

Commit-Queue: Ashutosh Singhal <macina...@google.com>

Reviewed-by: Polina Bondarenko <pb...@chromium.org>

Reviewed-by: Sean O'Brien <seob...@chromium.org>

Reviewed-by: Ahmed Fakhry <afa...@chromium.org>

Reviewed-by: William Mahon <wma...@google.com>

Cr-Original-Commit-Position: refs/heads/main@{#1329744}

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5729372

Reviewed-by: Michael Spang <sp...@chromium.org>

Commit-Queue: Michael Spang <sp...@chromium.org>

Cr-Commit-Position: refs/branch-heads/6533@{#1801}

Cr-Branched-From: 7e0b87ec6b8cb5cb2969e1479fc25776e582721d-refs/heads/main@{#1313161}

Files:

• M ash/accelerators/accelerator_capslock_state_machine_unittest.cc
• M ash/accelerators/accelerator_launcher_state_machine_unittest.cc
• M ash/accelerators/accelerator_shift_disable_capslock_state_machine_unittest.cc
• M ash/accelerators/suspend_state_machine_unittest.cc
• M ash/host/ash_window_tree_host_platform_unittest.cc
• M ash/system/input_device_settings/input_device_settings_dispatcher_unittest.cc
• M ash/utility/haptics_tracking_test_input_controller.cc
• M ash/utility/haptics_tracking_test_input_controller.h
• M chrome/browser/ash/app_mode/kiosk_controller_impl.cc
• M ui/events/ozone/evdev/BUILD.gn
• M ui/events/ozone/evdev/imposter_checker_evdev.cc
• M ui/events/ozone/evdev/imposter_checker_evdev.h
• A ui/events/ozone/evdev/imposter_checker_evdev_state.cc
• A ui/events/ozone/evdev/imposter_checker_evdev_state.h
• M ui/events/ozone/evdev/input_controller_evdev.cc
• M ui/events/ozone/evdev/input_controller_evdev.h
• M ui/events/ozone/evdev/input_device_factory_evdev.cc
• M ui/events/ozone/evdev/input_device_factory_evdev.h
• M ui/events/ozone/evdev/input_device_factory_evdev_proxy.cc
• M ui/events/ozone/evdev/input_device_factory_evdev_proxy.h
• M ui/events/ozone/evdev/input_device_factory_evdev_unittest.cc
• M ui/ozone/platform/wayland/host/wayland_input_controller.cc
• M ui/ozone/public/input_controller.cc
• M ui/ozone/public/input_controller.h

Change size: M

Delta: 24 files changed, 228 insertions(+), 3 deletions(-)

Branch: refs/branch-heads/6533

Submit Requirements:

• Code-Review: +1 by Ahmed Fakhry, +1 by Michael Spang, +1 by Peter McNeeley

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: refs/branch-heads/6533

Gerrit-Change-Id: I3df08fb9b7bc9772c8dd729bb85e1501ed9b82bf

Gerrit-Change-Number: 5729372

Gerrit-PatchSet: 4

Gerrit-Owner: Polina Bondarenko <pb...@chromium.org>

Gerrit-Reviewer: Ahmed Fakhry <afa...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

[Rob Schonberger (Gerrit)]

Attention needed from Polina Bondarenko

Rob Schonberger voted and added 2 comments

Votes added by Rob Schonberger

Code-Review	+1
Commit-Queue	+1

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Rob Schonberger . resolved

Looked over the ui/events/ozone code and I suspect a factory style creation interface could make the enforcement of "singleton-ness" nicer. Not for today though.

File ui/events/ozone/evdev/imposter_checker_evdev_state.cc

Line 26, Patchset 4 (Latest):}

ImposterCheckerEvdevState::ImposterCheckerEvdevState() {
CHECK(!g_instance);
g_instance = this;
}

Rob Schonberger . unresolved

I'm coming late into this: but would a factory style interface have helped avaoid a CHECK here (and allowed multiple users without ownership?)

Open in Gerrit

Related details

Attention is currently required from:

• Polina Bondarenko

Submit Requirements:

• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: refs/branch-heads/6533

Gerrit-Change-Id: I3df08fb9b7bc9772c8dd729bb85e1501ed9b82bf

Gerrit-Change-Number: 5729372

Gerrit-PatchSet: 4

Gerrit-Owner: Polina Bondarenko <pb...@chromium.org>

Gerrit-Reviewer: Ahmed Fakhry <afa...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Michael Spang <sp...@chromium.org>

Gerrit-Reviewer: Peter McNeeley <peterm...@chromium.org>

Gerrit-Reviewer: Polina Bondarenko <pb...@chromium.org>

Gerrit-Reviewer: Rob Schonberger <ro...@chromium.org>

Gerrit-CC: Ashutosh Singhal <macina...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-Attention: Polina Bondarenko <pb...@chromium.org>

Gerrit-Comment-Date: Wed, 24 Jul 2024 22:46:54 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes