Resolve WaylandWpColorManager::Observer UAF [chromium/src : main]

0 views
Skip to first unread message

Kramer Ge (Gerrit)

unread,
Dec 8, 2025, 3:54:35 PM (14 days ago) Dec 8
to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Thomas Anderson

Kramer Ge voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Anderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ida658bf700a8686b3f87c233e627d87981454436
Gerrit-Change-Number: 7239547
Gerrit-PatchSet: 2
Gerrit-Owner: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Comment-Date: Mon, 08 Dec 2025 20:54:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Anderson (Gerrit)

unread,
Dec 8, 2025, 4:17:06 PM (14 days ago) Dec 8
to Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge

Thomas Anderson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ida658bf700a8686b3f87c233e627d87981454436
    Gerrit-Change-Number: 7239547
    Gerrit-PatchSet: 2
    Gerrit-Owner: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
    Gerrit-Attention: Kramer Ge <fang...@chromium.org>
    Gerrit-Comment-Date: Mon, 08 Dec 2025 21:16:54 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Thomas Anderson (Gerrit)

    unread,
    Dec 8, 2025, 4:18:35 PM (14 days ago) Dec 8
    to Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
    Attention needed from Kramer Ge

    Thomas Anderson added 1 comment

    Commit Message
    Line 13, Patchset 2 (Latest):Bug: 462468374
    Thomas Anderson . unresolved

    Fixed: 462468374, 461877477

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kramer Ge
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ida658bf700a8686b3f87c233e627d87981454436
      Gerrit-Change-Number: 7239547
      Gerrit-PatchSet: 2
      Gerrit-Owner: Kramer Ge <fang...@chromium.org>
      Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
      Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
      Gerrit-Attention: Kramer Ge <fang...@chromium.org>
      Gerrit-Comment-Date: Mon, 08 Dec 2025 21:18:24 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Kramer Ge (Gerrit)

      unread,
      Dec 8, 2025, 5:01:53 PM (13 days ago) Dec 8
      to Thomas Anderson, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

      Kramer Ge voted and added 1 comment

      Votes added by Kramer Ge

      Commit-Queue+2

      1 comment

      Commit Message
      Line 13, Patchset 2:Bug: 462468374
      Thomas Anderson . resolved

      Fixed: 462468374, 461877477

      Kramer Ge

      Done

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ida658bf700a8686b3f87c233e627d87981454436
        Gerrit-Change-Number: 7239547
        Gerrit-PatchSet: 3
        Gerrit-Owner: Kramer Ge <fang...@chromium.org>
        Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
        Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
        Gerrit-Comment-Date: Mon, 08 Dec 2025 22:01:45 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Thomas Anderson <thomasa...@chromium.org>
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Dec 8, 2025, 5:06:03 PM (13 days ago) Dec 8
        to Kramer Ge, Thomas Anderson, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

        Chromium LUCI CQ submitted the change

        Unreviewed changes

        2 is the latest approved patch-set.
        No files were changed between the latest approved patch-set and the submitted one.

        Change information

        Commit message:
        Resolve WaylandWpColorManager::Observer UAF

        `WaylandWpColorManagementOutput` is observing `WaylandWpColorManager`.
        The former outlives the latter because former is owned by
        `WaylandOutput` and is destroyed in member list.
        Fixed: 462468374, 461877477
        Change-Id: Ida658bf700a8686b3f87c233e627d87981454436
        Commit-Queue: Kramer Ge <fang...@chromium.org>
        Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1555723}
        Files:
        • M ui/ozone/platform/wayland/host/wayland_wp_color_management_output.cc
        • M ui/ozone/platform/wayland/host/wayland_wp_color_management_output.h
        • M ui/ozone/platform/wayland/host/wayland_wp_color_management_surface.cc
        • M ui/ozone/platform/wayland/host/wayland_wp_color_management_surface.h
        • M ui/ozone/platform/wayland/host/wayland_wp_color_manager.cc
        • M ui/ozone/platform/wayland/host/wayland_wp_color_manager.h
        Change size: S
        Delta: 6 files changed, 17 insertions(+), 1 deletion(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Thomas Anderson
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ida658bf700a8686b3f87c233e627d87981454436
        Gerrit-Change-Number: 7239547
        Gerrit-PatchSet: 4
        Gerrit-Owner: Kramer Ge <fang...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
        Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages