Reland "[X11] Make IsSelectionOwner asynchronous in PlatformClipboard" [chromium/src : main]
0 views
Skip to first unread message
Thomas Anderson (Gerrit)
Mar 16, 2026, 1:38:39 PMMar 16
to AyeAye, Lei Zhang, Chromium LUCI CQ, Kramer Ge, Sadrul Chowdhury, chromium...@chromium.org, David Baron, omnibox-...@chromium.org, jdonnel...@chromium.org, dcheng+c...@chromium.org, ozone-...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com
Attention needed from Kramer Ge and Lei Zhang
Thomas Anderson added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Thomas Anderson . resolved
reviewers ptal. the only delta for the reland is chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
Related details
Attention is currently required from:
- Kramer Ge
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Mar 16, 2026, 1:44:49 PMMar 16
to Thomas Anderson, Lei Zhang, AyeAye, Chromium LUCI CQ, Kramer Ge, Sadrul Chowdhury, chromium...@chromium.org, David Baron, omnibox-...@chromium.org, jdonnel...@chromium.org, dcheng+c...@chromium.org, ozone-...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com
Attention needed from Kramer Ge and Thomas Anderson
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Kramer Ge
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Mar 16, 2026, 2:13:14 PMMar 16
to Lei Zhang, AyeAye, Chromium LUCI CQ, Kramer Ge, Sadrul Chowdhury, chromium...@chromium.org, David Baron, omnibox-...@chromium.org, jdonnel...@chromium.org, dcheng+c...@chromium.org, ozone-...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com
Attention needed from Kramer Ge
Thomas Anderson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Anderson
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Describe the fix that makes this reland safe.
Thomas Anderson
Done
Related details
Attention is currently required from:
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Mar 16, 2026, 2:26:22 PMMar 16
to Thomas Anderson, Lei Zhang, AyeAye, Chromium LUCI CQ, Sadrul Chowdhury, chromium...@chromium.org, David Baron, omnibox-...@chromium.org, jdonnel...@chromium.org, dcheng+c...@chromium.org, ozone-...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com
Attention needed from Thomas Anderson
Kramer Ge voted![]( "Open in Gerrit")
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 16, 2026, 4:10:38 PMMar 16
to Thomas Anderson, Kramer Ge, Lei Zhang, AyeAye, Sadrul Chowdhury, chromium...@chromium.org, David Baron, omnibox-...@chromium.org, jdonnel...@chromium.org, dcheng+c...@chromium.org, ozone-...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "[X11] Make IsSelectionOwner asynchronous in PlatformClipboard"
This is a reland of commit 8dc861921d9d2891e2e2c58f9f9404a59416d2aa
OmniboxViewTest.Paste is updated to wait for async clipboard operations
to complete.
Original change's description:
> [X11] Make IsSelectionOwner asynchronous in PlatformClipboard
>
> This change refactors the IsSelectionOwner method in the
> PlatformClipboard interface and its implementations to be asynchronous.
> This allows the X11 backend to eliminate a synchronous X11 Sync() call
> in GetSelectionOwner, furthering the goal of an entirely asynchronous
> clipboard architecture.
>
> R=thestig
>
> Change-Id: Ic616ebb106d3fcb36a83a47c70da6742887a70d3
> Bug: 40398800
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7659748
> Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
> Auto-Submit: Thomas Anderson <thomasa...@chromium.org>
> Reviewed-by: Kramer Ge <fang...@chromium.org>
> Reviewed-by: Lei Zhang <the...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1599158}
Cq-Include-Trybots: luci.chrome.try:linux64-rel-ready
Bug: 40398800
Change-Id: I9221926596b8b03fc2396be470a2cb1d66851134
Auto-Submit: Thomas Anderson <thomasa...@chromium.org>
Reviewed-by: Kramer Ge <fang...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
Commit-Queue: Kramer Ge <fang...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1600073}
Files:
- M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
- M ui/base/clipboard/clipboard_ozone.cc
- M ui/base/x/x11_clipboard_helper.cc
- M ui/base/x/x11_clipboard_helper.h
- M ui/ozone/platform/wayland/host/wayland_clipboard.cc
- M ui/ozone/platform/wayland/host/wayland_clipboard.h
- M ui/ozone/platform/wayland/host/wayland_clipboard_unittest.cc
- M ui/ozone/platform/x11/x11_clipboard_ozone.cc
- M ui/ozone/platform/x11/x11_clipboard_ozone.h
- M ui/ozone/public/platform_clipboard.h
Change size: M
Delta: 10 files changed, 150 insertions(+), 51 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kramer Ge, +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages