[//ui] Hardcode BGRA for CreateNativePixmapForVulkan() [chromium/src : main]
0 views
Skip to first unread message
Vasiliy Telezhnikov (Gerrit)
Nov 4, 2025, 9:41:43 AM (2 days ago) Nov 4
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Colin Blundell
Vasiliy Telezhnikov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
2 comments
Patchset-level comments
File ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
Line 326, Patchset 1 (Latest):
PFN_vkCreateDmaBufImageINTEL create_dma_buf_image_intel =Vasiliy Telezhnikov . resolved
(out of the scope here): We probably should move this code to demo (and maybe use VK_EXT_image_drm_format_modifier, though that is arguable lower priority), so we can remove this function.
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 5, 2025, 2:56:40 AM (yesterday) Nov 5
to Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[//ui] Hardcode BGRA for CreateNativePixmapForVulkan()
This format is effectively already hardcoded in the one implementation
of this method [1]. Hardcoding it in the interface both adds clarity
here and removes an unneeded usage of BufferFormat.
[1] https://source.chromium.org/chromium/chromium/src/+/main:ui/ozone/platform/drm/gpu/gbm_surface_factory.cc;l=345;drc=738b9cee146635852b8f994cb3fd4e101285c29e;bpv=1;bpt=1
Bug: 450325664
Change-Id: Ie2ec36033e4a34202fd3e8c5f64015f7411eca6c
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1540502}
Files:
- M ui/ozone/demo/vulkan_overlay_renderer.cc
- M ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
- M ui/ozone/platform/drm/gpu/gbm_surface_factory.h
- M ui/ozone/public/surface_factory_ozone.cc
- M ui/ozone/public/surface_factory_ozone.h
Change size: S
Delta: 5 files changed, 6 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Nov 5, 2025, 4:48:01 AM (yesterday) Nov 5
to Chromium LUCI CQ, Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, ozone-...@chromium.org
Colin Blundell added 1 comment![]( "Open in Gerrit")
File ui/ozone/platform/drm/gpu/gbm_surface_factory.cc
Line 326, Patchset 1:
PFN_vkCreateDmaBufImageINTEL create_dma_buf_image_intel =Vasiliy Telezhnikov . resolved
(out of the scope here): We probably should move this code to demo (and maybe use VK_EXT_image_drm_format_modifier, though that is arguable lower priority), so we can remove this function.
Colin Blundell
You mean move the whole `CreateNativePixmapForVulkan()` method, right? We would need a SurfaceFactoryOzone method to create the backing GbmBuffer unless I'm missing something - is that what you were thinking?
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages