Paint widgets as active based on xdg-shell activated state [chromium/src : main]
1 view
Skip to first unread message
Thomas Anderson (Gerrit)
Apr 17, 2026, 11:43:54 AM (12 days ago) Apr 17
to Athul Iddya, Nico Weber, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Athul Iddya and Nico Weber
Thomas Anderson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Anderson
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Thomas Anderson . resolved
This change makes sense to me. lgtm if the bots are happy.
Related details
Attention is currently required from:
- Athul Iddya
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Apr 20, 2026, 5:32:02 PM (9 days ago) Apr 20
to Athul Iddya, Chromium LUCI CQ, Nico Weber, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Athul Iddya and Nico Weber
Thomas Anderson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Athul Iddya
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Apr 20, 2026, 5:33:12 PM (9 days ago) Apr 20
to Athul Iddya, Chromium LUCI CQ, Nico Weber, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Athul Iddya and Nico Weber
Thomas Anderson added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Thomas Anderson . resolved
pinging thakis@
Nico Weber (Gerrit)
Apr 20, 2026, 6:56:48 PM (9 days ago) Apr 20
to Athul Iddya, Nico Weber, Thomas Anderson, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Athul Iddya
Nico Weber voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nico Weber
| Code-Review | +1 |
1 comment
Patchset-level comments
Nico Weber . resolved
stamp
Related details
Attention is currently required from:
- Athul Iddya
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Apr 20, 2026, 8:27:05 PM (9 days ago) Apr 20
to Athul Iddya, Nico Weber, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Attention needed from Athul Iddya
Thomas Anderson voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Athul Iddya
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 20, 2026, 9:25:03 PM (9 days ago) Apr 20
to Athul Iddya, Nico Weber, Thomas Anderson, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Paint widgets as active based on xdg-shell activated state
According to xdg-shell, client window decorations should be painted as
active based on the `activated` state. From
https://gitlab.freedesktop.org/wayland/wayland-protocols/-/blob/911ab509edf6fc14b89599658199cc932417e9c8/stable/xdg-shell/xdg-shell.xml#L869-871
> Client window decorations should be painted as if the window is
> active. Do not assume this means that the window actually has
> keyboard or pointer focus.
Wayland separates the concepts of keyboard focus and paint activation,
but `OnActivationChanged` is used to signal both in Chromium. Since
https://crrev.com/c/6285685, `OnActivationChanged` has been driven by
keyboard focus when a keyboard is present. However, this causes the
window to be painted as inactive during move, resize, and compositor
window menu invocation.
Fix this by introducing `OnPaintAsActiveChanged`, which fires only on
Wayland. DesktopWindowTreeHostPlatform holds and releases a
paint-as-active lock in response to `OnPaintAsActiveChanged`. This
prevents crbug.com/365143359 from regressing while letting `activated`
state drive paint state.
Bug: 499958029
Change-Id: Ie5d546f25fd8519c4860f4f722ded43b451943ac
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Reviewed-by: Nico Weber <tha...@chromium.org>
Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1617919}
Files:
- M ui/ozone/platform/wayland/host/wayland_toplevel_window.cc
- M ui/ozone/platform/wayland/host/wayland_window_unittest.cc
- M ui/ozone/test/mock_platform_window_delegate.h
- M ui/platform_window/platform_window_delegate.h
- M ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc
- M ui/views/widget/desktop_aura/desktop_window_tree_host_platform.h
- M ui/views/widget/desktop_aura/desktop_window_tree_host_platform_unittest.cc
Change size: M
Delta: 7 files changed, 110 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Thomas Anderson, +1 by Nico Weber
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages