| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
const SkPath path = SkPath::Circle(rect.CenterPoint().x(),skia todo: Circle(point, radius) in addition to Circle(x, y, radius) ...
SkPath::Circle(bounds.x() + bounds.width() / 2,In skia, we would say bounds.center() ...
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +1 |
PTAL
tbarzic:
apps/..
ash/..
chrome/browser/ash/..
tedchoc:
chrome/browser/..
components/..
ahijazi:
testing/libfuzzer/..
oshima:
chromeos/ash/experiences/..
ui/..
Thanks!
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
lgtm fro
chrome/browser/..
components/..
/*isClosed=*/false);Just confirming the previous path defaulted to being unclosed (e.g. no change in behavior here).
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
/*isClosed=*/false);Just confirming the previous path defaulted to being unclosed (e.g. no change in behavior here).
Correct: Skia paths require an explicit `close()` verb to close, and the previous path was unclosed.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
+thomasanderson for ui/views/widget/desktop_aura/
Thanks!
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc lgtm
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
+davidbienvenu for ui/views/widget/desktop_aura/ desktop_window_tree_host_win.cc
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hmm, I can't guess an owner for ui/views/widget/desktop_aura/ desktop_window_tree_host_win.cc, +chromium-ui-views-reviews.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reviewer source(s):
dfr...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ui/views/config.gwsq)
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[pathbuilder] Enforce immutable SkPath APIs globally
Path-editing methods in Skia's SkPath are being deprecated. This is the
final step in migrating Chromium to SkPathBuilder.
Turn on SK_HIDE_PATH_EDIT_METHODS to enforce non-editing SkPath APIs.
Refactor remaining call sites (that were missed in previous cleanup CLs)
to use SkPathBuilder or named factories.
No functional changes.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |