wayland: add missing return to XdgSessionManager::RemoveToplevel [chromium/src : main]

0 views
Skip to first unread message

Nick Yamane (Gerrit)

unread,
May 6, 2025, 8:01:02 PM5/6/25
to Chromium LUCI CQ, Orko Garai, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

New activity on the change

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie24755a3b929312c99bce6baac2a041a3fcc8611
Gerrit-Change-Number: 6517534
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Yamane <nick...@igalia.com>
Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
Gerrit-Comment-Date: Wed, 07 May 2025 00:00:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Orko Garai (Gerrit)

unread,
May 6, 2025, 8:03:42 PM5/6/25
to Nick Yamane, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Nick Yamane

Orko Garai voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Nick Yamane
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie24755a3b929312c99bce6baac2a041a3fcc8611
Gerrit-Change-Number: 6517534
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Yamane <nick...@igalia.com>
Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
Gerrit-Attention: Nick Yamane <nick...@igalia.com>
Gerrit-Comment-Date: Wed, 07 May 2025 00:03:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
May 6, 2025, 8:54:08 PM5/6/25
to Nick Yamane, Orko Garai, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
wayland: add missing return to XdgSessionManager::RemoveToplevel

R=or...@igalia.com
Bug: 352081012
Change-Id: Ie24755a3b929312c99bce6baac2a041a3fcc8611
Commit-Queue: Nick Yamane <nick...@igalia.com>
Auto-Submit: Nick Yamane <nick...@igalia.com>
Reviewed-by: Orko Garai <or...@igalia.com>
Commit-Queue: Orko Garai <or...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1456688}
Files:
  • M ui/ozone/platform/wayland/host/xdg_session_manager.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Orko Garai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie24755a3b929312c99bce6baac2a041a3fcc8611
Gerrit-Change-Number: 6517534
Gerrit-PatchSet: 2
Gerrit-Owner: Nick Yamane <nick...@igalia.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages