Remove includes of callback_forward.h from .cc files [chromium/src : main]

0 views

Skip to first unread message

Lei Zhang (Gerrit)

unread,

Nov 24, 2025, 5:19:24 PM (7 days ago) Nov 24

to Lei Zhang, Kyle Charbonneau, AyeAye Python Dispatcher, Andrew Williams, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, Dustin Mitchell, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mike Taylor, Hu, Ningxin, Permissions Reviews, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Su, Victor Tan, Wanming Lin, James Maclean, Zijie He, Chromium LUCI CQ, aakalla...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, alexmt...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, crostin...@chromium.org, derinel+wat...@google.com, dfried...@chromium.org, dimich...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, emircan+watch...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fgorsk...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, halliwe...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jasonrobe...@google.com, jdh+wa...@chromium.org, jdonnel...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, language...@chromium.org, lcwu+...@chromium.org, liu+wa...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mcasas+med...@chromium.org, media-cro...@chromium.org, mfoltz+wa...@chromium.org, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, njeunje+...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, ortuno...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, rginda...@chromium.org, ricea...@chromium.org, rizvis...@google.com, rmcelra...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, shgar+aut...@google.com, shimazu...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, svend+w...@chromium.org, tburkar...@chromium.org, toyosh...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org

Attention needed from Kyle Charbonneau

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Commit-Queue

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Lei Zhang . resolved

Please OO+1 as //base/OWNERS.

Open in Gerrit

Related details

Attention is currently required from:

Kyle Charbonneau

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kyle Charbonneau (Gerrit)

unread,

Nov 25, 2025, 5:31:31 PM (6 days ago) Nov 25

to Lei Zhang, AyeAye Python Dispatcher, Andrew Williams, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, Dustin Mitchell, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mike Taylor, Hu, Ningxin, Permissions Reviews, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Su, Victor Tan, Wanming Lin, James Maclean, Zijie He, Chromium LUCI CQ, aakalla...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, alexmt...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, crostin...@chromium.org, derinel+wat...@google.com, dfried...@chromium.org, dimich...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, emircan+watch...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fgorsk...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, halliwe...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jasonrobe...@google.com, jdh+wa...@chromium.org, jdonnel...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, language...@chromium.org, lcwu+...@chromium.org, liu+wa...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mcasas+med...@chromium.org, media-cro...@chromium.org, mfoltz+wa...@chromium.org, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, njeunje+...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, ortuno...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, rginda...@chromium.org, ricea...@chromium.org, rizvis...@google.com, rmcelra...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, shgar+aut...@google.com, shimazu...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, svend+w...@chromium.org, tburkar...@chromium.org, toyosh...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org

Attention needed from Lei Zhang

Kyle Charbonneau voted and added 1 comment

Votes added by Kyle Charbonneau

Code-Review	+1
Owners-Override	+1

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Kyle Charbonneau . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 25, 2025, 5:42:21 PM (6 days ago) Nov 25

Lei Zhang voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

Nov 25, 2025, 6:45:19 PM (5 days ago) Nov 25

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Nov 25, 2025, 8:32:56 PM (5 days ago) Nov 25

to Lei Zhang, Kyle Charbonneau, AyeAye Python Dispatcher, Akihiro Ota, Andrew Williams, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, Dustin Mitchell, Enterprise Policy Reviews, Andrew Rayskiy, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Mike Taylor, Hu, Ningxin, Permissions Reviews, prerendering-reviews, Jiewei Qian, Rijubrata Bhaumik, Simon Hangl, James Su, Victor Tan, Wanming Lin, James Maclean, Zijie He, aakalla...@chromium.org, abigailbk...@google.com, alexmo...@chromium.org, alexmt...@chromium.org, amaliev+...@chromium.org, android-web...@chromium.org, andysjl...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, bcb+watch-pl...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chfreme...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chrome-tab-group-en...@google.com, chromeos-gfx-...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, core-timi...@chromium.org, creis...@chromium.org, crostin...@chromium.org, derinel+wat...@google.com, dfried...@chromium.org, dimich...@chromium.org, dmurph+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, emircan+watch...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fgorsk...@chromium.org, francisjp...@google.com, fuchsia...@chromium.org, fuzzin...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gcasto+w...@chromium.org, halliwe...@chromium.org, hirokisa...@chromium.org, horo+...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jasonrobe...@google.com, jdh+wa...@chromium.org, jdonnel...@chromium.org, jkeitel+watch-...@google.com, jophba...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kaklilu+watch-...@chromium.org, katie...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, language...@chromium.org, lcwu+...@chromium.org, liu+wa...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mac-r...@chromium.org, marimatthew+watc...@google.com, marq+...@chromium.org, mattreyno...@chromium.org, max+watc...@igalia.com, mcasas+med...@chromium.org, media-cro...@chromium.org, mfoltz+wa...@chromium.org, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, nickdiego+wa...@igalia.com, njeunje+...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, ortuno+w...@chromium.org, ortuno...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, rginda...@chromium.org, ricea...@chromium.org, rizvis...@google.com, rmcelra...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, shgar+aut...@google.com, shimazu...@chromium.org, shuche...@chromium.org, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, speed-metrics...@chromium.org, storage...@chromium.org, svend+w...@chromium.org, tburkar...@chromium.org, toyosh...@chromium.org, tranbaod...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, video-networking...@google.com, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, xinghui...@chromium.org, yhanad...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Remove includes of callback_forward.h from .cc files

Generally, .cc files should not be forward declaring base::OnceCallback
and related classes. If they are using Callbacks, they should include
callback.h instead. So treat the base/functional/callback_forward.h
includes as superfluous and remove them.

Bug: 40318405

Change-Id: I487c907e520d03be3db5b03a8757c7f2559c8278

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7201005

Commit-Queue: Lei Zhang <the...@chromium.org>

Owners-Override: Kyle Charbonneau <kyle...@chromium.org>

Reviewed-by: Kyle Charbonneau <kyle...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1550173}

Files:

M android_webview/browser/network_service/aw_proxying_url_loader_factory.cc
M base/fuchsia/system_product_info_unittest.cc
M base/task/sequence_manager/sequence_manager_impl_unittest.cc
M base/test/rectify_callback_unittest.cc
M base/test/run_until_unittest.cc
M base/test/task_environment.cc
M base/test/task_environment_unittest.cc
M base/threading/platform_thread_metrics.cc
M cc/layers/texture_layer_impl.cc
M chromecast/cast_core/grpc/test_utils.cc
M components/account_manager_core/account_manager_facade_impl_unittest.cc
M components/account_manager_core/chromeos/account_manager_mojo_service.cc
M components/affiliations/core/browser/affiliation_fetcher_manager.cc
M components/affiliations/core/browser/affiliation_service_impl.cc
M components/affiliations/core/browser/hash_affiliation_fetcher.cc
M components/autofill/core/browser/data_manager/payments/payments_data_manager.cc
M components/autofill/core/browser/suggestions/plus_addresses/plus_address_suggestion_generator.cc
M components/autofill/core/browser/ui/autofill_external_delegate.cc
M components/autofill/core/browser/ui/payments/bnpl_tos_controller_impl_unittest.cc
M components/autofill/core/browser/ui/payments/payments_window_user_consent_dialog_controller_impl_unittest.cc
M components/bookmarks/test/test_bookmark_client.cc
M components/browser_ui/client_certificate/android/ssl_client_certificate_request_browsertest.cc
M components/collaboration/internal/collaboration_controller_unittest.cc
M components/collaboration/internal/collaboration_service_impl.cc
M components/collaboration/internal/messaging/data_sharing_change_notifier_impl_unittest.cc
M components/collaboration/internal/messaging/instant_message_processor_impl_unittest.cc
M components/collaboration/internal/messaging/messaging_backend_service_impl_unittest.cc
M components/credential_management/android/third_party_credential_manager_bridge.cc
M components/cronet/android/test/quic_test_server.cc
M components/data_sharing/internal/android/data_sharing_service_android_unittest.cc
M components/data_sharing/internal/group_data_model.cc
M components/data_sharing/internal/group_data_store.cc
M components/dom_distiller/core/distiller_page_unittest.cc
M components/exo/buffer_unittest.cc
M components/exo/data_offer_unittest.cc
M components/exo/wayland/fuzzer/server_environment.cc
M components/exo/wayland/server_unittest.cc
M components/feature_engagement/internal/tracker_impl_unittest.cc
M components/file_access/scoped_file_access_copy_unittest.cc
M components/file_access/scoped_file_access_delegate_unittest.cc
M components/history_clusters/core/history_clusters_service_unittest.cc
M components/history_embeddings/ml_intent_classifier.cc
M components/ip_protection/common/ip_protection_core_impl_mojo_unittest.cc
M components/ip_protection/common/ip_protection_core_impl_unittest.cc
M components/ip_protection/common/ip_protection_proxy_delegate_unittest.cc
M components/ip_protection/common/ip_protection_token_manager_impl.cc
M components/language_detection/content/renderer/language_detection_model_manager.cc
M components/leveldb_proto/internal/proto_leveldb_wrapper.cc
M components/live_caption/live_caption_controller.cc
M components/live_caption/live_caption_controller_unittest.cc
M components/live_caption/views/caption_bubble_browsertest.cc
M components/live_caption/views/caption_bubble_model.cc
M components/messages/android/test/messages_test_helper.cc
M components/metrics/structured/structured_metrics_service.cc
M components/metrics/structured/test/test_event_storage.cc
M components/mirroring/browser/single_client_video_capture_host_unittest.cc
M components/mirroring/service/openscreen_session_host.cc
M components/mirroring/service/openscreen_session_host_unittest.cc
M components/named_mojo_ipc_server/named_mojo_server_endpoint_connector_linux.cc
M components/named_mojo_ipc_server/named_mojo_server_endpoint_connector_mac.cc
M components/named_mojo_ipc_server/named_mojo_server_endpoint_connector_unsupported.cc
M components/network_time/network_time_tracker_unittest.cc
M components/offline_pages/task/task_queue_unittest.cc
M components/optimization_guide/core/model_execution/android/model_broker_android.cc
M components/optimization_guide/core/model_execution/performance_class.cc
M components/optimization_guide/core/model_execution/test/test_on_device_model_component_state_manager.cc
M components/password_manager/content/browser/content_password_manager_driver.cc
M components/password_manager/core/browser/actor_login/internal/actor_login_credential_filler.cc
M components/password_manager/core/browser/password_autofill_manager.cc
M components/password_manager/core/browser/password_credential_filler_impl_unittest.cc
M components/password_manager/core/browser/password_store/get_logins_with_affiliations_request_handler.cc
M components/password_manager/core/browser/sharing/password_receiver_service_impl.cc
M components/password_manager/core/browser/sharing/recipients_fetcher_impl.cc
M components/permissions/permission_context_base.cc
M components/plus_addresses/core/browser/plus_address_preallocator_unittest.cc
M components/plus_addresses/core/browser/plus_address_service_impl_unittest.cc
M components/policy/core/browser/url_list/policy_blocklist_service.cc
M components/policy/test_support/fake_dmserver_unittest.cc
M components/power_bookmarks/core/bookmark_client_base_unittest.cc
M components/remote_cocoa/app_shim/immersive_mode_tabbed_controller_cocoa.mm
M components/reporting/util/status_unittest.cc
M components/reporting/util/statusor_unittest.cc
M components/safe_browsing/content/browser/async_check_tracker.cc
M components/saved_tab_groups/internal/saved_tab_group_sync_bridge.cc
M components/search_engines/android/template_url_service_android_unittest.cc
M components/segmentation_platform/embedder/input_delegate/tab_session_source_unittest.cc
M components/segmentation_platform/internal/database/database_maintenance_impl.cc
M components/segmentation_platform/internal/database/signal_database_impl.cc
M components/segmentation_platform/internal/execution/model_executor_impl_unittest.cc
M components/segmentation_platform/internal/execution/model_manager_impl_unittest.cc
M components/segmentation_platform/internal/execution/processing/uma_feature_processor_unittest.cc
M components/segmentation_platform/internal/selection/request_dispatcher.cc
M components/segmentation_platform/internal/stats_unittest.cc
M components/services/storage/dom_storage/leveldb/dom_storage_database_leveldb.cc
M components/signin/internal/identity_manager/profile_oauth2_token_service_unittest.cc
M components/signin/public/browser/web_signin_tracker_unittest.cc
M components/supervised_user/core/browser/list_family_members_service.cc
M components/supervised_user/core/browser/proto_fetcher.cc
M components/supervised_user/core/browser/proto_fetcher_unittest.cc
M components/sync/service/glue/sync_engine_impl.cc
M components/trusted_vault/icloud_keychain_recovery_factor_unittest.mm
M components/trusted_vault/standalone_trusted_vault_backend.cc
M components/trusted_vault/standalone_trusted_vault_client.cc
M components/unexportable_keys/mojom/unexportable_key_service_proxy_unittest.cc
M components/user_education/common/feature_promo/feature_promo_controller.cc
M components/user_education/common/feature_promo/feature_promo_precondition.cc
M components/user_education/common/feature_promo/feature_promo_precondition_unittest.cc
M components/user_education/common/feature_promo/feature_promo_specification.cc
M components/user_education/common/feature_promo/impl/messaging_coordinator.cc
M components/user_education/common/feature_promo/impl/messaging_coordinator_unittest.cc
M components/user_education/common/help_bubble/help_bubble_factory_registry_unittest.cc
M components/user_education/common/session/user_education_session_manager.cc
M components/user_education/common/session/user_education_session_manager_unittest.cc
M components/user_education/views/help_bubble_factory_views_unittest.cc
M components/user_education/views/help_bubble_view_unittest.cc
M components/user_education/webui/help_bubble_handler.cc
M components/visited_url_ranking/internal/url_grouping/android/group_suggestions_service_android_unittest.cc
M components/viz/service/display_embedder/skia_output_surface_impl.cc
M components/viz/service/display_embedder/skia_output_surface_impl_unittest.cc
M components/webapps/browser/installable/metrics/site_manifest_metrics_task.cc
M components/webapps/browser/installable/ml_installability_promoter.cc
M content/browser/browsing_data/browsing_data_remover_impl.cc
M content/browser/browsing_data/clear_site_data_utils.cc
M content/browser/btm/btm_bounce_detector.cc
M content/browser/btm/btm_bounce_detector_unittest.cc
M content/browser/btm/btm_service_impl.cc
M content/browser/btm/btm_service_unittest.cc
M content/browser/file_system_access/file_system_access_file_delegate_host_impl.cc
M content/browser/file_system_access/file_system_access_file_handle_impl.cc
M content/browser/file_system_access/file_system_access_manager_impl.cc
M content/browser/indexed_db/indexed_db_internals_ui.cc
M content/browser/indexed_db/instance/backing_store_pre_close_task_queue.cc
M content/browser/indexed_db/instance/connection.cc
M content/browser/indexed_db/instance/database.cc
M content/browser/indexed_db/instance/leveldb/backing_store.cc
M content/browser/interest_group/interest_group_browsertest.cc
M content/browser/interest_group/interest_group_caching_storage.cc
M content/browser/interest_group/interest_group_manager_impl_unittest.cc
M content/browser/loader/keep_alive_url_loader.cc
M content/browser/network_service_instance_impl.cc
M content/browser/permissions/permission_controller_impl.cc
M content/browser/preloading/prerender/prerender_browsertest.cc
M content/browser/preloading/prerender/prerender_no_vary_search_hint_commit_deferring_condition.cc
M content/browser/profiling_utils.cc
M content/browser/renderer_host/code_cache_host_impl_unittest.cc
M content/browser/renderer_host/document_associated_data.cc
M content/browser/renderer_host/indexed_db_client_state_checker_factory_unittest.cc
M content/browser/renderer_host/media/fake_video_capture_device_launcher.cc
M content/browser/renderer_host/media/in_process_launched_video_capture_device.cc
M content/browser/renderer_host/media/service_launched_video_capture_device.cc
M content/browser/renderer_host/media/video_capture_host.cc
M content/browser/shared_storage/shared_storage_browsertest.cc
M content/browser/shared_storage/shared_storage_fenced_frame_browsertest.cc
M content/browser/storage_partition_impl.cc
M content/browser/tpcd_heuristics/opener_heuristic_browsertest.cc
M content/browser/tpcd_heuristics/opener_heuristic_metrics_unittest.cc
M content/browser/tpcd_heuristics/opener_heuristic_tab_helper.cc
M content/browser/webauth/authenticator_impl_unittest.cc
M content/browser/webid/request_service_multiple_frames_unittest.cc
M content/browser/webid/request_service_registry_unittest.cc
M content/browser/webid/request_service_unittest.cc
M content/browser/webid/user_info_request_unittest.cc
M content/browser/webui/web_ui_managed_interface_browsertest.cc
M content/public/test/browser_test_utils.cc
M content/public/test/test_download_http_response.cc
M content/renderer/local_resource_url_loader_factory_unittest.cc
M content/renderer/media/media_permission_dispatcher.cc
M device/bluetooth/bluetooth_socket_android.cc
M device/fido/cable/fido_ble_connection_unittest.cc
M extensions/browser/api/feedback_private/feedback_service.cc
M extensions/browser/api/file_handlers/app_file_handler_util.cc
M extensions/common/command.cc
M fuchsia_web/webengine/browser/client_hints_browsertest.cc
M ios/chrome/browser/authentication/consistency_promo_signin/coordinator/consistency_promo_signin_mediator_unittest.mm
M ios/chrome/browser/authentication/ui_bundled/continuation.mm
M ios/chrome/browser/authentication/ui_bundled/signin/reauth/signin_reauth_coordinator_unittest.mm
M ios/chrome/browser/credential_exchange/model/credential_importer.mm
M ios/chrome/browser/home_customization/coordinator/home_customization_background_photo_framing_mediator.mm
M ios/chrome/browser/home_customization/model/user_uploaded_image_manager.mm
M ios/chrome/browser/save_to_photos/ui_bundled/save_to_photos_mediator_unittest.mm
M ios/chrome/browser/shared/ui/util/pasteboard_util.mm
M ios/chrome/browser/snapshots/model/image_file_manager_unittest.mm
M ios/chrome/browser/snapshots/model/legacy_snapshot_storage.mm
M ios/chrome/test/fakes/fake_ui_view_controller.mm
M media/audio/android/aaudio_output.cc
M media/audio/audio_debug_recording_helper_unittest.cc
M media/cast/encoding/size_adaptable_video_encoder_base_unittest.cc
M media/cast/logging/log_event_dispatcher.cc
M media/cast/logging/log_event_dispatcher_unittest.cc
M media/cast/logging/receiver_time_offset_estimator_impl_unittest.cc
M media/gpu/android/ndk_media_codec_wrapper_unittest.cc
M media/gpu/chromeos/gl_image_processor_backend.cc
M media/midi/midi_manager_unittest.cc
M media/mojo/clients/mojo_codec_factory.cc
M net/base/network_change_notifier_passive_unittest.cc
M net/dns/dns_task_results_manager_unittest.cc
M net/http/http_stream_factory_unittest.cc
M net/quic/quic_session_attempt_manager_unittest.cc
M net/socket/tcp_stream_attempt_unittest.cc
M net/test/embedded_test_server/default_handlers.cc
M net/test/embedded_test_server/embedded_test_server.cc
M net/test/embedded_test_server/http1_connection.cc
M net/test/embedded_test_server/http_response.cc
M net/websockets/websocket_stream_cookie_test.cc
M remoting/host/chromeos/file_session_storage.cc
M remoting/host/delegating_desktop_display_info_monitor_unittest.cc
M remoting/host/it2me/it2me_confirmation_dialog_chromeos.cc
M remoting/host/it2me/it2me_host_unittest.cc
M remoting/host/linux/fake_capture_stream.cc
M remoting/host/linux/gnome_desktop_resizer_unittest.cc
M remoting/host/mac/agent_process_broker_unittest.cc
M remoting/host/remote_open_url/remote_open_url_client_unittest.cc
M remoting/host/remote_open_url/url_forwarder_configurator_main_win.cc
M remoting/protocol/session_authz_authenticator_unittest.cc
M services/accessibility/fake_service_client.cc
M services/device/generic_sensor/generic_sensor_service_unittest.cc
M services/device/public/cpp/test/fake_usb_device_manager.cc
M services/network/cookie_access_delegate_impl.cc
M services/network/partial_decoder_unittest.cc
M services/network/proxy_auto_config_library_unittest.cc
M services/network/public/cpp/simple_url_loader_unittest.cc
M services/network/restricted_cookie_manager.cc
M services/webnn/host/execution_provider_initializer.cc
M sql/recovery_unittest.cc
M storage/browser/blob/write_blob_to_file.cc
M storage/browser/file_system/copy_or_move_hook_delegate_composite.cc
M storage/browser/file_system/copy_or_move_hook_delegate_composite_unittest.cc
M storage/browser/file_system/local_file_stream_reader_unittest.cc
M storage/browser/quota/quota_manager_impl.cc
M storage/browser/quota/quota_manager_unittest.cc
M third_party/blink/renderer/core/paint/timing/paint_timing.cc
M third_party/blink/renderer/core/timing/window_performance.cc
M third_party/blink/renderer/core/workers/dedicated_worker_test.cc
M third_party/blink/renderer/modules/ai/language_model.cc
M third_party/blink/renderer/modules/ai/model_execution_responder.cc
M third_party/blink/renderer/modules/ai/model_execution_responder_test.cc
M third_party/blink/renderer/modules/direct_sockets/udp_readable_stream_wrapper.cc
M third_party/blink/renderer/modules/mediarecorder/key_frame_request_processor_unittest.cc
M third_party/blink/renderer/modules/peerconnection/peer_connection_dependency_factory.cc
M third_party/blink/renderer/modules/peerconnection/rtc_rtp_script_transform.cc
M third_party/blink/renderer/platform/loader/fetch/url_loader/resource_request_sender.cc
M third_party/webrtc_overrides/timer_based_tick_provider.cc
M tools/aggregation_service/aggregation_service_tool.cc
M tools/memory/simulator/memory_simulator_main.cc
M ui/base/accelerators/command.cc
M ui/base/ime/ash/ime_keyboard_impl.cc
M ui/base/interaction/element_tracker_unittest.cc
M ui/base/interaction/interaction_sequence.cc
M ui/base/interaction/interaction_sequence_unittest.cc
M ui/base/interaction/interactive_test_unittest.cc
M ui/events/ozone/evdev/imposter_checker_evdev.cc
M ui/events/ozone/evdev/keyboard_evdev.cc
M ui/events/ozone/keyboard/slow_keys_handler_unittest.cc
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc
M ui/ozone/platform/wayland/host/wayland_clipboard_unittest.cc
M ui/ozone/platform/wayland/test/test_wayland_server_thread.cc
M ui/shell_dialogs/select_file_dialog_mac_unittest.mm
M ui/views/accessibility/ax_attribute_changed_callbacks.cc
M ui/views/controls/button/button.cc
M ui/views/interaction/interaction_test_util_mouse.cc
M ui/views/interaction/interaction_test_util_views.cc
M ui/views/interaction/interactive_views_test.cc
M ui/views/widget/root_view_unittest.cc
M ui/views/widget/widget_interactive_uitest_utils.cc

Change size: L

Delta: 264 files changed, 17 insertions(+), 283 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Kyle Charbonneau

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages