Fix unsafe buffer usage in drm_display_host_manager.cc [chromium/src : main]

0 views
Skip to first unread message

Colin Blundell (Gerrit)

unread,
May 5, 2026, 3:04:58 AMMay 5
to Xiang Ji, Peter McNeeley, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org, Colin Blundell
Attention needed from Peter McNeeley and Xiang Ji

Colin Blundell added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Colin Blundell . resolved

Thanks! -> Peter as a closer OWNER who has expertise with low-level C++

Open in Gerrit

Related details

Attention is currently required from:
  • Peter McNeeley
  • Xiang Ji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c8fbc1acdc27a1a838b6a7d45eaf018c520c299
Gerrit-Change-Number: 7812588
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Ji <jxi...@google.com>
Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
Gerrit-Reviewer: Xiang Ji <jxi...@google.com>
Gerrit-Attention: Xiang Ji <jxi...@google.com>
Gerrit-Attention: Peter McNeeley <peterm...@google.com>
Gerrit-Comment-Date: Tue, 05 May 2026 07:04:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Peter McNeeley (Gerrit)

unread,
May 5, 2026, 8:43:32 AMMay 5
to Xiang Ji, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Xiang Ji

Peter McNeeley voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Xiang Ji
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c8fbc1acdc27a1a838b6a7d45eaf018c520c299
Gerrit-Change-Number: 7812588
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Ji <jxi...@google.com>
Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
Gerrit-Reviewer: Xiang Ji <jxi...@google.com>
Gerrit-Attention: Xiang Ji <jxi...@google.com>
Gerrit-Comment-Date: Tue, 05 May 2026 12:43:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Xiang Ji (Gerrit)

unread,
May 5, 2026, 11:59:32 AMMay 5
to Peter McNeeley, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org

Xiang Ji voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c8fbc1acdc27a1a838b6a7d45eaf018c520c299
Gerrit-Change-Number: 7812588
Gerrit-PatchSet: 1
Gerrit-Owner: Xiang Ji <jxi...@google.com>
Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
Gerrit-Reviewer: Xiang Ji <jxi...@google.com>
Gerrit-CC: Kramer Ge <fang...@chromium.org>
Gerrit-Comment-Date: Tue, 05 May 2026 15:59:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
May 5, 2026, 12:57:03 PMMay 5
to Xiang Ji, Kramer Ge, Peter McNeeley, chromium...@chromium.org, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Fix unsafe buffer usage in drm_display_host_manager.cc

Replaced C-style array and memset with std::array and zero-initialization
to fix unsafe buffer errors. Used bounds-checked access for array lookup.

Initial patchset generated by headless gemini-cli using:
//agents/prompts/projects/spanification/run.py
Bug: 435317390
Change-Id: I1c8fbc1acdc27a1a838b6a7d45eaf018c520c299
Commit-Queue: Xiang Ji <jxi...@google.com>
Reviewed-by: Peter McNeeley <peterm...@google.com>
Cr-Commit-Position: refs/heads/main@{#1625516}
Files:
  • M ui/ozone/platform/drm/host/drm_display_host_manager.cc
Change size: S
Delta: 1 file changed, 8 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Peter McNeeley
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1c8fbc1acdc27a1a838b6a7d45eaf018c520c299
Gerrit-Change-Number: 7812588
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Ji <jxi...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
Gerrit-Reviewer: Xiang Ji <jxi...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages