Reland "Sanitize cursor theme name and size in GTK and Wayland" [chromium/src : main]

1 view
Skip to first unread message

Thomas Anderson (Gerrit)

unread,
Aug 3, 2026, 7:38:53 PM (9 days ago) Aug 3
to android-bu...@system.gserviceaccount.com, Yichen Zhou, Chromium LUCI CQ, Sadrul Chowdhury, chromium...@chromium.org, Henrique Ferreiro, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com
Attention needed from Yichen Zhou

Thomas Anderson voted and added 1 comment

Votes added by Thomas Anderson

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Thomas Anderson . resolved

yichenz@ ptal at the reland. delta for the reland is between PS1 and PS2: I've just removed the failing test, since later versions of GTK have their own validation for the property which prevents the test from setting an out of range value.

Open in Gerrit

Related details

Attention is currently required from:
  • Yichen Zhou
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I29b295e3296eb82a1304d9884d547cf939528f5a
Gerrit-Change-Number: 8180111
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Yichen Zhou <yic...@chromium.org>
Gerrit-CC: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Yichen Zhou <yic...@chromium.org>
Gerrit-Comment-Date: Mon, 03 Aug 2026 23:38:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Anderson (Gerrit)

unread,
Aug 4, 2026, 6:03:15 PM (8 days ago) Aug 4
to android-bu...@system.gserviceaccount.com, Yichen Zhou, Chromium LUCI CQ, Sadrul Chowdhury, chromium...@chromium.org, Henrique Ferreiro, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com
Attention needed from Yichen Zhou

Thomas Anderson voted and added 1 comment

Votes added by Thomas Anderson

Commit-Queue+1

1 comment

Patchset-level comments
Thomas Anderson . resolved

pinging yichenz@

Gerrit-Comment-Date: Tue, 04 Aug 2026 22:02:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Anderson (Gerrit)

unread,
Aug 4, 2026, 6:04:24 PM (8 days ago) Aug 4
to android-bu...@system.gserviceaccount.com, Yichen Zhou, Chromium LUCI CQ, Sadrul Chowdhury, chromium...@chromium.org, Henrique Ferreiro, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com
Attention needed from Yichen Zhou

Thomas Anderson voted and added 1 comment

Votes added by Thomas Anderson

Auto-Submit+0

1 comment

Patchset-level comments
Thomas Anderson . resolved

actually, removing autosubmit because I need to investigate bug 542165218 first

Gerrit-Comment-Date: Tue, 04 Aug 2026 22:04:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Yichen Zhou (Gerrit)

unread,
Aug 4, 2026, 6:14:27 PM (8 days ago) Aug 4
to Thomas Anderson, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Sadrul Chowdhury, chromium...@chromium.org, Henrique Ferreiro, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com
Attention needed from Thomas Anderson

Yichen Zhou voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Anderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I29b295e3296eb82a1304d9884d547cf939528f5a
Gerrit-Change-Number: 8180111
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Yichen Zhou <yic...@chromium.org>
Gerrit-CC: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Aug 2026 22:14:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Thomas Anderson (Gerrit)

unread,
Aug 4, 2026, 6:18:35 PM (8 days ago) Aug 4
to Yichen Zhou, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Sadrul Chowdhury, chromium...@chromium.org, Henrique Ferreiro, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com

Thomas Anderson voted and added 1 comment

Votes added by Thomas Anderson

Commit-Queue+2

1 comment

Patchset-level comments
Thomas Anderson . resolved

actually, removing autosubmit because I need to investigate bug 542165218 first

Thomas Anderson

This is fixed in the latest patch set. The issue was 0 needs to be considered a valid cursor size.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I29b295e3296eb82a1304d9884d547cf939528f5a
Gerrit-Change-Number: 8180111
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Yichen Zhou <yic...@chromium.org>
Gerrit-CC: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Aug 2026 22:18:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Anderson <thomasa...@chromium.org>
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Aug 4, 2026, 8:24:01 PM (8 days ago) Aug 4
to Thomas Anderson, Yichen Zhou, android-bu...@system.gserviceaccount.com, Sadrul Chowdhury, chromium...@chromium.org, Henrique Ferreiro, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: ui/base/cursor/cursor_unittest.cc
Insertions: 1, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: ui/base/cursor/cursor_factory.cc
Insertions: 1, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: ui/gtk/gtk_util_unittest.cc
Insertions: 27, Deletions: 0.

The diff is too large to show. Please review the diff.
```
```
The name of the file: ui/ozone/platform/wayland/host/wayland_cursor_factory.cc
Insertions: 1, Deletions: 1.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:
Reland "Sanitize cursor theme name and size in GTK and Wayland"

This is a reland of commit 283ac1ef12df16eb0256a4d5ce83477b5afba061

Original change's description:
> Sanitize cursor theme name and size in GTK and Wayland
>
> This change extends GtkSettingsSetProperty interceptor and GtkUi to
> sanitize gtk-cursor-theme-name and gtk-cursor-theme-size at write-time,
> preventing unsanitized cursor theme names from being set in GTK
> settings.
>
> It also introduces unified ui::IsValidCursorThemeName and
> ui::IsValidCursorThemeSize validation helpers in //ui/base/cursor, and
> adds validation to WaylandCursorFactory to ensure invalid or
> path-traversing cursor theme names are rejected before calling
> wl_cursor_theme_load.
>
> Change-Id: Ibe8a3ce208d76d2e724902424491a6116d4352f6
> Fixed: 540289900
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8164559
> Reviewed-by: Yichen Zhou <yic...@chromium.org>
> Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1670761}
Bug: 542165218
Fixed: 540289900
Change-Id: I29b295e3296eb82a1304d9884d547cf939528f5a
Reviewed-by: Yichen Zhou <yic...@chromium.org>
Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1673803}
Files:
  • M ui/base/cursor/cursor_factory.cc
  • M ui/base/cursor/cursor_factory.h
  • M ui/base/cursor/cursor_unittest.cc
  • M ui/base/x/x11_cursor_loader.cc
  • M ui/gtk/gtk_ui.cc
  • M ui/gtk/gtk_ui.h
  • M ui/gtk/gtk_util.cc
  • M ui/gtk/gtk_util.h
  • M ui/gtk/gtk_util_unittest.cc
  • M ui/ozone/platform/wayland/host/wayland_cursor_factory.cc
Change size: M
Delta: 10 files changed, 166 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Yichen Zhou
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I29b295e3296eb82a1304d9884d547cf939528f5a
Gerrit-Change-Number: 8180111
Gerrit-PatchSet: 5
open
diffy
satisfied_requirement

Zonghan Xu (Gerrit)

unread,
Aug 10, 2026, 9:58:44 AM (3 days ago) Aug 10
to Chromium LUCI CQ, Thomas Anderson, Yichen Zhou, android-bu...@system.gserviceaccount.com, Sadrul Chowdhury, chromium...@chromium.org, Henrique Ferreiro, ozone-...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com

Zonghan Xu has created a revert of this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: revert
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages