Kramer Ge (Gerrit)

unread,

Feb 3, 2026, 5:31:46 PMFeb 3

to Vasiliy Telezhnikov, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org

Attention needed from Colin Blundell and Vasiliy Telezhnikov

Kramer Ge voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Vasiliy Telezhnikov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Colin Blundell (Gerrit)

unread,

Feb 4, 2026, 3:18:41 AMFeb 4

to Kramer Ge, Vasiliy Telezhnikov, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org

Attention needed from Kramer Ge and Vasiliy Telezhnikov

Colin Blundell added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Colin Blundell . resolved

Thanks! I'll review after Vasiliy LGTMs.

Open in Gerrit

Related details

Attention is currently required from:

Kramer Ge
Vasiliy Telezhnikov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Vasiliy Telezhnikov (Gerrit)

unread,

Feb 4, 2026, 2:38:09 PMFeb 4

to Kramer Ge, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org

Attention needed from Kramer Ge

Vasiliy Telezhnikov voted and added 2 comments

Votes added by Vasiliy Telezhnikov

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Vasiliy Telezhnikov . resolved

lgtm % nit, thanks.

File gpu/command_buffer/service/service_utils.cc

Line 155, Patchset 4 (Latest): attribs.allow_es_version_fallback = false;

Vasiliy Telezhnikov . unresolved

nit: I think this is fine because the code [here](https://source.chromium.org/chromium/chromium/src/+/main:gpu/command_buffer/service/context_group.cc;drc=85adc28ab1a46f69c6f24479242288f0edc4589d;l=163) would reject it anyway, but it might be worth doing with a kill-switch just in case.

Open in Gerrit

Related details

Attention is currently required from:

Kramer Ge

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kramer Ge (Gerrit)

unread,

Feb 4, 2026, 3:00:26 PMFeb 4

to Vasiliy Telezhnikov, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org

Kramer Ge voted and added 1 comment

Votes added by Kramer Ge

Commit-Queue

+1

1 comment

File gpu/command_buffer/service/service_utils.cc

Line 155, Patchset 4: attribs.allow_es_version_fallback = false;

Vasiliy Telezhnikov . resolved

nit: I think this is fine because the code [here](https://source.chromium.org/chromium/chromium/src/+/main:gpu/command_buffer/service/context_group.cc;drc=85adc28ab1a46f69c6f24479242288f0edc4589d;l=163) would reject it anyway, but it might be worth doing with a kill-switch just in case.

Kramer Ge

I moved this to the next patch with the feature flag.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Colin Blundell (Gerrit)

unread,

Feb 6, 2026, 3:18:45 AMFeb 6

to Kramer Ge, Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org

Attention needed from Kramer Ge

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Colin Blundell . resolved

Thanks - apologies for the delay, I missed that it was my turn on this one yesterday!

Open in Gerrit

Related details

Attention is currently required from:

Kramer Ge

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Kramer Ge (Gerrit)

unread,

Feb 6, 2026, 1:19:41 PM (14 days ago) Feb 6

to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org

Kramer Ge voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Feb 6, 2026, 2:33:36 PM (14 days ago) Feb 6

to Kramer Ge, Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, geoffla...@chromium.org, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[//ui/gl] Add ES fallback option to GLContextAttribs

Add .allow_es_version_fallback field to GLContextAttribs specifying
whether fallback to a lower ES version context is allowed.

Current fallbacks disallowed:
- WebGPU compat, requires ES 3.1 for compute

Also clarifying the logging of context creation failures to show whether
fallback is disabled or whether failed context creation is a fallback.

More ES fallback versions are noted here:
https://docs.google.com/document/d/1hYMAWE1qCOwQ7Xc3yi26NwLV3CxVfGTdR5cmyWkZSng

Bug: 444049511

Change-Id: I08bf1d990f0c4f10c4c5a637730c2f74a77047ef

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7539665

Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>

Reviewed-by: Colin Blundell <blun...@chromium.org>

Commit-Queue: Kramer Ge <fang...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1581015}

Files:

M gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
M gpu/command_buffer/service/service_utils.cc
M gpu/command_buffer/service/webgpu_decoder_impl.cc
M ui/gl/gl_context.h
M ui/gl/gl_context_egl.cc

Change size: S

Delta: 5 files changed, 26 insertions(+), 12 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Vasiliy Telezhnikov, +1 by Colin Blundell

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[//ui/gl] Add ES fallback option to GLContextAttribs [chromium/src : main]

Kramer Ge (Gerrit)

Kramer Ge voted Commit-Queue+1

Related details

Colin Blundell (Gerrit)

Colin Blundell added 1 comment

Related details

Vasiliy Telezhnikov (Gerrit)

Vasiliy Telezhnikov voted and added 2 comments

Votes added by Vasiliy Telezhnikov

2 comments

Related details

Kramer Ge (Gerrit)

Kramer Ge voted and added 1 comment

Votes added by Kramer Ge

1 comment

Related details

Colin Blundell (Gerrit)

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

1 comment

Related details

Kramer Ge (Gerrit)

Kramer Ge voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information