ozone/drm: Skip configuration fallback for tiled display [chromium/src : main]
0 views
Skip to first unread message
Su Hong Koo (Gerrit)
Aug 26, 2025, 5:27:43 PM (12 days ago) Aug 26
to Gil Dekel, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Gil Dekel
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Gil Dekel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Su Hong Koo (Gerrit)
Aug 27, 2025, 4:46:51 PM (11 days ago) Aug 27
to Gil Dekel, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Gil Dekel
Su Hong Koo added 1 comment![]( "Open in Gerrit")
File ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc
Line 593, Patchset 1 (Latest):
!is_commit && !config_success && !HasTiledDisplay();Su Hong Koo . unresolved
will add b/441557393 and a TODO here after a round of review
Related details
Attention is currently required from:
- Gil Dekel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Su Hong Koo (Gerrit)
Aug 27, 2025, 5:27:20 PM (11 days ago) Aug 27
to Gil Dekel, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Gil Dekel
Su Hong Koo added 1 comment![]( "Open in Gerrit")
File ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc
will add b/441557393 and a TODO here after a round of review
Su Hong Koo
Done
Related details
Attention is currently required from:
- Gil Dekel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gil Dekel (Gerrit)
Aug 27, 2025, 5:28:58 PM (11 days ago) Aug 27
to Su Hong Koo, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Su Hong Koo
Gil Dekel voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Su Hong Koo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Su Hong Koo (Gerrit)
Aug 27, 2025, 5:29:17 PM (11 days ago) Aug 27
to Gil Dekel, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Su Hong Koo voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 27, 2025, 6:06:19 PM (11 days ago) Aug 27
to Su Hong Koo, Gil Dekel, chromium...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
ozone/drm: Skip configuration fallback for tiled display
The bigjoiner configuration fallback assumes a 1:1 relationship between
displays and CRTC/connectors. However, for tiled displays, this
assumption does not always hold as it may comprise more than one
CRTC/Connector pair. Going through the fallback permutation process
with a tiled display leads to an unrecoverable state. While fixing the
fallback is ideal, we should skip fallback for tiled displays for now
as the chances of having both tiled displays and bigjoiner-capable
displays connected to the same system is incredibly slim.
Bug: b:438719123
Test: New DrmGpuDisplayManager test
Change-Id: I1ce14fc74e833568289e042e1133a52730cc5683
Reviewed-by: Gil Dekel <gild...@chromium.org>
Commit-Queue: Su Hong Koo <su...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1507389}
Files:
- M ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc
- M ui/ozone/platform/drm/gpu/drm_gpu_display_manager.h
- M ui/ozone/platform/drm/gpu/drm_gpu_display_manager_unittest.cc
Change size: M
Delta: 3 files changed, 111 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Gil Dekel
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages