[M129] Wayland text-input-v3: Do not call enable in ShowInputPanel [chromium/src : refs/branch-heads/6668]

0 views
Skip to first unread message

Orko Garai (Gerrit)

unread,
Aug 31, 2024, 12:31:26 AM8/31/24
to Nick Yamane, AyeAye, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Nick Yamane

Orko Garai voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nick Yamane
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6668
Gerrit-Change-Id: I86ec50f842b6c81939acab237e0bcb6ec9628833
Gerrit-Change-Number: 5828209
Gerrit-PatchSet: 1
Gerrit-Owner: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
Gerrit-Attention: Nick Yamane <nick...@igalia.com>
Gerrit-Comment-Date: Sat, 31 Aug 2024 00:31:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Nick Yamane (Gerrit)

unread,
Sep 3, 2024, 1:07:08 PM9/3/24
to Orko Garai, Chromium LUCI CQ, AyeAye, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Orko Garai

Nick Yamane voted and added 1 comment

Votes added by Nick Yamane

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Orko Garai
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6668
Gerrit-Change-Id: I86ec50f842b6c81939acab237e0bcb6ec9628833
Gerrit-Change-Number: 5828209
Gerrit-PatchSet: 1
Gerrit-Owner: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Nick Yamane <nick...@igalia.com>
Gerrit-Reviewer: Orko Garai <or...@igalia.com>
Gerrit-Attention: Orko Garai <or...@igalia.com>
Gerrit-Comment-Date: Tue, 03 Sep 2024 13:06:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Sep 3, 2024, 2:43:54 PM9/3/24
to Orko Garai, Nick Yamane, AyeAye, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[M129] Wayland text-input-v3: Do not call enable in ShowInputPanel

Due to no specified request in the protocol to show input panel, it was
implemented using `enable` as a workaround, which can be problematic in
input field where the ShowInputPanel gets called after the cursor
position is sent in which case the cursor position is no longer retained
leading to the popup being shown in the top-left corner of the window.

So simply remove the workaround to avoid unexpected potential state
resets, as the keyboard does show up when the input is activated.

(cherry picked from commit 5e2b8185c684ae6d155e93ba3eeedef7469b222c)
Fixed: 362191728
Change-Id: I86ec50f842b6c81939acab237e0bcb6ec9628833
Commit-Queue: Orko Garai <or...@igalia.com>
Reviewed-by: Nick Yamane <nick...@igalia.com>
Cr-Original-Commit-Position: refs/heads/main@{#1347398}
Auto-Submit: Orko Garai <or...@igalia.com>
Commit-Queue: Nick Yamane <nick...@igalia.com>
Cr-Commit-Position: refs/branch-heads/6668@{#772}
Cr-Branched-From: 05bc664984ca075216b7f2198c88b9725bfa1b9b-refs/heads/main@{#1343869}
Files:
  • M ui/ozone/platform/wayland/host/zwp_text_input_wrapper_v3.cc
  • M ui/ozone/platform/wayland/host/zwp_text_input_wrapper_v3_unittest.cc
Change size: S
Delta: 2 files changed, 17 insertions(+), 11 deletions(-)
Branch: refs/branch-heads/6668
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nick Yamane
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6668
Gerrit-Change-Id: I86ec50f842b6c81939acab237e0bcb6ec9628833
Gerrit-Change-Number: 5828209
Gerrit-PatchSet: 2
Gerrit-Owner: Orko Garai <or...@igalia.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages