Fix unsafe buffer usage in haptic_touchpad_handler.cc [chromium/src : main]

0 views
Skip to first unread message

Arthur Sonzogni (Gerrit)

unread,
Oct 28, 2025, 6:30:58 AM10/28/25
to Sean O'Brien, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Sean O'Brien

Arthur Sonzogni voted and added 1 comment

Votes added by Arthur Sonzogni

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Arthur Sonzogni . resolved

Hi Sean,
Could you please take a look?

Open in Gerrit

Related details

Attention is currently required from:
  • Sean O'Brien
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I282329022707bcc54ac7fd528a44bd200a1c101f
Gerrit-Change-Number: 7080075
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Sean O'Brien <seob...@chromium.org>
Gerrit-Attention: Sean O'Brien <seob...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Oct 2025 10:30:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
Mar 2, 2026, 9:49:23 AM (11 days ago) Mar 2
to Sean O'Brien, Chromium LUCI CQ, chromium...@chromium.org, seob...@google.com, ozone-...@chromium.org
Attention needed from Sean O'Brien

Arthur Sonzogni added 1 comment

Patchset-level comments
Arthur Sonzogni . resolved

Gentle ping ;-)

Open in Gerrit

Related details

Attention is currently required from:
  • Sean O'Brien
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I282329022707bcc54ac7fd528a44bd200a1c101f
Gerrit-Change-Number: 7080075
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Sean O'Brien <seob...@chromium.org>
Gerrit-Attention: Sean O'Brien <seob...@chromium.org>
Gerrit-Comment-Date: Mon, 02 Mar 2026 14:49:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Sean O'Brien (Gerrit)

unread,
Mar 2, 2026, 9:51:51 AM (11 days ago) Mar 2
to Arthur Sonzogni, Chromium LUCI CQ, chromium...@chromium.org, seob...@google.com, ozone-...@chromium.org
Attention needed from Arthur Sonzogni

Sean O'Brien voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Sonzogni
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I282329022707bcc54ac7fd528a44bd200a1c101f
Gerrit-Change-Number: 7080075
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Sean O'Brien <seob...@chromium.org>
Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Comment-Date: Mon, 02 Mar 2026 14:51:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
Mar 2, 2026, 10:15:28 AM (11 days ago) Mar 2
to Sean O'Brien, Chromium LUCI CQ, chromium...@chromium.org, seob...@google.com, ozone-...@chromium.org
Attention needed from Sean O'Brien

Arthur Sonzogni voted

Auto-Submit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Sean O'Brien
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I282329022707bcc54ac7fd528a44bd200a1c101f
    Gerrit-Change-Number: 7080075
    Gerrit-PatchSet: 3
    Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Sean O'Brien <seob...@chromium.org>
    Gerrit-Attention: Sean O'Brien <seob...@chromium.org>
    Gerrit-Comment-Date: Mon, 02 Mar 2026 15:15:13 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Arthur Sonzogni (Gerrit)

    unread,
    Mar 2, 2026, 10:15:33 AM (11 days ago) Mar 2
    to Sean O'Brien, Chromium LUCI CQ, chromium...@chromium.org, seob...@google.com, ozone-...@chromium.org
    Attention needed from Sean O'Brien

    Arthur Sonzogni added 1 comment

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Arthur Sonzogni . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Sean O'Brien
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I282329022707bcc54ac7fd528a44bd200a1c101f
    Gerrit-Change-Number: 7080075
    Gerrit-PatchSet: 3
    Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Sean O'Brien <seob...@chromium.org>
    Gerrit-Attention: Sean O'Brien <seob...@chromium.org>
    Gerrit-Comment-Date: Mon, 02 Mar 2026 15:15:19 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 2, 2026, 10:41:52 AM (11 days ago) Mar 2
    to Arthur Sonzogni, Sean O'Brien, chromium...@chromium.org, seob...@google.com, ozone-...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    2 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Fix unsafe buffer usage in haptic_touchpad_handler.cc

    Replaced memset with aggregate initialization to fix unsafe buffer
    operations.

    Initial patchet generated by headless gemini-cli using:
    //agents/prompts/projects/spanification/run.py


    Fixed: 455561518
    Change-Id: I282329022707bcc54ac7fd528a44bd200a1c101f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7080075
    Reviewed-by: Sean O'Brien <seob...@chromium.org>
    Commit-Queue: Arthur Sonzogni <arthurs...@chromium.org>
    Auto-Submit: Arthur Sonzogni <arthurs...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1592476}
    Files:
    • M ui/events/ozone/evdev/libgestures_glue/haptic_touchpad_handler.cc
    Change size: XS
    Delta: 1 file changed, 2 insertions(+), 4 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Sean O'Brien
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I282329022707bcc54ac7fd528a44bd200a1c101f
    Gerrit-Change-Number: 7080075
    Gerrit-PatchSet: 4
    Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Sean O'Brien <seob...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages