[M148] [ozone/wayland]Handle window destruction during surface configure [chromium/src : refs/branch-heads/7778]
0 views
Skip to first unread message
Kramer Ge (Gerrit)
Jun 25, 2026, 2:16:25 PM (4 days ago) Jun 25
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Thomas Anderson, android-bu...@system.gserviceaccount.com, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com
Attention needed from Thomas Anderson
Kramer Ge voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Jun 25, 2026, 2:18:18 PM (4 days ago) Jun 25
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com
Kramer Ge voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kramer Ge
| Code-Review | -1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Kramer Ge . resolved
Should abandon, stable is at M149 already
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Jun 25, 2026, 5:35:49 PM (4 days ago) Jun 25
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Kramer Ge, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com
Attention needed from Kramer Ge
Thomas Anderson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Anderson
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Kramer Ge . resolved
Should abandon, stable is at M149 already
Thomas Anderson
M148 is extended stable. I believe we need to merge this.
Related details
Attention is currently required from:
- Kramer Ge
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Jun 26, 2026, 4:04:52 PM (3 days ago) Jun 26
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Thomas Anderson, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com
Attention needed from Thomas Anderson
Kramer Ge voted![]( "Open in Gerrit")
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 26, 2026, 4:47:27 PM (3 days ago) Jun 26
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Kramer Ge, Thomas Anderson, android-bu...@system.gserviceaccount.com, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M148] [ozone/wayland]Handle window destruction during surface configure
Original change's description:
> [ozone/wayland]Handle window destruction during surface configure
>
> ProcessPendingConfigureState() calls RequestStateFromServer(), which
> reaches the delegate's OnStateUpdate(). The views layer may
> synchronously close the widget and destroy the platform window inside
> that callout. The existing weak-ptr guard in
> MaybeApplyLatestStateRequest() returns early in that case, but
> ProcessPendingConfigureState() then continued to access members after
> the call returned.
>
> Add a weak-ptr liveness check around RequestStateFromServer(), mirroring
> the existing pattern used elsewhere in this file and in
> WaylandToplevelWindow::HandleToplevelConfigure().
>
> Fixed: 518006275
> Change-Id: I8812d780c4e46b42bc1a8302c69e4f2e8256b660
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7981871
> Commit-Queue: Kramer Ge <fang...@chromium.org>
> Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1651724}
(cherry picked from commit 06d1bbdddd1f176c3443ca2ddb1f1d21dfe9a094)
Bug: 527756736,518006275
Change-Id: I8812d780c4e46b42bc1a8302c69e4f2e8256b660
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Reviewed-by: Kramer Ge <fang...@chromium.org>
Commit-Queue: Kramer Ge <fang...@chromium.org>
Cr-Commit-Position: refs/branch-heads/7778@{#4430}
Cr-Branched-From: 77f495ee216d4c3cc784d33658bad4778c0680ee-refs/heads/main@{#1610480}
Files:
- M ui/ozone/platform/wayland/host/wayland_window.cc
- M ui/ozone/platform/wayland/host/wayland_window_unittest.cc
Change size: S
Delta: 2 files changed, 22 insertions(+), 0 deletions(-)
Branch: refs/branch-heads/7778
Submit Requirements:
Code-Review: +1 by Thomas Anderson, +1 by Kramer Ge
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages