Etienne Pierre-Doray (Gerrit)

unread,

Jan 22, 2026, 4:38:41 PM (10 days ago) Jan 22

to Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Hongchan Choi, Stephen Chenney, Ian Vollick, Zijie He, android-web...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, scheduler-...@chromium.org, scheduler-b...@chromium.org

Attention needed from Francois Pierre Doray

Etienne Pierre-Doray added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Etienne Pierre-Doray . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

Francois Pierre Doray

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Francois Pierre Doray (Gerrit)

unread,

Jan 23, 2026, 11:19:15 AM (10 days ago) Jan 23

to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Hongchan Choi, Stephen Chenney, Ian Vollick, Zijie He, android-web...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, scheduler-...@chromium.org, scheduler-b...@chromium.org

Attention needed from Etienne Pierre-Doray

Francois Pierre Doray voted and added 3 comments

Votes added by Francois Pierre Doray

Code-Review	+1
Owners-Override	+1

3 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Francois Pierre Doray . resolved

LGTM with minor comments

OO+1 for mechanical changes outside of //base to adapt to a //base API change

File content/browser/child_thread_type_switcher_linux.cc

Line 38, Patchset 3 (Latest): << "kDefault, kInteractive or kDisplayCritical isn't allowed";

Francois Pierre Doray . unresolved

Change to the new name.

File mojo/public/mojom/base/thread_type.mojom

Line 18, Patchset 3 (Latest): // Suitable for display critical threads.

Francois Pierre Doray . unresolved

Fix this comment to match the description in //base.

Open in Gerrit

Related details

Attention is currently required from:

Etienne Pierre-Doray

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

Jan 23, 2026, 11:46:23 AM (10 days ago) Jan 23

to Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Hongchan Choi, Stephen Chenney, Ian Vollick, Zijie He, android-web...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, scheduler-...@chromium.org, scheduler-b...@chromium.org

Etienne Pierre-Doray added 2 comments

File content/browser/child_thread_type_switcher_linux.cc

Line 38, Patchset 3: << "kDefault, kInteractive or kDisplayCritical isn't allowed";

Francois Pierre Doray . resolved

Change to the new name.

Etienne Pierre-Doray

Done

File mojo/public/mojom/base/thread_type.mojom

Line 18, Patchset 3: // Suitable for display critical threads.

Francois Pierre Doray . resolved

Fix this comment to match the description in //base.

Etienne Pierre-Doray

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

Jan 23, 2026, 2:30:23 PM (9 days ago) Jan 23

to Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Hongchan Choi, Stephen Chenney, Ian Vollick, Zijie He, android-web...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, scheduler-...@chromium.org, scheduler-b...@chromium.org

Etienne Pierre-Doray voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

Jan 26, 2026, 7:29:51 AM (7 days ago) Jan 26

to Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Hongchan Choi, Stephen Chenney, Ian Vollick, Zijie He, android-web...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, scheduler-...@chromium.org, scheduler-b...@chromium.org

satisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

Jan 26, 2026, 11:19:40 AM (7 days ago) Jan 26

to Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Hongchan Choi, Stephen Chenney, Ian Vollick, Zijie He, android-web...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, scheduler-...@chromium.org, scheduler-b...@chromium.org

satisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

Jan 26, 2026, 3:46:32 PM (6 days ago) Jan 26

to Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Hongchan Choi, Stephen Chenney, Ian Vollick, Zijie He, android-web...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, scheduler-...@chromium.org, scheduler-b...@chromium.org

satisfied_requirement

open

diffy

Etienne Pierre-Doray (Gerrit)

unread,

Jan 26, 2026, 10:18:38 PM (6 days ago) Jan 26

to Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Hongchan Choi, Stephen Chenney, Ian Vollick, Zijie He, android-web...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, scheduler-...@chromium.org, scheduler-b...@chromium.org

Etienne Pierre-Doray voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 27, 2026, 1:12:17 AM (6 days ago) Jan 27

to Etienne Pierre-Doray, Francois Pierre Doray, chromium...@chromium.org, Dirk Schulze, Hongchan Choi, Stephen Chenney, Ian Vollick, Zijie He, android-web...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, scheduler-...@chromium.org, scheduler-b...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: content/browser/child_thread_type_switcher_linux.cc
Insertions: 1, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: mojo/public/mojom/base/thread_type.mojom
Insertions: 2, Deletions: 1.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

[base] Rename ThreadType::s/kDisplayCritical/kPresentation

kDisplayCritical was introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/3329026

But then because kCompositing was effectively the same thing, it was merged into it in
https://chromium-review.googlesource.com/c/chromium/src/+/4842549

Today, kDisplayCritical refers to any thread involved in producing
visible content. This CL renames the ThreadType to better reflect those threads.

Bug: 470337728

Change-Id: Icec523ff692dc5a6c06fa97ff69b20ae459f2010

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7457593

Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>

Owners-Override: Francois Pierre Doray <fdo...@chromium.org>

Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1574997}

Files:

M android_webview/browser/gfx/viz_compositor_thread_runner_webview.cc
M base/files/important_file_writer.cc
M base/no_destructor_unittest.cc
M base/process/process_unittest.cc
M base/threading/platform_thread.h
M base/threading/platform_thread_android.cc
M base/threading/platform_thread_apple.mm
M base/threading/platform_thread_cros.cc
M base/threading/platform_thread_fuchsia.cc
M base/threading/platform_thread_linux.cc
M base/threading/platform_thread_unittest.cc
M base/threading/platform_thread_win.cc
M base/threading/scoped_thread_priority_unittest.cc
M chrome/browser/ash/schedqos/dbus_schedqos_state_handler.cc
M chrome/browser/ash/schedqos/dbus_schedqos_state_handler_unittest.cc
M chromecast/media/audio/capture_service/capture_service_receiver.cc
M chromeos/ash/components/boca/spotlight/spotlight_remoting_client_manager.cc
M components/startup_metric_utils/common/startup_metric_utils.cc
M components/viz/demo/service/demo_service.cc
M components/viz/service/display_embedder/compositor_gpu_thread.cc
M components/viz/service/main/viz_compositor_thread_runner_impl.cc
M components/viz/service/main/viz_main_impl.cc
M content/browser/browser_main_loop.cc
M content/browser/browser_thread_browsertest.cc
M content/browser/child_thread_type_switcher_linux.cc
M content/browser/gpu/gpu_process_host.cc
M content/browser/network_service_instance_impl.cc
M content/browser/scheduler/browser_task_executor.cc
M content/child/child_process.cc
M content/gpu/gpu_main.cc
M content/gpu/in_process_gpu_thread.cc
M content/renderer/render_process.cc
M content/renderer/render_thread_impl.cc
M content/renderer/renderer_blink_platform_impl.cc
M content/renderer/renderer_main.cc
M mojo/public/cpp/base/thread_type_mojom_traits.cc
M mojo/public/cpp/base/thread_type_unittest.cc
M mojo/public/mojom/base/thread_type.mojom
M third_party/blink/renderer/modules/webaudio/audio_worklet_thread_test.cc
M third_party/blink/renderer/modules/webaudio/semi_realtime_audio_worklet_thread.cc
M third_party/blink/renderer/platform/graphics/begin_frame_provider.cc
M third_party/blink/renderer/platform/scheduler/common/thread.cc
M third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
M third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
M third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
M ui/compositor/display_link_mac_mojo.mm
M ui/events/ozone/evdev/event_thread_evdev.cc
M ui/gl/vsync_thread_win.cc
M ui/ozone/platform/drm/gpu/drm_thread.cc

Change size: M

Delta: 49 files changed, 104 insertions(+), 109 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Francois Pierre Doray

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Minoru Chikamune (Gerrit)

unread,

Jan 27, 2026, 1:31:55 AM (6 days ago) Jan 27

to Chromium LUCI CQ, Etienne Pierre-Doray, Minoru Chikamune, Francois Pierre Doray, chromium...@chromium.org, Dirk Schulze, Hongchan Choi, Stephen Chenney, Ian Vollick, Zijie He, android-web...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, scheduler-...@chromium.org, scheduler-b...@chromium.org

Minoru Chikamune added 1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Minoru Chikamune . resolved

I think this CL caused the following failure.

https://ci.chromium.org/ui/p/chromium/builders/try/android-x64-rel

[45990/46204] CXX obj/content/renderer/renderer/render_thread_impl.o
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/content/renderer/renderer/render_thread_impl.o.d -D__STDC_CONSTANT_MACRO...(too long)
../../content/renderer/render_thread_impl.cc:1491:47: error: no member named 'kDisplayCritical' in 'base::ThreadType'
 1491 |       options.thread_type = base::ThreadType::kDisplayCritical;
      |                                               ^~~~~~~~~~~~~~~~
1 error generated.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,

Jan 27, 2026, 1:41:13 AM (6 days ago) Jan 27

to Chromium LUCI CQ, Etienne Pierre-Doray, Minoru Chikamune, Francois Pierre Doray, chromium...@chromium.org, Dirk Schulze, Hongchan Choi, Stephen Chenney, Ian Vollick, Zijie He, android-web...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, chikamu...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, ipc-securi...@chromium.org, jbauma...@chromium.org, kinuko...@chromium.org, mac-r...@chromium.org, oshima...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org, scheduler-...@chromium.org, scheduler-b...@chromium.org

luci-bi...@appspot.gserviceaccount.com has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[base] Rename ThreadType::s/kDisplayCritical/kPresentation [chromium/src : main]

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray added 1 comment

Related details

Francois Pierre Doray (Gerrit)

Francois Pierre Doray voted and added 3 comments

Votes added by Francois Pierre Doray

3 comments

Related details

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray added 2 comments

Related details

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray voted Commit-Queue+2

Related details

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray (Gerrit)

Etienne Pierre-Doray voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information

Minoru Chikamune (Gerrit)

Minoru Chikamune added 1 comment

Related details

luci-bisection@appspot.gserviceaccount.com (Gerrit)

luci-bi...@appspot.gserviceaccount.com has created a revert of this change

Related details