[//ui] Fix ChromeOS (more) when linking ANGLE statically [chromium/src : main]

0 views
Skip to first unread message

Geoff Lang (Gerrit)

unread,
Jul 21, 2026, 2:44:15 PM (2 days ago) Jul 21
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org
Attention needed from Colin Blundell

Geoff Lang voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I228a1f44108a68c96539fc99ff5984c93a8c1db2
Gerrit-Change-Number: 8126798
Gerrit-PatchSet: 2
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Geoff Lang <geof...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Jul 2026 18:44:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
Jul 22, 2026, 2:59:09 AM (yesterday) Jul 22
to Colin Blundell, Geoff Lang, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I228a1f44108a68c96539fc99ff5984c93a8c1db2
Gerrit-Change-Number: 8126798
Gerrit-PatchSet: 2
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Geoff Lang <geof...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Jul 2026 06:58:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 22, 2026, 3:02:39 AM (yesterday) Jul 22
to Colin Blundell, Geoff Lang, chromium...@chromium.org, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[//ui] Fix ChromeOS (more) when linking ANGLE statically

This target also needs to maintain the data_deps entry on the ANGLE
dylibs based on how the build graphs of targets "upstream" of it work.
Bug: 40268378
Change-Id: I228a1f44108a68c96539fc99ff5984c93a8c1db2
Commit-Queue: Colin Blundell <blun...@chromium.org>
Reviewed-by: Geoff Lang <geof...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1666055}
Files:
  • M ui/ozone/platform/drm/BUILD.gn
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Geoff Lang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I228a1f44108a68c96539fc99ff5984c93a8c1db2
Gerrit-Change-Number: 8126798
Gerrit-PatchSet: 3
Gerrit-Owner: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Geoff Lang <geof...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages