[//ui] Remove BufferFormat from ClientNativePixmapDmabuf interface [chromium/src : main]
0 views
Skip to first unread message
Saifuddin Hitawala (Gerrit)
Jan 7, 2026, 12:45:12 PM (4 days ago) Jan 7
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Colin Blundell
Saifuddin Hitawala voted and added 1 comment![]( "Open in Gerrit")
Votes added by Saifuddin Hitawala
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jan 8, 2026, 2:51:04 AM (4 days ago) Jan 8
to Colin Blundell, Saifuddin Hitawala, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jan 8, 2026, 4:40:49 AM (4 days ago) Jan 8
to Colin Blundell, Saifuddin Hitawala, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Commit-Queue | +2 |
Colin Blundell . resolved
Thanks!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jan 8, 2026, 4:55:13 AM (4 days ago) Jan 8
to Colin Blundell, Saifuddin Hitawala, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Colin Blundell voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 8, 2026, 6:20:04 AM (3 days ago) Jan 8
to Colin Blundell, Saifuddin Hitawala, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ui/ozone/platform/wayland/ozone_platform_wayland.cc
Insertions: 0, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[//ui] Remove BufferFormat from ClientNativePixmapDmabuf interface
Followup will remove it from the implementation.
Bug: 356649879
Change-Id: Icb18e2efc724e9b3dfce8bf9e2c98682fc561257
Reviewed-by: Saifuddin Hitawala <hita...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566190}
Files:
- M ui/gfx/linux/client_native_pixmap_dmabuf.cc
- M ui/gfx/linux/client_native_pixmap_dmabuf.h
- M ui/ozone/platform/drm/ozone_platform_drm.cc
- M ui/ozone/platform/wayland/ozone_platform_wayland.cc
Change size: S
Delta: 4 files changed, 18 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Saifuddin Hitawala
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jan 8, 2026, 6:51:51 AM (3 days ago) Jan 8
to Chromium LUCI CQ, Colin Blundell, Saifuddin Hitawala, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Colin Blundell has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Saifuddin Hitawala (Gerrit)
Jan 8, 2026, 10:55:54 AM (3 days ago) Jan 8
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Colin Blundell
Saifuddin Hitawala voted and added 1 comment![]( "Open in Gerrit")
Votes added by Saifuddin Hitawala
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 9, 2026, 2:51:17 AM (3 days ago) Jan 9
to Colin Blundell, Saifuddin Hitawala, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[//ui] Remove BufferFormat from ClientNativePixmapDmabuf interface
Followup will remove it from the implementation.
Note: This is a reland of [1] following resolution of issues in a parent
CL that had necessitated that [1] be reverted to most easily resolve.
The reland is not changed from the original in any way beyond the change
in ozone_platform_wayland.cc being cosmetically slightly different due
to applying on top of the resolved issues in the parent CL.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/7404141
Bug: 356649879
Change-Id: I8c4da718747c56347d53c1be11069b65effeccab
Commit-Queue: Colin Blundell <blun...@chromium.org>
Reviewed-by: Saifuddin Hitawala <hita...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566763}
Files:
- M ui/gfx/linux/client_native_pixmap_dmabuf.cc
- M ui/gfx/linux/client_native_pixmap_dmabuf.h
- M ui/ozone/platform/drm/ozone_platform_drm.cc
- M ui/ozone/platform/wayland/ozone_platform_wayland.cc
Change size: S
Delta: 4 files changed, 18 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Saifuddin Hitawala
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages