Set fixed refresh rate in Wayland on VRR displays [chromium/src : main]

0 views
Skip to first unread message

Kramer Ge (Gerrit)

unread,
Nov 18, 2025, 2:08:14 PM (13 days ago) Nov 18
to Mitchell Cohen, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Mitchell Cohen

Kramer Ge voted and added 2 comments

Votes added by Kramer Ge

Code-Review+1

2 comments

File ui/ozone/platform/wayland/host/wayland_output.h
Line 8, Patchset 4 (Parent):#include <cstdint>
Kramer Ge . unresolved

this seemed unintentional

File ui/ozone/platform/wayland/host/wayland_output.cc
Line 9, Patchset 4 (Latest):#include <cstdint>
Kramer Ge . unresolved

ditto

Open in Gerrit

Related details

Attention is currently required from:
  • Mitchell Cohen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e7dda451ea51fb890316a45919b8153f10ed67
Gerrit-Change-Number: 7164259
Gerrit-PatchSet: 4
Gerrit-Owner: Mitchell Cohen <mitc...@agilebits.com>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Mitchell Cohen <mitc...@agilebits.com>
Gerrit-Attention: Mitchell Cohen <mitc...@agilebits.com>
Gerrit-Comment-Date: Tue, 18 Nov 2025 19:08:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kramer Ge (Gerrit)

unread,
Nov 18, 2025, 2:12:05 PM (13 days ago) Nov 18
to Mitchell Cohen, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Mitchell Cohen

Kramer Ge added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Kramer Ge . resolved

BTW if there you tried using `ExternalBeginFrameSource` with frame callbacks it would be nice to have for non-VRR displays, s.t. it hopefully shortens the delay a frame gets stuck waiting for system compositor latch.

Open in Gerrit

Related details

Attention is currently required from:
  • Mitchell Cohen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie1e7dda451ea51fb890316a45919b8153f10ed67
Gerrit-Change-Number: 7164259
Gerrit-PatchSet: 4
Gerrit-Owner: Mitchell Cohen <mitc...@agilebits.com>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Mitchell Cohen <mitc...@agilebits.com>
Gerrit-Attention: Mitchell Cohen <mitc...@agilebits.com>
Gerrit-Comment-Date: Tue, 18 Nov 2025 19:11:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mitchell Cohen (Gerrit)

unread,
Nov 20, 2025, 4:29:32 PM (11 days ago) Nov 20
to Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge

Mitchell Cohen added 2 comments

File ui/ozone/platform/wayland/host/wayland_output.h
Kramer Ge . resolved

this seemed unintentional

Mitchell Cohen

Done

File ui/ozone/platform/wayland/host/wayland_output.cc
Line 9, Patchset 4:#include <cstdint>
Kramer Ge . resolved

ditto

Mitchell Cohen

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Kramer Ge
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie1e7dda451ea51fb890316a45919b8153f10ed67
    Gerrit-Change-Number: 7164259
    Gerrit-PatchSet: 6
    Gerrit-Owner: Mitchell Cohen <mitc...@agilebits.com>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Mitchell Cohen <mitc...@agilebits.com>
    Gerrit-Attention: Kramer Ge <fang...@chromium.org>
    Gerrit-Comment-Date: Thu, 20 Nov 2025 21:29:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Kramer Ge <fang...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mitchell Cohen (Gerrit)

    unread,
    Nov 20, 2025, 4:31:51 PM (11 days ago) Nov 20
    to Kramer Ge, Chromium LUCI CQ, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
    Attention needed from Kramer Ge

    Mitchell Cohen added 1 comment

    Patchset-level comments
    Kramer Ge . resolved

    BTW if there you tried using `ExternalBeginFrameSource` with frame callbacks it would be nice to have for non-VRR displays, s.t. it hopefully shortens the delay a frame gets stuck waiting for system compositor latch.

    Mitchell Cohen

    I like the idea of implementing it for non-VRR. I'll try it again separately.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kramer Ge
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie1e7dda451ea51fb890316a45919b8153f10ed67
    Gerrit-Change-Number: 7164259
    Gerrit-PatchSet: 6
    Gerrit-Owner: Mitchell Cohen <mitc...@agilebits.com>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Mitchell Cohen <mitc...@agilebits.com>
    Gerrit-Attention: Kramer Ge <fang...@chromium.org>
    Gerrit-Comment-Date: Thu, 20 Nov 2025 21:31:42 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages