Add a flag to selectively enable touch logging [chromium/src : main]

Harry Cutts (Gerrit)

unread,

Jun 8, 2021, 8:48:40 PM6/8/21

to Michael Spang, Elly Fong-Jones, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org, Harry Cutts

Attention is currently required from: Michael Spang, Elly Fong-Jones.

Harry Cutts would like Michael Spang and Elly Fong-Jones to review this change.

View Change

Add a flag to selectively enable touch logging

This will allow people filing bug reports with the Chrome OS input stack
to temporarily turn on detailed touch logging, file a feedback report,
and then disable it again to avoid logging sensitive information.

Bug: b:185411893
Test: check flag appears in chrome://flags (it won't do anything yet)

Change-Id: Ic0c07df6b4051740e7d07f70c45821b149aa2d57
---
M chrome/browser/about_flags.cc
M chrome/browser/flag-metadata.json
M chrome/browser/flag-never-expire-list.json
M chrome/browser/flag_descriptions.cc
M chrome/browser/flag_descriptions.h
M tools/metrics/histograms/enums.xml
M ui/events/ozone/features.cc
M ui/events/ozone/features.h
8 files changed, 31 insertions(+), 0 deletions(-)

To view, visit change 2947950. To unsubscribe, or for help writing mail filters, visit settings.

Harry Cutts (Gerrit)

unread,

Jun 8, 2021, 8:48:46 PM6/8/21

to Harry Cutts, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org, Elly Fong-Jones, Michael Spang, Chromium Metrics Reviews, chromium...@chromium.org, Kalyan Kondapally

Attention is currently required from: Michael Spang, Elly Fong-Jones.

Patch set 1:Commit-Queue +1

View Change

To view, visit change 2947950. To unsubscribe, or for help writing mail filters, visit settings.

Elly Fong-Jones (Gerrit)

unread,

Jun 9, 2021, 11:07:22 AM6/9/21

to Harry Cutts, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org, Elly Fong-Jones, Chromium LUCI CQ, Michael Spang, Chromium Metrics Reviews, chromium...@chromium.org, Kalyan Kondapally

Attention is currently required from: Michael Spang, Harry Cutts.

Patch set 1:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #1:
  flags lgtm :)

To view, visit change 2947950. To unsubscribe, or for help writing mail filters, visit settings.

Michael Spang (Gerrit)

unread,

Jun 9, 2021, 9:00:06 PM6/9/21

to Harry Cutts, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org, Elly Fong-Jones, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kalyan Kondapally

Attention is currently required from: Harry Cutts.

Patch set 1:Code-Review +1

View Change

To view, visit change 2947950. To unsubscribe, or for help writing mail filters, visit settings.

Harry Cutts (Gerrit)

unread,

Jun 9, 2021, 9:16:36 PM6/9/21

to Harry Cutts, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org, Michael Spang, Elly Fong-Jones, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kalyan Kondapally

Patch set 1:Commit-Queue +2

View Change

To view, visit change 2947950. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Jun 9, 2021, 10:26:18 PM6/9/21

to Harry Cutts, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org, Michael Spang, Elly Fong-Jones, Chromium Metrics Reviews, chromium...@chromium.org, Kalyan Kondapally

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Elly Fong-Jones: Looks good to me
  Michael Spang: Looks good to me
  Harry Cutts: Commit

Add a flag to selectively enable touch logging

This will allow people filing bug reports with the Chrome OS input stack
to temporarily turn on detailed touch logging, file a feedback report,
and then disable it again to avoid logging sensitive information.

Bug: b:185411893
Test: check flag appears in chrome://flags (it won't do anything yet)

Change-Id: Ic0c07df6b4051740e7d07f70c45821b149aa2d57

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2947950
Reviewed-by: Elly Fong-Jones <elly...@chromium.org>
Reviewed-by: Michael Spang <sp...@chromium.org>
Commit-Queue: Harry Cutts <hcu...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#891070}


---
M chrome/browser/about_flags.cc
M chrome/browser/flag-metadata.json
M chrome/browser/flag-never-expire-list.json
M chrome/browser/flag_descriptions.cc
M chrome/browser/flag_descriptions.h
M tools/metrics/histograms/enums.xml
M ui/events/ozone/features.cc
M ui/events/ozone/features.h
8 files changed, 31 insertions(+), 0 deletions(-)

To view, visit change 2947950. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward