[SxS] Enable drag and drop for Split View [chromium/src : main]
0 views
Skip to first unread message
Caroline Rising (Gerrit)
Sep 30, 2025, 11:09:37 AM (7 days ago) Sep 30
to Alison Gale, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Alison Gale
Caroline Rising voted and added 1 comment![]( "Open in Gerrit")
Votes added by Caroline Rising
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Alison Gale
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alison Gale (Gerrit)
Sep 30, 2025, 12:04:15 PM (7 days ago) Sep 30
to Caroline Rising, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Alison Gale added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Caroline Rising . resolved
lgtm % fixing failing tryjob
Alison Gale
Looks like the corresponding end test was already disabled on linux due to test-only screen width discrepencies so I'll disable this as well.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alison Gale (Gerrit)
Sep 30, 2025, 12:05:41 PM (7 days ago) Sep 30
to Kramer Ge, Caroline Rising, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Kramer Ge
Alison Gale added 1 comment![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Sep 30, 2025, 12:53:20 PM (7 days ago) Sep 30
to Alison Gale, Caroline Rising, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Alison Gale
Kramer Ge voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kramer Ge
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Alison Gale
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alison Gale (Gerrit)
Sep 30, 2025, 12:53:37 PM (7 days ago) Sep 30
to Caroline Rising, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Alison Gale voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 30, 2025, 12:56:31 PM (7 days ago) Sep 30
to Alison Gale, Kramer Ge, Caroline Rising, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[SxS] Enable drag and drop for Split View
Now that Wayland supports this type of link drag
Bug: 425715421
Change-Id: I6e61e5c430aeb6aa29fd07ccaf75dbbaedae2360
Reviewed-by: Kramer Ge <fang...@chromium.org>
Commit-Queue: Alison Gale <ag...@chromium.org>
Reviewed-by: Caroline Rising <cori...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1522945}
Files:
- M chrome/browser/ui/views/frame/multi_contents_view.cc
- M chrome/browser/ui/views/frame/multi_contents_view_browsertest.cc
- M chrome/browser/ui/views/frame/multi_contents_view_drop_target_controller_browsertest.cc
- M chrome/browser/ui/views/frame/multi_contents_view_tab_drag_interactive_uitest.cc
- M ui/ozone/platform/wayland/ozone_platform_wayland.cc
- M ui/ozone/public/ozone_platform.h
Change size: M
Delta: 6 files changed, 6 insertions(+), 146 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kramer Ge, +1 by Caroline Rising
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lingqi Chi (Gerrit)
Sep 30, 2025, 9:12:36 PM (7 days ago) Sep 30
to Chromium LUCI CQ, Alison Gale, Caroline Rising, AyeAye, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Lingqi Chi has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages