[M148] [XKB] Harden the layout name parser. [chromium/src : refs/branch-heads/7778]
1 view
Skip to first unread message
chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com (Gerrit)
Apr 21, 2026, 9:16:50 PM (8 days ago) Apr 21
to Mike West, android-bu...@system.gserviceaccount.com, extension...@chromium.org, ozone-...@chromium.org, chromium-a...@chromium.org
chrome-che...@chops-service-accounts.iam.gserviceaccount.com voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
Apr 21, 2026, 9:17:12 PM (8 days ago) Apr 21
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Mike West, android-bu...@system.gserviceaccount.com, extension...@chromium.org, ozone-...@chromium.org, chromium-a...@chromium.org
rubber-...@appspot.gserviceaccount.com voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 21, 2026, 10:19:55 PM (8 days ago) Apr 21
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Mike West, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, extension...@chromium.org, ozone-...@chromium.org, chromium-a...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M148] [XKB] Harden the layout name parser.
Original change's description:
> [XKB] Harden the layout name parser.
>
> This CL adds validation to the input component layout name parser and
> the XKB layout name parser in order to ensure that they match reasonable
> expectations. Since they're used as filenames in `libxkbcommon`, this
> might prevent unexpected path traversal.
>
> Bug: 499130207
> Change-Id: I22864f9deb130a697da2c768a76fa63c8d9429fe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7735525
> Commit-Queue: Mike West <mk...@chromium.org>
> Reviewed-by: Finnur Thorarinsson <fin...@chromium.org>
> Reviewed-by: Sean O'Brien <seob...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1612696}
(cherry picked from commit 73daddbbeb66872bfa5352783bd4422614b55eee)
Bug: 501628566,499130207
Change-Id: I22864f9deb130a697da2c768a76fa63c8d9429fe
Auto-Submit: chrome-che...@chops-service-accounts.iam.gserviceaccount.com <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7778@{#1328}
Cr-Branched-From: 77f495ee216d4c3cc784d33658bad4778c0680ee-refs/heads/main@{#1610480}
Files:
- M extensions/common/BUILD.gn
- M extensions/common/manifest_handlers/input_components_handler.cc
- A extensions/common/manifest_handlers/input_components_handler_unittest.cc
- M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc
- M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc
Change size: M
Delta: 5 files changed, 143 insertions(+), 5 deletions(-)
Branch: refs/branch-heads/7778
Submit Requirements:
Code-Review: Bot-Commit+1 by rubber-...@appspot.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages