Cleanup: Remove histogram macros header includes in ui [chromium/src : main]

0 views
Skip to first unread message

Alexei Svitkine (Gerrit)

unread,
Mar 26, 2026, 1:39:54 PM (7 days ago) Mar 26
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Sadrul Chowdhury, Ian Vollick, abigailbk...@google.com, cc-...@chromium.org, dcheng+c...@chromium.org, dibyapal+wa...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, max+watc...@igalia.com, nektar...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
Attention needed from Colin Blundell

Alexei Svitkine voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iabf2f66d29e6f72246653a958d864c77f66ec063
Gerrit-Change-Number: 7700384
Gerrit-PatchSet: 4
Gerrit-Owner: Alexei Svitkine <asvi...@chromium.org>
Gerrit-Reviewer: Alexei Svitkine <asvi...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Thu, 26 Mar 2026 17:39:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
Mar 26, 2026, 1:44:50 PM (7 days ago) Mar 26
to Alexei Svitkine, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Sadrul Chowdhury, Ian Vollick, abigailbk...@google.com, cc-...@chromium.org, dcheng+c...@chromium.org, dibyapal+wa...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, max+watc...@igalia.com, nektar...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
Attention needed from Alexei Svitkine

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Alexei Svitkine
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iabf2f66d29e6f72246653a958d864c77f66ec063
    Gerrit-Change-Number: 7700384
    Gerrit-PatchSet: 4
    Gerrit-Owner: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-Reviewer: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Ian Vollick <vol...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-Attention: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-Comment-Date: Thu, 26 Mar 2026 17:44:33 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    gwsq (Gerrit)

    unread,
    Mar 26, 2026, 1:48:54 PM (7 days ago) Mar 26
    to Alexei Svitkine, Chromium UI Views Reviews, Keren Zhu, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Sadrul Chowdhury, Ian Vollick, abigailbk...@google.com, cc-...@chromium.org, dcheng+c...@chromium.org, dibyapal+wa...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, max+watc...@igalia.com, nektar...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
    Attention needed from Colin Blundell and Keren Zhu

    Message from gwsq

    Reviewer source(s):
    kere...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ui/views/config.gwsq)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Colin Blundell
    • Keren Zhu
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iabf2f66d29e6f72246653a958d864c77f66ec063
    Gerrit-Change-Number: 7700384
    Gerrit-PatchSet: 4
    Gerrit-Owner: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-Reviewer: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Keren Zhu <kere...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Chromium UI Views Reviews <chromium-ui-...@google.com>
    Gerrit-CC: Ian Vollick <vol...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Colin Blundell <blun...@chromium.org>
    Gerrit-Attention: Keren Zhu <kere...@chromium.org>
    Gerrit-Comment-Date: Thu, 26 Mar 2026 17:48:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Keren Zhu (Gerrit)

    unread,
    Mar 26, 2026, 1:49:47 PM (7 days ago) Mar 26
    to Alexei Svitkine, Chromium UI Views Reviews, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Sadrul Chowdhury, Ian Vollick, abigailbk...@google.com, cc-...@chromium.org, dcheng+c...@chromium.org, dibyapal+wa...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, max+watc...@igalia.com, nektar...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org
    Attention needed from Alexei Svitkine and Colin Blundell

    Keren Zhu voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alexei Svitkine
    • Colin Blundell
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iabf2f66d29e6f72246653a958d864c77f66ec063
    Gerrit-Change-Number: 7700384
    Gerrit-PatchSet: 4
    Gerrit-Owner: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-Reviewer: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Keren Zhu <kere...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Chromium UI Views Reviews <chromium-ui-...@google.com>
    Gerrit-CC: Ian Vollick <vol...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Colin Blundell <blun...@chromium.org>
    Gerrit-Attention: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-Comment-Date: Thu, 26 Mar 2026 17:49:42 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 26, 2026, 1:53:01 PM (7 days ago) Mar 26
    to Alexei Svitkine, Keren Zhu, Chromium UI Views Reviews, Colin Blundell, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, Peter Beverloo, Sadrul Chowdhury, Ian Vollick, abigailbk...@google.com, cc-...@chromium.org, dcheng+c...@chromium.org, dibyapal+wa...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jbauma...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, max+watc...@igalia.com, nektar...@chromium.org, nickdiego+wa...@igalia.com, ozone-...@chromium.org, roblia...@chromium.org, sky+...@chromium.org, yuzo+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Cleanup: Remove histogram macros header includes in ui
    Bug: None
    Change-Id: Iabf2f66d29e6f72246653a958d864c77f66ec063
    Auto-Submit: Alexei Svitkine <asvi...@chromium.org>
    Reviewed-by: Keren Zhu <kere...@chromium.org>
    Reviewed-by: Colin Blundell <blun...@chromium.org>
    Commit-Queue: Keren Zhu <kere...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1605658}
    Files:
    • M ui/accessibility/ax_language_detection.cc
    • M ui/android/delegated_frame_host_android.cc
    • M ui/base/clipboard/clipboard_metrics.cc
    • M ui/base/x/x11_clipboard_helper.cc
    • M ui/compositor/compositor.cc
    • M ui/events/event.cc
    • M ui/events/gestures/blink/web_gesture_curve_impl.cc
    • M ui/events/ozone/evdev/touch_filter/edge_touch_filter.cc
    • M ui/events/ozone/evdev/touch_filter/false_touch_finder.cc
    • M ui/events/platform/x11/x11_event_source.cc
    • M ui/events/x/events_x_utils.cc
    • M ui/gfx/win/direct_write.cc
    • M ui/gl/init/gl_factory.cc
    • M ui/message_center/views/notification_view_base.cc
    • M ui/ozone/platform/drm/gpu/drm_overlay_manager.cc
    • M ui/ozone/platform/drm/gpu/drm_overlay_validator.cc
    • M ui/ozone/platform/drm/gpu/drm_thread.cc
    • M ui/ozone/platform/drm/gpu/drm_thread_proxy.cc
    • M ui/ozone/platform/wayland/host/wayland_data_drag_controller.cc
    • M ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc
    • M ui/views/window/dialog_delegate.cc
    Change size: S
    Delta: 21 files changed, 8 insertions(+), 22 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Keren Zhu, +1 by Colin Blundell
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iabf2f66d29e6f72246653a958d864c77f66ec063
    Gerrit-Change-Number: 7700384
    Gerrit-PatchSet: 5
    Gerrit-Owner: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-Reviewer: Alexei Svitkine <asvi...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Keren Zhu <kere...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages