[gfx] Remove R8/RG88 IsValidDrmFormat support [chromium/src : main]

0 views
Skip to first unread message

Saifuddin Hitawala (Gerrit)

unread,
Apr 28, 2026, 3:47:42 PM (yesterday) Apr 28
to Jonathan Ross, Kramer Ge, Mitsuru Oshima, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, asvitkine...@chromium.org, ozone-...@chromium.org
Attention needed from Jonathan Ross, Kramer Ge and Mitsuru Oshima

Saifuddin Hitawala voted and added 1 comment

Votes added by Saifuddin Hitawala

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Saifuddin Hitawala . resolved

Adding

  • Kramer for full CL review
  • oshima@ for ui/gfx/
  • jonross@ for histograms/

PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Ross
  • Kramer Ge
  • Mitsuru Oshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I97acb6560ea014a04fe3a516b17dd7cf0bcd9500
Gerrit-Change-Number: 7793334
Gerrit-PatchSet: 4
Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Attention: Kramer Ge <fang...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 19:47:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mitsuru Oshima (Gerrit)

unread,
Apr 28, 2026, 3:49:57 PM (yesterday) Apr 28
to Saifuddin Hitawala, Jonathan Ross, Kramer Ge, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, asvitkine...@chromium.org, ozone-...@chromium.org
Attention needed from Jonathan Ross, Kramer Ge and Saifuddin Hitawala

Mitsuru Oshima voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jonathan Ross
  • Kramer Ge
  • Saifuddin Hitawala
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I97acb6560ea014a04fe3a516b17dd7cf0bcd9500
    Gerrit-Change-Number: 7793334
    Gerrit-PatchSet: 4
    Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
    Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Attention: Kramer Ge <fang...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Apr 2026 19:49:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kramer Ge (Gerrit)

    unread,
    Apr 28, 2026, 4:48:37 PM (yesterday) Apr 28
    to Saifuddin Hitawala, Mitsuru Oshima, Jonathan Ross, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, asvitkine...@chromium.org, ozone-...@chromium.org
    Attention needed from Jonathan Ross and Saifuddin Hitawala

    Kramer Ge voted and added 1 comment

    Votes added by Kramer Ge

    Code-Review+1

    1 comment

    Patchset-level comments
    Kramer Ge . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jonathan Ross
    • Saifuddin Hitawala
    Gerrit-Comment-Date: Tue, 28 Apr 2026 20:48:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jonathan Ross (Gerrit)

    unread,
    10:21 AM (9 hours ago) 10:21 AM
    to Saifuddin Hitawala, Mitsuru Oshima, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, asvitkine...@chromium.org, ozone-...@chromium.org
    Attention needed from Saifuddin Hitawala

    Jonathan Ross voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Saifuddin Hitawala
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I97acb6560ea014a04fe3a516b17dd7cf0bcd9500
    Gerrit-Change-Number: 7793334
    Gerrit-PatchSet: 4
    Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Comment-Date: Wed, 29 Apr 2026 14:21:47 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Saifuddin Hitawala (Gerrit)

    unread,
    10:26 AM (9 hours ago) 10:26 AM
    to Jonathan Ross, Mitsuru Oshima, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, asvitkine...@chromium.org, ozone-...@chromium.org

    Saifuddin Hitawala voted and added 1 comment

    Votes added by Saifuddin Hitawala

    Commit-Queue+2

    1 comment

    Patchset-level comments
    Saifuddin Hitawala . resolved

    Thanks for reviews!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I97acb6560ea014a04fe3a516b17dd7cf0bcd9500
    Gerrit-Change-Number: 7793334
    Gerrit-PatchSet: 4
    Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Comment-Date: Wed, 29 Apr 2026 14:25:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    10:30 AM (9 hours ago) 10:30 AM
    to Saifuddin Hitawala, Jonathan Ross, Kramer Ge, Mitsuru Oshima, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, asvitkine...@chromium.org, ozone-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [gfx] Remove R8/RG88 IsValidDrmFormat support

    These formats should no longer be used by Exo [1]. They should also
    not be used by Wayland anymore as all Wayland buffers are created over
    SharedImage and that is also not R/RG.

    This change is guarded behind a killswitch. Also extend this UMA for
    exo until the CL lands to stable.

    [1] https://uma.googleplex.com/p/chrome/timeline_v2?sid=3c06a2877ab58bce2dcfb71502168be7
    Bug: 416285370
    Change-Id: I97acb6560ea014a04fe3a516b17dd7cf0bcd9500
    Reviewed-by: Mitsuru Oshima <osh...@chromium.org>
    Reviewed-by: Jonathan Ross <jon...@chromium.org>
    Reviewed-by: Kramer Ge <fang...@chromium.org>
    Commit-Queue: Saifuddin Hitawala <hita...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1622434}
    Files:
    • M tools/metrics/histograms/metadata/gpu/histograms.xml
    • M ui/gfx/linux/drm_util_linux.cc
    • M ui/ozone/platform/wayland/host/wayland_surface_unittest.cc
    • M ui/ozone/platform/wayland/wayland_buffer_manager_unittest.cc
    Change size: S
    Delta: 4 files changed, 17 insertions(+), 8 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mitsuru Oshima, +1 by Jonathan Ross, +1 by Kramer Ge
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I97acb6560ea014a04fe3a516b17dd7cf0bcd9500
    Gerrit-Change-Number: 7793334
    Gerrit-PatchSet: 5
    Gerrit-Owner: Saifuddin Hitawala <hita...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Saifuddin Hitawala <hita...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages