Remove OzonePlatformHint [chromium/src : main]
0 views
Skip to first unread message
Thomas Anderson (Gerrit)
Aug 4, 2025, 3:46:10 PMAug 4
to Nico Weber, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Attention needed from Nico Weber
Thomas Anderson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Anderson
| Auto-Submit | +1 |
1 comment
File chrome/browser/chrome_browser_main_extra_parts_linux.cc
Line 62, Patchset 2 (Parent):
void ChromeBrowserMainExtraPartsLinux::InitOzonePlatformHint() {Thomas Anderson . resolved
this function
1. doesn't have anything to do with initializing the ozone platform hint
2. isn't used anywhere, so it's removed anyway
Related details
Attention is currently required from:
- Nico Weber
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Aug 4, 2025, 3:55:10 PMAug 4
to Thomas Anderson, Nico Weber, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Attention needed from Thomas Anderson
Nico Weber voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 4, 2025, 3:58:29 PMAug 4
to Thomas Anderson, Nico Weber, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove OzonePlatformHint
The new behavior is the same as if --ozone-platform-hint=auto is always
passed.
Cq-Include-Trybots: luci.chromium.try:linux-wayland-mutter-rel
Change-Id: I60fd72a69097e1ba4a76bfa18bc163329363b214
Bug: 40083534
Auto-Submit: Thomas Anderson <thomasa...@chromium.org>
Reviewed-by: Nico Weber <tha...@chromium.org>
Commit-Queue: Nico Weber <tha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1496532}
Files:
- M chrome/browser/about_flags.cc
- M chrome/browser/chrome_browser_field_trials.cc
- M chrome/browser/chrome_browser_main_extra_parts_linux.cc
- M chrome/browser/chrome_browser_main_extra_parts_linux.h
- M chrome/browser/flag_descriptions.cc
- M chrome/browser/flag_descriptions.h
- M docs/ozone_overview.md
- M tools/metrics/histograms/enums.xml
- M ui/base/ui_base_features.cc
- M ui/base/ui_base_features.h
- M ui/linux/display_server_utils.cc
- M ui/linux/display_server_utils.h
- M ui/ozone/platform_selection.cc
- M ui/ozone/public/ozone_switches.cc
- M ui/ozone/public/ozone_switches.h
Change size: M
Delta: 15 files changed, 22 insertions(+), 163 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nico Weber
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitry Gozman (Gerrit)
Sep 3, 2025, 4:54:00 AM (5 days ago) Sep 3
to Chromium LUCI CQ, Thomas Anderson, Nico Weber, Chromium Metrics Reviews, chromium...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, ozone-...@chromium.org
Dmitry Gozman added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Dmitry Gozman . resolved
Hi! We've encountered a change in behavior in the wild [1], and I think it comes from this CL. I wonder whether that's intended change, and if not - would like to bring it to your attention.
It seems like previously on some Ubuntu 24 setups, ozone platform would default to x11, but after this CL it would be wayland.
The exact way it manifests for the user is: setting `DISPLAY` env is now ignored, unless you explicitly pass `--ozone-platform=x11`.
Please let me know whether that's expected. Thank you!
[1] https://github.com/microsoft/playwright/issues/37236#issuecomment-3247645567
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages