[Flatland] Early-exit if viable_memory_types is zero [chromium/src : main]

0 views
Skip to first unread message

Wez (Gerrit)

unread,
May 20, 2026, 8:23:52 AM (4 days ago) May 20
to David Song, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from David Song

Wez voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Song
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iab4d5ed6315dc19551abbd636f860b9913ae45f2
Gerrit-Change-Number: 7863747
Gerrit-PatchSet: 1
Gerrit-Owner: Wez <w...@chromium.org>
Gerrit-Reviewer: David Song <winter...@google.com>
Gerrit-Reviewer: Wez <w...@chromium.org>
Gerrit-CC: David Worsham <dwor...@google.com>
Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
Gerrit-Attention: David Song <winter...@google.com>
Gerrit-Comment-Date: Wed, 20 May 2026 12:23:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

David Song (Gerrit)

unread,
May 20, 2026, 4:19:50 PM (4 days ago) May 20
to Chromium LUCI CQ, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org
Attention needed from Wez

David Song voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Wez
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iab4d5ed6315dc19551abbd636f860b9913ae45f2
    Gerrit-Change-Number: 7863747
    Gerrit-PatchSet: 1
    Gerrit-Owner: Wez <w...@chromium.org>
    Gerrit-Reviewer: David Song <winter...@google.com>
    Gerrit-Reviewer: Wez <w...@chromium.org>
    Gerrit-CC: David Worsham <dwor...@google.com>
    Gerrit-CC: Robert Kroeger <rjkr...@chromium.org>
    Gerrit-Attention: Wez <w...@chromium.org>
    Gerrit-Comment-Date: Wed, 20 May 2026 20:19:28 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    May 20, 2026, 4:23:19 PM (4 days ago) May 20
    to David Song, chromium...@chromium.org, David Worsham, Robert Kroeger, emi...@google.com, fuchsia...@chromium.org, ozone-...@chromium.org, spang...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [Flatland] Early-exit if viable_memory_types is zero

    Early-exit if viable_memory_types is zero, rather than passing that to std::countr_zero().

    TAG=agy
    CONV=2445a381-fdbe-43e4-b252-645810ce8579
    Bug: 513746684
    Change-Id: Iab4d5ed6315dc19551abbd636f860b9913ae45f2
    Reviewed-by: David Song <winter...@google.com>
    Commit-Queue: David Song <winter...@google.com>
    Auto-Submit: Wez <w...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1633791}
    Files:
    • M ui/ozone/platform/flatland/flatland_sysmem_buffer_collection.cc
    Change size: XS
    Delta: 1 file changed, 6 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by David Song
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iab4d5ed6315dc19551abbd636f860b9913ae45f2
    Gerrit-Change-Number: 7863747
    Gerrit-PatchSet: 2
    Gerrit-Owner: Wez <w...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Song <winter...@google.com>
    Gerrit-Reviewer: Wez <w...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages