[ozone] Added the --ozone-platform-hint flag. [chromium/src : main]
Alexander Dunaev (Gerrit)
Attention is currently required from: Robert Kroeger, Alexander Dunaev, Nico Weber.
Alexander Dunaev uploaded patch set #24 to this change.
[ozone] Added the --ozone-platform-hint flag.
The Ozone platform is currently selected via the --ozone-platform
command line switch. This is not really handy, especially for desktop
users who would like to use a non-default platform daily, or for those
who switches between X11 and Wayland sessions.
This patch introduces the --ozone-platform-hint flag that suggests the
Ozone platform to use. A special "auto" value selects the Wayland
backend if the current session uses Wayland.
[1] https://chromium.googlesource.com/chromium/src/+/main/docs/configuration.md
Bug: 1246928
Change-Id: I602b27363cbdcc87b61b3335865502ea61b356d8
---
M chrome/browser/flag_descriptions.cc
M base/threading/thread_restrictions.h
M chrome/browser/about_flags.cc
M chrome/browser/flag_descriptions.h
M chrome/browser/flag-metadata.json
M ui/ozone/public/ozone_switches.cc
M tools/metrics/histograms/enums.xml
A chrome/browser/chrome_browser_main_extra_parts_linux.h
A chrome/browser/chrome_browser_main_extra_parts_linux.cc
M chrome/browser/chrome_browser_main_extra_parts_ozone.h
M ui/ozone/public/ozone_switches.h
M chrome/browser/BUILD.gn
M chrome/browser/chrome_content_browser_client.cc
13 files changed, 264 insertions(+), 5 deletions(-)
To view, visit change 3188974. To unsubscribe, or for help writing mail filters, visit settings.
Alexander Dunaev (Gerrit)
Attention is currently required from: Robert Kroeger, Alexander Dunaev, Nico Weber.
Alexander Dunaev uploaded patch set #25 to this change.
[ozone] Added the --ozone-platform-hint flag.
To date, the only way to choose the Ozone platform is setting the
--ozone-platform command line switch. That is not really handy,
especially for desktop users who would like to use a non-default
platform daily, or for those who switches between X11 and Wayland
sessions.
This patch introduces the --ozone-platform-hint flag that suggests the
Ozone platform to use. A special "auto" value selects the Wayland
backend if the current session uses Wayland.
[1] https://chromium.googlesource.com/chromium/src/+/main/docs/configuration.md
Bug: 1246928
Change-Id: I602b27363cbdcc87b61b3335865502ea61b356d8
---
M chrome/browser/flag_descriptions.cc
M base/threading/thread_restrictions.h
M chrome/browser/about_flags.cc
M chrome/browser/flag_descriptions.h
M chrome/browser/flag-metadata.json
M ui/ozone/public/ozone_switches.cc
M tools/metrics/histograms/enums.xml
A chrome/browser/chrome_browser_main_extra_parts_linux.h
A chrome/browser/chrome_browser_main_extra_parts_linux.cc
M chrome/browser/chrome_browser_main_extra_parts_ozone.h
M ui/ozone/public/ozone_switches.h
M chrome/browser/BUILD.gn
M chrome/browser/chrome_content_browser_client.cc
13 files changed, 265 insertions(+), 5 deletions(-)
To view, visit change 3188974. To unsubscribe, or for help writing mail filters, visit settings.
Alexander Dunaev (Gerrit)
Attention is currently required from: Michael Spang, Robert Kroeger, Nico Weber.
2 comments:
Patchset:
Michael, Nico, I have changed this after we discussed the changes. Please take one more look. I will wait for your remarks.
File chrome/browser/chrome_browser_main_extra_parts_linux.cc:
base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
switches::kOzonePlatform);This logic rewrites the command line which is a additional reason the flag will not work "normally". […]
I agree that it is better to have this hint using its own switch, exactly due to reasons that Michael mentioned: we rewrite the command line, which makes things complicated if the same switch is used. I have changed the new logic to use the new --ozone-platform-hint switch. If the user runs chrome with --ozone-platform, the hint is ignored.
To view, visit change 3188974. To unsubscribe, or for help writing mail filters, visit settings.
Robert Kroeger (Gerrit)
Attention is currently required from: Michael Spang, Alexander Dunaev, Nico Weber.
Patch set 27:Code-Review +1
Alexander Dunaev (Gerrit)
Attention is currently required from: Michael Spang, Nico Weber.
Patch set 27:Commit-Queue +2
1 comment:
Patchset:
Thank you for the review!
To view, visit change 3188974. To unsubscribe, or for help writing mail filters, visit settings.
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
[ozone] Added the --ozone-platform-hint flag.
To date, the only way to choose the Ozone platform is setting the
--ozone-platform command line switch. That is not really handy,
especially for desktop users who would like to use a non-default
platform daily, or for those who switches between X11 and Wayland
sessions.
This patch introduces the --ozone-platform-hint flag that suggests the
Ozone platform to use. A special "auto" value selects the Wayland
backend if the current session uses Wayland.
[1] https://chromium.googlesource.com/chromium/src/+/main/docs/configuration.md
Bug: 1246928
Change-Id: I602b27363cbdcc87b61b3335865502ea61b356d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3188974
Reviewed-by: Robert Kroeger <rjkr...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Michael Spang <sp...@chromium.org>
Reviewed-by: Nico Weber <tha...@chromium.org>
Commit-Queue: Alexander Dunaev <adu...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#932878}
---
M chrome/browser/flag_descriptions.cc
M base/threading/thread_restrictions.h
M chrome/browser/about_flags.cc
M chrome/browser/flag_descriptions.h
M chrome/browser/flag-metadata.json
M ui/ozone/public/ozone_switches.cc
M tools/metrics/histograms/enums.xml
A chrome/browser/chrome_browser_main_extra_parts_linux.h
A chrome/browser/chrome_browser_main_extra_parts_linux.cc
M chrome/browser/chrome_browser_main_extra_parts_ozone.h
M ui/ozone/public/ozone_switches.h
M chrome/browser/BUILD.gn
M chrome/browser/chrome_content_browser_client.cc
13 files changed, 273 insertions(+), 5 deletions(-)