android: Limit display rgb565 to API 32 or lower [chromium/src : main]
0 views
Skip to first unread message
Bo Liu (Gerrit)
Aug 28, 2025, 12:32:11 PM (11 days ago) Aug 28
to Bo Liu, Vasiliy Telezhnikov, Matthew Jones, Sunny Sachanandani, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Attention needed from Matthew Jones, Sunny Sachanandani and Vasiliy Telezhnikov
Bo Liu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Bo Liu . resolved
ptal
sorry for the back and forth, I guess I should have consolidated to a single function in the last CL
Related details
Attention is currently required from:
- Matthew Jones
- Sunny Sachanandani
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Aug 28, 2025, 12:54:51 PM (11 days ago) Aug 28
to Bo Liu, Matthew Jones, Sunny Sachanandani, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Attention needed from Bo Liu, Matthew Jones and Sunny Sachanandani
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Bo Liu
- Matthew Jones
- Sunny Sachanandani
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matthew Jones (Gerrit)
Aug 28, 2025, 1:10:19 PM (11 days ago) Aug 28
to Bo Liu, Vasiliy Telezhnikov, Sunny Sachanandani, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Attention needed from Bo Liu and Sunny Sachanandani
Matthew Jones voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Bo Liu
- Sunny Sachanandani
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bo Liu (Gerrit)
Aug 28, 2025, 4:09:26 PM (10 days ago) Aug 28
to Bo Liu, Zhenyao Mo, Sunny Sachanandani, Matthew Jones, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Attention needed from Sunny Sachanandani and Zhenyao Mo
Bo Liu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Sunny Sachanandani
- Zhenyao Mo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zhenyao Mo (Gerrit)
Aug 28, 2025, 6:20:03 PM (10 days ago) Aug 28
to Bo Liu, Sunny Sachanandani, Matthew Jones, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Attention needed from Bo Liu and Sunny Sachanandani
Zhenyao Mo voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Bo Liu
- Sunny Sachanandani
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bo Liu (Gerrit)
Aug 28, 2025, 6:29:27 PM (10 days ago) Aug 28
to Bo Liu, Zhenyao Mo, Sunny Sachanandani, Matthew Jones, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Attention needed from Sunny Sachanandani
Bo Liu voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Sunny Sachanandani
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 28, 2025, 6:32:29 PM (10 days ago) Aug 28
to Bo Liu, Zhenyao Mo, Sunny Sachanandani, Matthew Jones, Vasiliy Telezhnikov, chromium...@chromium.org, cc-...@chromium.org, ozone-...@chromium.org, penghu...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
android: Limit display rgb565 to API 32 or lower
RGB565 was based on SysInfo::IsLowEndDevice which is currently <= 1024MB
of memory. Based on histogram data, there's effectively 0 users falling
into IsLowEndDevice for API > 32. And since RGB565 is now <= 512MB which
is an even smaller population, it should be safe to just limit it to <=
API 32.
Enabled-by-default-reason: killswitch
Bug: 435538890
Change-Id: I89162ee273d7ee1d939a8a11c0e5363b34004fd1
Reviewed-by: Zhenyao Mo <z...@chromium.org>
Reviewed-by: Matthew Jones <mdj...@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Bo Liu <bo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1508058}
Files:
- M chrome/browser/android/compositor/compositor_view.cc
- M components/viz/common/viz_utils.cc
- M components/viz/common/viz_utils.h
- M components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
- M ui/gl/gl_features.cc
- M ui/gl/gl_features.h
- M ui/gl/gl_surface_egl.cc
Change size: S
Delta: 7 files changed, 27 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Zhenyao Mo, +1 by Matthew Jones, +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages