Revert "[base] Rename ThreadType::s/kDisplayCritical/kPresentation" [chromium/src : main]

0 views

Skip to first unread message

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,

Jan 27, 2026, 1:41:23 AM (6 days ago) Jan 27

to AyeAye, Chromium LUCI CQ, Etienne Pierre-Doray, Francois Pierre Doray, Minoru Chikamune, Stephen Chenney, Ian Vollick, Zijie He, chromium...@chromium.org, Hongchan Choi, Dirk Schulze, chik...@google.com, blink-...@chromium.org, chikamu...@chromium.org, blink-reviews-p...@chromium.org, penghu...@chromium.org, oshima...@chromium.org, android-web...@chromium.org, drott+bl...@chromium.org, scheduler-b...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, mac-r...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jbauma...@chromium.org, feature-me...@chromium.org, ozone-...@chromium.org, cc-...@chromium.org

Attention needed from Etienne Pierre-Doray and Francois Pierre Doray

luci-bi...@appspot.gserviceaccount.com voted

LUCI Bisection is automatically submitting this revert.

Bot-Commit	+1
Commit-Queue	+2
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

Etienne Pierre-Doray
Francois Pierre Doray

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 27, 2026, 1:41:57 AM (6 days ago) Jan 27

to luci-bi...@appspot.gserviceaccount.com, AyeAye, Etienne Pierre-Doray, Francois Pierre Doray, Minoru Chikamune, Stephen Chenney, Ian Vollick, Zijie He, chromium...@chromium.org, Hongchan Choi, Dirk Schulze, chik...@google.com, blink-...@chromium.org, chikamu...@chromium.org, blink-reviews-p...@chromium.org, penghu...@chromium.org, oshima...@chromium.org, android-web...@chromium.org, drott+bl...@chromium.org, scheduler-b...@chromium.org, kinuko...@chromium.org, scheduler-...@chromium.org, fuchsia...@chromium.org, halliwe...@chromium.org, mac-r...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jbauma...@chromium.org, feature-me...@chromium.org, ozone-...@chromium.org, cc-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Revert "[base] Rename ThreadType::s/kDisplayCritical/kPresentation"

This reverts commit 059998a861f4caeafbb25276fda8b9426c2b9892.

Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8691544067064298481

Sample failed build: https://ci.chromium.org/b/8691544067064298481

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7457593&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8691544067064298481&type=BUG

Original change's description:
> [base] Rename ThreadType::s/kDisplayCritical/kPresentation
>
> kDisplayCritical was introduced in
> https://chromium-review.googlesource.com/c/chromium/src/+/3329026
>
> But then because kCompositing was effectively the same thing, it was merged into it in
> https://chromium-review.googlesource.com/c/chromium/src/+/4842549
>
> Today, kDisplayCritical refers to any thread involved in producing
> visible content. This CL renames the ThreadType to better reflect those threads.
>
> Bug: 470337728
> Change-Id: Icec523ff692dc5a6c06fa97ff69b20ae459f2010
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7457593
> Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
> Owners-Override: Francois Pierre Doray <fdo...@chromium.org>
> Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1574997}
>

Bug: 470337728

No-Presubmit: true

No-Tree-Checks: true

No-Try: true

Change-Id: I83e0820e881de30745d284f1cfa11fec424fe788

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7519528

Commit-Queue: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>

Bot-Commit: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>

Owners-Override: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>

Cr-Commit-Position: refs/heads/main@{#1575001}

Files:

M android_webview/browser/gfx/viz_compositor_thread_runner_webview.cc
M base/files/important_file_writer.cc
M base/no_destructor_unittest.cc
M base/process/process_unittest.cc
M base/threading/platform_thread.h
M base/threading/platform_thread_android.cc
M base/threading/platform_thread_apple.mm
M base/threading/platform_thread_cros.cc
M base/threading/platform_thread_fuchsia.cc
M base/threading/platform_thread_linux.cc
M base/threading/platform_thread_unittest.cc
M base/threading/platform_thread_win.cc
M base/threading/scoped_thread_priority_unittest.cc
M chrome/browser/ash/schedqos/dbus_schedqos_state_handler.cc
M chrome/browser/ash/schedqos/dbus_schedqos_state_handler_unittest.cc
M chromecast/media/audio/capture_service/capture_service_receiver.cc
M chromeos/ash/components/boca/spotlight/spotlight_remoting_client_manager.cc
M components/startup_metric_utils/common/startup_metric_utils.cc
M components/viz/demo/service/demo_service.cc
M components/viz/service/display_embedder/compositor_gpu_thread.cc
M components/viz/service/main/viz_compositor_thread_runner_impl.cc
M components/viz/service/main/viz_main_impl.cc
M content/browser/browser_main_loop.cc
M content/browser/browser_thread_browsertest.cc
M content/browser/child_thread_type_switcher_linux.cc
M content/browser/gpu/gpu_process_host.cc
M content/browser/network_service_instance_impl.cc
M content/browser/scheduler/browser_task_executor.cc
M content/child/child_process.cc
M content/gpu/gpu_main.cc
M content/gpu/in_process_gpu_thread.cc
M content/renderer/render_process.cc
M content/renderer/render_thread_impl.cc
M content/renderer/renderer_blink_platform_impl.cc
M content/renderer/renderer_main.cc
M mojo/public/cpp/base/thread_type_mojom_traits.cc
M mojo/public/cpp/base/thread_type_unittest.cc
M mojo/public/mojom/base/thread_type.mojom
M third_party/blink/renderer/modules/webaudio/audio_worklet_thread_test.cc
M third_party/blink/renderer/modules/webaudio/semi_realtime_audio_worklet_thread.cc
M third_party/blink/renderer/platform/graphics/begin_frame_provider.cc
M third_party/blink/renderer/platform/scheduler/common/thread.cc
M third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
M third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
M third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
M ui/compositor/display_link_mac_mojo.mm
M ui/events/ozone/evdev/event_thread_evdev.cc
M ui/gl/vsync_thread_win.cc
M ui/ozone/platform/drm/gpu/drm_thread.cc

Change size: M

Delta: 49 files changed, 109 insertions(+), 104 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: Bot-Commit+1 by luci-bi...@appspot.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages