Enable webgpu_on_vulkan_via_gl_interop only for wayland [chromium/src : main]

1 view
Skip to first unread message

Kramer Ge (Gerrit)

unread,
Apr 13, 2026, 10:08:01 PMApr 13
to Colin Blundell, Peter McNeeley, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Colin Blundell and Peter McNeeley

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Peter McNeeley
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iec7e089ceaeb0c2882757f569b894cee1992df70
Gerrit-Change-Number: 7760622
Gerrit-PatchSet: 1
Gerrit-Owner: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Attention: Peter McNeeley <peterm...@google.com>
Gerrit-Comment-Date: Tue, 14 Apr 2026 02:07:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Peter McNeeley (Gerrit)

unread,
Apr 13, 2026, 10:57:24 PMApr 13
to Kramer Ge, Colin Blundell, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
Attention needed from Colin Blundell and Kramer Ge

Peter McNeeley voted and added 1 comment

Votes added by Peter McNeeley

Code-Review+1

1 comment

File ui/ozone/platform/wayland/ozone_platform_wayland.cc
Line 363, Patchset 3 (Latest): properties->webgpu_on_vulkan_via_gl_interop = true;
Peter McNeeley . unresolved

Comments for the workaround are of course required.

Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
  • Kramer Ge
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iec7e089ceaeb0c2882757f569b894cee1992df70
    Gerrit-Change-Number: 7760622
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
    Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
    Gerrit-Attention: Colin Blundell <blun...@chromium.org>
    Gerrit-Attention: Kramer Ge <fang...@chromium.org>
    Gerrit-Comment-Date: Tue, 14 Apr 2026 02:57:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kramer Ge (Gerrit)

    unread,
    Apr 13, 2026, 11:55:05 PMApr 13
    to Peter McNeeley, Colin Blundell, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
    Attention needed from Colin Blundell

    Kramer Ge voted and added 1 comment

    Votes added by Kramer Ge

    Commit-Queue+1

    1 comment

    File ui/ozone/platform/wayland/ozone_platform_wayland.cc
    Line 363, Patchset 3: properties->webgpu_on_vulkan_via_gl_interop = true;
    Peter McNeeley . resolved

    Comments for the workaround are of course required.

    Kramer Ge

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Colin Blundell
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iec7e089ceaeb0c2882757f569b894cee1992df70
      Gerrit-Change-Number: 7760622
      Gerrit-PatchSet: 4
      Gerrit-Owner: Kramer Ge <fang...@chromium.org>
      Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
      Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
      Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
      Gerrit-Attention: Colin Blundell <blun...@chromium.org>
      Gerrit-Comment-Date: Tue, 14 Apr 2026 03:54:58 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Peter McNeeley <peterm...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Colin Blundell (Gerrit)

      unread,
      Apr 14, 2026, 3:09:32 AMApr 14
      to Kramer Ge, Colin Blundell, Peter McNeeley, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org
      Attention needed from Kramer Ge

      Colin Blundell voted and added 1 comment

      Votes added by Colin Blundell

      Code-Review+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 4 (Latest):
      Colin Blundell . resolved

      //gpu lgtm, thanks!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Kramer Ge
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iec7e089ceaeb0c2882757f569b894cee1992df70
      Gerrit-Change-Number: 7760622
      Gerrit-PatchSet: 4
      Gerrit-Owner: Kramer Ge <fang...@chromium.org>
      Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
      Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
      Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
      Gerrit-Attention: Kramer Ge <fang...@chromium.org>
      Gerrit-Comment-Date: Tue, 14 Apr 2026 07:09:12 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Kramer Ge (Gerrit)

      unread,
      Apr 14, 2026, 10:11:10 AMApr 14
      to Colin Blundell, Peter McNeeley, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

      Kramer Ge voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iec7e089ceaeb0c2882757f569b894cee1992df70
      Gerrit-Change-Number: 7760622
      Gerrit-PatchSet: 4
      Gerrit-Owner: Kramer Ge <fang...@chromium.org>
      Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
      Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
      Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
      Gerrit-Comment-Date: Tue, 14 Apr 2026 14:11:03 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

      unread,
      Apr 14, 2026, 10:17:43 AMApr 14
      to Kramer Ge, Colin Blundell, Peter McNeeley, chromium...@chromium.org, max+watc...@igalia.com, nickdiego+wa...@igalia.com, ozone-...@chromium.org

      chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change

      Change information

      Commit message:
      Enable webgpu_on_vulkan_via_gl_interop only for wayland

      On x11, creating a vulkan device seems to cause vaapi_wrapper to select
      the iGPU causing chrome to composite blank video on the nvidia dGPU.

      This is a temporary fix when the CL to convey correct gpu vendor/device
      to media is wip.
      Bug: 500609035
      Change-Id: Iec7e089ceaeb0c2882757f569b894cee1992df70
      Reviewed-by: Colin Blundell <blun...@chromium.org>
      Reviewed-by: Peter McNeeley <peterm...@google.com>
      Commit-Queue: Kramer Ge <fang...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1614430}
      Files:
      • M gpu/ipc/service/gpu_init.cc
      • M ui/ozone/platform/wayland/ozone_platform_wayland.cc
      • M ui/ozone/public/ozone_platform.h
      Change size: S
      Delta: 3 files changed, 22 insertions(+), 1 deletion(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Colin Blundell, +1 by Peter McNeeley
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iec7e089ceaeb0c2882757f569b894cee1992df70
      Gerrit-Change-Number: 7760622
      Gerrit-PatchSet: 5
      Gerrit-Owner: Kramer Ge <fang...@chromium.org>
      Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
      Gerrit-Reviewer: Kramer Ge <fang...@chromium.org>
      Gerrit-Reviewer: Peter McNeeley <peterm...@google.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages