Vincent Chiang (Gerrit)

unread,

Mar 17, 2026, 6:53:16 PMMar 17

to Mitsuru Oshima, AyeAye, ozone-...@chromium.org

Attention needed from Mitsuru Oshima

Vincent Chiang added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Vincent Chiang . resolved

Oshima-san, Please take a look at this merge request. Thank you!

Open in Gerrit

Related details

Attention is currently required from:

Mitsuru Oshima

Submit Requirements:

Code-Owners
Code-Review
Lint
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Vincent Chiang (Gerrit)

unread,

Mar 17, 2026, 6:53:59 PMMar 17

to Mitsuru Oshima, AyeAye, ozone-...@chromium.org

Vincent Chiang voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Lint
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Mitsuru Oshima (Gerrit)

unread,

Mar 17, 2026, 6:54:14 PMMar 17

to Vincent Chiang, AyeAye, ozone-...@chromium.org

Attention needed from Vincent Chiang

Mitsuru Oshima voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Vincent Chiang

Submit Requirements:

Code-Owners
Code-Review
Lint
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Mar 17, 2026, 7:58:28 PMMar 17

to Vincent Chiang, Mitsuru Oshima, AyeAye, ozone-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[M147] Compensate tablet input with panel orientation

Add rotation logic to TabletEventConverterEvdev so devices with none-0
panel orientation can use tablet devices. The change adds a transform
to tablet input coordinates before updating cursor location.

(cherry picked from commit e824c7895e1a0ea952409a06a1a401e08487613c)

Bug: b:487118330, b:162444998

Change-Id: I52c48f543ae2b5eda98327b5274266d75b856996

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7635718

Reviewed-by: Mitsuru Oshima <osh...@chromium.org>

Commit-Queue: Vincent Chiang <vincen...@chromium.org>

Reviewed-by: Zoraiz Naeem <zorai...@chromium.org>

Cr-Original-Commit-Position: refs/heads/main@{#1598230}

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7676170

Cr-Commit-Position: refs/branch-heads/7727@{#656}

Cr-Branched-From: ce01102937348db7b88c8a4257ee4b3ac702eb1a-refs/heads/main@{#1596535}

Files:

M ui/events/ozone/evdev/BUILD.gn
M ui/events/ozone/evdev/tablet_event_converter_evdev.cc
M ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc

Change size: M

Delta: 3 files changed, 176 insertions(+), 11 deletions(-)

Branch: refs/branch-heads/7727

Submit Requirements:

Code-Review: +1 by Mitsuru Oshima

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[M147] Compensate tablet input with panel orientation [chromium/src : refs/branch-heads/7727]

Vincent Chiang (Gerrit)

Vincent Chiang added 1 comment

Related details

Vincent Chiang (Gerrit)

Vincent Chiang voted Commit-Queue+2

Related details

Mitsuru Oshima (Gerrit)

Mitsuru Oshima voted Code-Review+1

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information