Revert "Fix touchpad scroll sensitivity on Wayland." [chromium/src : main]
0 views
Skip to first unread message
Rubber Stamper (Gerrit)
Nov 19, 2025, 4:34:19 PM (12 days ago) Nov 19
to Jamie Walch, Orko Garai, Chromium LUCI CQ, Thomas Anderson, AyeAye, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com
Attention needed from Orko Garai and Thomas Anderson
Message from Rubber Stamper![]( "Open in Gerrit")
The change is not in the configured time window. Rubber Stamper is only allowed to review reverts within 14 day(s). Learn more: go/rubber-stamper-user-guide.
Related details
Attention is currently required from:
- Orko Garai
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Orko Garai (Gerrit)
Nov 19, 2025, 4:38:01 PM (12 days ago) Nov 19
to Jamie Walch, Chromium LUCI CQ, Thomas Anderson, AyeAye, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com
Attention needed from Jamie Walch and Thomas Anderson
Orko Garai voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jamie Walch
- Thomas Anderson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Anderson (Gerrit)
Nov 19, 2025, 4:52:37 PM (12 days ago) Nov 19
to Jamie Walch, Orko Garai, Chromium LUCI CQ, AyeAye, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com
Attention needed from Jamie Walch
Thomas Anderson voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jamie Walch
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jamie Walch (Gerrit)
Nov 19, 2025, 5:09:09 PM (12 days ago) Nov 19
to Thomas Anderson, Orko Garai, Chromium LUCI CQ, AyeAye, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com
Jamie Walch voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 19, 2025, 5:49:46 PM (12 days ago) Nov 19
to Jamie Walch, Thomas Anderson, Orko Garai, AyeAye, max+watc...@igalia.com, ozone-...@chromium.org, nickdiego+wa...@igalia.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "Fix touchpad scroll sensitivity on Wayland."
This reverts commit ded09f2a729ad7d92f404bd9f86fac819f178f8b.
Reason for revert: Users found the slower scroll speed relative to other Wayland applications to be disruptive.
Original change's description:
> Fix touchpad scroll sensitivity on Wayland.
>
> Chrome's scroll sensitivity with a touchpad is much higher on Wayland
> than on other OSes. Chrome isn't alone in this--Terminal and several
> other applications also scroll much faster than I'd expect--but one
> notable exception is the "Test settings" page of the touchpad
> configuration UI, the scroll sensitivity of which feels comparable to
> using a touchpad on other OSes.
>
> I believe that axis events coming via `OnAxis` should not be scaled at
> all. That feels right when using a physical touchpad, but more
> importantly, if `ei_device_scroll_delta` is used to inject scroll
> events, the magnitude of those events is specified in pixels. The
> comment in `OnAxis` (that this CL deletes) mentioned wheel ticks, but
> this CL doesn't affect wheel ticks at all, since they are delivered via
> `OnAxis120`, which takes precedence.
>
> My ultimate goal is to have CRD host use `ei_device_scroll_delta` so
> that we can support smooth scrolling. It's not currently possible due
> to https://gitlab.freedesktop.org/libinput/libei/-/issues/88, but this
> CL is a prerequisite. In particular, if the `OnAxis120` implementation
> is removed in addition to this CL, then I can get the scroll distances
> to match on client and host when Chrome Wayland is used at both ends.
> Without this CL, Chrome running on the host scrolls 144 times too far
> due to scroll distances being multiplied by 12 by Chrome at both ends.
>
> Change-Id: Id576c3a10e3dc1847ab278502b31baf51592ce55
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7004208
> Commit-Queue: Thomas Anderson <thomasa...@chromium.org>
> Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
> Auto-Submit: Jamie Walch <jamie...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1524565}
Change-Id: I8245e2ee835991cdfe082a6d34cd00a25603d155
Reviewed-by: Thomas Anderson <thomasa...@chromium.org>
Commit-Queue: Jamie Walch <jamie...@chromium.org>
Reviewed-by: Orko Garai <or...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1547498}
Files:
- M ui/ozone/platform/wayland/host/wayland_pointer.cc
- M ui/ozone/platform/wayland/host/wayland_pointer_unittest.cc
Change size: M
Delta: 2 files changed, 10 insertions(+), 40 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Orko Garai, +1 by Thomas Anderson
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages